From 2035e5b7d42046be8479b8fd9dd93cf9048a1dd4 Mon Sep 17 00:00:00 2001 From: Felix Kirchner Date: Tue, 21 Apr 2026 20:24:10 +0200 Subject: [PATCH] Removed unnecessary declared attributes --- .../group_view/create_group_view.dart | 2 +- .../main_menu/group_view/group_view.dart | 2 +- .../views/main_menu/statistics_view.dart | 6 ++--- .../widgets/player_selection.dart | 4 ++-- test/db_tests/aggregates/group_test.dart | 8 +++---- test/db_tests/aggregates/match_test.dart | 22 +++++++---------- test/db_tests/aggregates/team_test.dart | 8 +++---- test/db_tests/entities/player_test.dart | 12 +++++----- .../relationships/player_group_test.dart | 8 +++---- .../relationships/player_match_test.dart | 24 ++++++++----------- test/db_tests/values/score_test.dart | 8 +++---- 11 files changed, 46 insertions(+), 58 deletions(-) diff --git a/lib/presentation/views/main_menu/group_view/create_group_view.dart b/lib/presentation/views/main_menu/group_view/create_group_view.dart index d5ac6a4..f88e2db 100644 --- a/lib/presentation/views/main_menu/group_view/create_group_view.dart +++ b/lib/presentation/views/main_menu/group_view/create_group_view.dart @@ -148,7 +148,7 @@ class _CreateGroupViewState extends State { final groupName = _groupNameController.text.trim(); final success = await db.groupDao.addGroup( - group: Group(name: groupName, description: '', members: selectedPlayers), + group: Group(name: groupName, members: selectedPlayers), ); return success; diff --git a/lib/presentation/views/main_menu/group_view/group_view.dart b/lib/presentation/views/main_menu/group_view/group_view.dart index b091541..c8a9398 100644 --- a/lib/presentation/views/main_menu/group_view/group_view.dart +++ b/lib/presentation/views/main_menu/group_view/group_view.dart @@ -36,7 +36,7 @@ class _GroupViewState extends State { Group( name: 'Skeleton Group', description: '', - members: List.filled(6, Player(name: 'Skeleton Player', description: '')), + members: List.filled(6, Player(name: 'Skeleton Player')), ), ); diff --git a/lib/presentation/views/main_menu/statistics_view.dart b/lib/presentation/views/main_menu/statistics_view.dart index b0b9c22..3ffab7c 100644 --- a/lib/presentation/views/main_menu/statistics_view.dart +++ b/lib/presentation/views/main_menu/statistics_view.dart @@ -167,8 +167,7 @@ class _StatisticsViewState extends State { final playerId = winCounts[i].$1; final player = players.firstWhere( (p) => p.id == playerId, - orElse: () => - Player(id: playerId, name: loc.not_available, description: ''), + orElse: () => Player(id: playerId, name: loc.not_available), ); winCounts[i] = (player.name, winCounts[i].$2); } @@ -230,8 +229,7 @@ class _StatisticsViewState extends State { final playerId = matchCounts[i].$1; final player = players.firstWhere( (p) => p.id == playerId, - orElse: () => - Player(id: playerId, name: loc.not_available, description: ''), + orElse: () => Player(id: playerId, name: loc.not_available), ); matchCounts[i] = (player.name, matchCounts[i].$2); } diff --git a/lib/presentation/widgets/player_selection.dart b/lib/presentation/widgets/player_selection.dart index 6d8769d..a1e7a95 100644 --- a/lib/presentation/widgets/player_selection.dart +++ b/lib/presentation/widgets/player_selection.dart @@ -62,7 +62,7 @@ class _PlayerSelectionState extends State { /// Skeleton data used while loading players. late final List skeletonData = List.filled( 7, - Player(name: 'Player 0', description: ''), + Player(name: 'Player 0'), ); @override @@ -282,7 +282,7 @@ class _PlayerSelectionState extends State { final loc = AppLocalizations.of(context); final playerName = _searchBarController.text.trim(); - final createdPlayer = Player(name: playerName, description: ''); + final createdPlayer = Player(name: playerName); final success = await db.playerDao.addPlayer(player: createdPlayer); if (!context.mounted) return; diff --git a/test/db_tests/aggregates/group_test.dart b/test/db_tests/aggregates/group_test.dart index 5e713c4..3d51a06 100644 --- a/test/db_tests/aggregates/group_test.dart +++ b/test/db_tests/aggregates/group_test.dart @@ -29,10 +29,10 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); testGroup1 = Group( name: 'Test Group', description: '', diff --git a/test/db_tests/aggregates/match_test.dart b/test/db_tests/aggregates/match_test.dart index 245cca1..14cdcad 100644 --- a/test/db_tests/aggregates/match_test.dart +++ b/test/db_tests/aggregates/match_test.dart @@ -36,11 +36,11 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); - testPlayer5 = Player(name: 'Eve', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); + testPlayer5 = Player(name: 'Eve'); testGroup1 = Group( name: 'Test Group 1', description: '', @@ -62,28 +62,24 @@ void main() { name: 'First Test Match', game: testGame, group: testGroup1, - players: [testPlayer4, testPlayer5], - notes: '', + players: [testPlayer4, testPlayer5] ); testMatch2 = Match( name: 'Second Test Match', game: testGame, group: testGroup2, - players: [testPlayer1, testPlayer2, testPlayer3], - notes: '', + players: [testPlayer1, testPlayer2, testPlayer3] ); testMatchOnlyPlayers = Match( name: 'Test Match with Players', game: testGame, - players: [testPlayer1, testPlayer2, testPlayer3], - notes: '', + players: [testPlayer1, testPlayer2, testPlayer3] ); testMatchOnlyGroup = Match( name: 'Test Match with Group', game: testGame, group: testGroup2, - players: testGroup2.members, - notes: '', + players: testGroup2.members ); }); await database.playerDao.addPlayersAsList( diff --git a/test/db_tests/aggregates/team_test.dart b/test/db_tests/aggregates/team_test.dart index 0850936..39c5be5 100644 --- a/test/db_tests/aggregates/team_test.dart +++ b/test/db_tests/aggregates/team_test.dart @@ -33,10 +33,10 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); testTeam1 = Team(name: 'Team Alpha', members: [testPlayer1, testPlayer2]); testTeam2 = Team(name: 'Team Beta', members: [testPlayer3, testPlayer4]); testTeam3 = Team(name: 'Team Gamma', members: [testPlayer1, testPlayer3]); diff --git a/test/db_tests/entities/player_test.dart b/test/db_tests/entities/player_test.dart index 3042b33..fdb5e7b 100644 --- a/test/db_tests/entities/player_test.dart +++ b/test/db_tests/entities/player_test.dart @@ -24,10 +24,10 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Test Player', description: ''); - testPlayer2 = Player(name: 'Second Player', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); + testPlayer1 = Player(name: 'Test Player'); + testPlayer2 = Player(name: 'Second Player'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); }); }); tearDown(() async { @@ -348,7 +348,7 @@ void main() { // Verifies that a player with empty string name is stored correctly. test('Player with empty string name is stored correctly', () async { - final emptyNamePlayer = Player(name: '', description: ''); + final emptyNamePlayer = Player(name: ''); await database.playerDao.addPlayer(player: emptyNamePlayer); @@ -361,7 +361,7 @@ void main() { // Verifies that a player with very long name is stored correctly. test('Player with very long name is stored correctly', () async { final longName = 'A' * 1000; - final longNamePlayer = Player(name: longName, description: ''); + final longNamePlayer = Player(name: longName); await database.playerDao.addPlayer(player: longNamePlayer); diff --git a/test/db_tests/relationships/player_group_test.dart b/test/db_tests/relationships/player_group_test.dart index 7004e17..f687b1c 100644 --- a/test/db_tests/relationships/player_group_test.dart +++ b/test/db_tests/relationships/player_group_test.dart @@ -26,10 +26,10 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); testGroup = Group( name: 'Test Group', description: '', diff --git a/test/db_tests/relationships/player_match_test.dart b/test/db_tests/relationships/player_match_test.dart index 3071edf..4f77bdb 100644 --- a/test/db_tests/relationships/player_match_test.dart +++ b/test/db_tests/relationships/player_match_test.dart @@ -37,12 +37,12 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); - testPlayer4 = Player(name: 'Diana', description: ''); - testPlayer5 = Player(name: 'Eve', description: ''); - testPlayer6 = Player(name: 'Frank', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); + testPlayer4 = Player(name: 'Diana'); + testPlayer5 = Player(name: 'Eve'); + testPlayer6 = Player(name: 'Frank'); testGroup = Group( name: 'Test Group', description: '', @@ -59,14 +59,12 @@ void main() { name: 'Test Match with Group', game: testGame, players: testGroup.members, - group: testGroup, - notes: '', + group: testGroup ); testMatchOnlyPlayers = Match( name: 'Test Match with Players', game: testGame, - players: [testPlayer4, testPlayer5, testPlayer6], - notes: '', + players: [testPlayer4, testPlayer5, testPlayer6] ); testTeam1 = Team(name: 'Team Alpha', members: [testPlayer1, testPlayer2]); testTeam2 = Team(name: 'Team Beta', members: [testPlayer3, testPlayer4]); @@ -568,14 +566,12 @@ void main() { final match1 = Match( name: 'Match 1', game: testGame, - players: playersList, - notes: '', + players: playersList ); final match2 = Match( name: 'Match 2', game: testGame, - players: playersList, - notes: '', + players: playersList ); await Future.wait([ diff --git a/test/db_tests/values/score_test.dart b/test/db_tests/values/score_test.dart index c5e2209..d550995 100644 --- a/test/db_tests/values/score_test.dart +++ b/test/db_tests/values/score_test.dart @@ -30,9 +30,9 @@ void main() { ); withClock(fakeClock, () { - testPlayer1 = Player(name: 'Alice', description: ''); - testPlayer2 = Player(name: 'Bob', description: ''); - testPlayer3 = Player(name: 'Charlie', description: ''); + testPlayer1 = Player(name: 'Alice'); + testPlayer2 = Player(name: 'Bob'); + testPlayer3 = Player(name: 'Charlie'); testGame = Game( name: 'Test Game', ruleset: Ruleset.singleWinner, @@ -44,13 +44,11 @@ void main() { name: 'Test Match 1', game: testGame, players: [testPlayer1, testPlayer2], - notes: '', ); testMatch2 = Match( name: 'Test Match 2', game: testGame, players: [testPlayer2, testPlayer3], - notes: '', ); });