fix: tests for name count

lib/data/dao/player_dao.dart

@@ -17,7 +17,7 @@ class PlayerDao extends DatabaseAccessor<AppDatabase> with _$PlayerDaoMixin {
   /// the new one.
   Future<bool> addPlayer({required Player player}) async {
     if (!await playerExists(playerId: player.id)) {
-      final int nameCount = await processNameCount(name: player.name);
+      final int nameCount = await _processNameCount(name: player.name);
 
       await into(playerTable).insert(
         PlayerTableCompanion.insert(
@@ -64,7 +64,7 @@ class PlayerDao extends DatabaseAccessor<AppDatabase> with _$PlayerDaoMixin {
       final playersWithName = entry.value;
 
       // Get the current nameCount
-      var nameCount = await processNameCount(name: name);
+      var nameCount = await _processNameCount(name: name);
 
       // One player with the same name
       if (playersWithName.length == 1) {
@@ -172,7 +172,7 @@ class PlayerDao extends DatabaseAccessor<AppDatabase> with _$PlayerDaoMixin {
     final previousNameCount = await getNameCount(name: previousPlayerName);
 
     // Update name count for the new name
-    final newNameCount = await processNameCount(name: name);
+    final newNameCount = await _processNameCount(name: name);
 
     // Update name and nameCount
     final rowsAffected =
@@ -265,12 +265,11 @@ class PlayerDao extends DatabaseAccessor<AppDatabase> with _$PlayerDaoMixin {
     return null;
   }
 
-  @visibleForTesting
   /// Processes the name count for a new player with the given [name].
   ///- 0 Player: returning 0
   ///- 1 Player: returning 2, and initializes the nameCount for the existing player to 1
   ///- Other: returning the existing count + 1
-  Future<int> processNameCount({required String name}) async {
+  Future<int> _processNameCount({required String name}) async {
     final nameCount = await calculateNameCount(name: name);
     if (nameCount == 2) {
       // If one other player exists with the same name, initialize the nameCount

test/db_tests/entities/player_test.dart

@@ -372,14 +372,22 @@ void main() {
           final player1 = Player(name: testPlayer1.name, description: '');
           await database.playerDao.addPlayer(player: player1);
 
+          final player2 = Player(name: testPlayer1.name, description: '');
+          await database.playerDao.addPlayer(player: player2);
+
           var players = await database.playerDao.getAllPlayers();
 
-          expect(players.length, 2);
+          expect(players.length, 3);
           players.sort((a, b) => a.nameCount.compareTo(b.nameCount));
 
           for (int i = 0; i < players.length - 1; i++) {
             expect(players[i].nameCount, i + 1);
           }
+
+          // ids are correct in the right order
+          expect(players[0].id, testPlayer1.id);
+          expect(players[1].id, player1.id);
+          expect(players[2].id, player2.id);
         },
       );
 
@@ -404,24 +412,62 @@ void main() {
           for (int i = 0; i < players.length - 1; i++) {
             expect(players[i].nameCount, i + 1);
           }
+
+          // ids are correct in the right order
+          expect(players[0].id, testPlayer1.id);
+          expect(players[1].id, player1.id);
+          expect(players[2].id, player2.id);
+          expect(players[3].id, player3.id);
         },
       );
 
-      test('getNameCount works  correctly', () async {
+      test('getNameCount works correctly', () async {
+        final player1 = Player(name: testPlayer1.name);
         final player2 = Player(name: testPlayer1.name);
-        final player3 = Player(name: testPlayer1.name);
 
-        await database.playerDao.addPlayersAsList(
+        await database.playerDao.addPlayer(player: testPlayer1);
-          players: [testPlayer1, player2, player3],
+
+        var nameCount = await database.playerDao.getNameCount(
+          name: testPlayer1.name,
         );
 
-        final nameCount = await database.playerDao.getNameCount(
+        expect(nameCount, 1);
+
+        await database.playerDao.addPlayersAsList(players: [player1, player2]);
+
+        nameCount = await database.playerDao.getNameCount(
           name: testPlayer1.name,
         );
 
         expect(nameCount, 3);
       });
 
+      test('calculateNameCount works correctly', () async {
+        final player1 = Player(name: testPlayer1.name);
+        final player2 = Player(name: testPlayer1.name);
+
+        // Case 1: No existing players with the name
+        var nameCount = await database.playerDao.calculateNameCount(
+          name: testPlayer1.name,
+        );
+        expect(nameCount, 0);
+
+        // Case 2: One existing player with the name. Should  return 2 for
+        // the new player
+        await database.playerDao.addPlayer(player: testPlayer1);
+        nameCount = await database.playerDao.calculateNameCount(
+          name: testPlayer1.name,
+        );
+        expect(nameCount, 2);
+
+        // Case 3: Multiple existing players with the name. Should return count + 1
+        await database.playerDao.addPlayersAsList(players: [player1, player2]);
+        nameCount = await database.playerDao.calculateNameCount(
+          name: testPlayer1.name,
+        );
+        expect(nameCount, 4);
+      });
+
       test('updateNameCount works correctly', () async {
         await database.playerDao.addPlayer(player: testPlayer1);
 
@@ -441,14 +487,24 @@ void main() {
         final player2 = Player(name: testPlayer1.name, description: '');
         final player3 = Player(name: testPlayer1.name, description: '');
 
-        await database.playerDao.addPlayersAsList(
+        await database.playerDao.addPlayer(player: testPlayer1);
-          players: [testPlayer1, player2, player3],
+        var player = await database.playerDao.getPlayerWithHighestNameCount(
-        );
-
-        final player = await database.playerDao.getPlayerWithHighestNameCount(
           name: testPlayer1.name,
         );
+        expect(player, isNotNull);
+        expect(player!.nameCount, 0);
 
+        await database.playerDao.addPlayer(player: player2);
+        player = await database.playerDao.getPlayerWithHighestNameCount(
+          name: testPlayer1.name,
+        );
+        expect(player, isNotNull);
+        expect(player!.nameCount, 2);
+
+        await database.playerDao.addPlayer(player: player3);
+        player = await database.playerDao.getPlayerWithHighestNameCount(
+          name: testPlayer1.name,
+        );
         expect(player, isNotNull);
         expect(player!.nameCount, 3);
       });
@@ -460,32 +516,6 @@ void main() {
         expect(player, isNull);
       });
 
-      test('calculateNameCount works correctly', () async {
-        // Case 1: No existing players with the name
-        var count = await database.playerDao.calculateNameCount(
-          name: testPlayer1.name,
-        );
-        expect(count, 0);
-
-        // Case 2: One existing player with the name. Should update that
-        // player's nameCount to 1 and return 2 for the new player
-        await database.playerDao.addPlayer(player: testPlayer1);
-
-        count = await database.playerDao.calculateNameCount(
-          name: testPlayer1.name,
-        );
-        expect(count, 2);
-
-        // Case 3: Multiple existing players with the name.
-        final player2 = Player(name: testPlayer1.name, nameCount: count);
-        await database.playerDao.addPlayer(player: player2);
-
-        count = await database.playerDao.calculateNameCount(
-          name: testPlayer1.name,
-        );
-        expect(count, 3);
-      });
-
       test('getPlayerWithHighestNameCount with non existing player', () async {
         await database.playerDao.addPlayer(player: testPlayer1);
         await database.playerDao.initializeNameCount(name: testPlayer1.name);