From 974d6e9b56ce94764004d941954e14f973a84dfe Mon Sep 17 00:00:00 2001
From: mathiskirchner <mathis.kirchner.mk@gmail.com>
Date: Sun, 23 Nov 2025 22:14:13 +0100
Subject: [PATCH] refactor empty state logic in CreateGroupView

The diff introduces boolean variables `doneLoading` and `snapshotDataEmpty` to simplify the conditional check for displaying the empty state message. It specifically fixes the logic to correctly show the "No players found" message when both the snapshot and the local `allPlayers` list are empty, removing the dependency on `selectedPlayers.isEmpty`.
---
 .../views/main_menu/create_group_view.dart          | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/presentation/views/main_menu/create_group_view.dart b/lib/presentation/views/main_menu/create_group_view.dart
index 59f72ed..c01250b 100644
--- a/lib/presentation/views/main_menu/create_group_view.dart
+++ b/lib/presentation/views/main_menu/create_group_view.dart
@@ -209,12 +209,13 @@ class _CreateGroupViewState extends State<CreateGroupView> {
                                 ),
                               );
                             }
-                            if (snapshot.connectionState ==
-                                    ConnectionState.done &&
-                                (!snapshot.hasData ||
-                                    snapshot.data!.isEmpty ||
-                                    (selectedPlayers.isEmpty &&
-                                        allPlayers.isEmpty))) {
+                            bool doneLoading =
+                                snapshot.connectionState ==
+                                ConnectionState.done;
+                            bool snapshotDataEmpty =
+                                !snapshot.hasData || snapshot.data!.isEmpty;
+                            if (doneLoading &&
+                                (snapshotDataEmpty && allPlayers.isEmpty)) {
                               return const Center(
                                 child: TopCenteredMessage(
                                   icon: Icons.info,