6 Commits

Author SHA1 Message Date
Yannick
44279bc148 Merge remote-tracking branch 'origin/development' into feature/2-gamehistoryview-anpassen
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m15s
Pull Request Pipeline / lint (pull_request) Failing after 2m15s
2025-11-24 11:34:59 +01:00
a3fa499662 Merge pull request 'Gelbes Aufblinken der Recent Games auf der Homepage behoben & Anpassung des Recent-Games-Containers vorgenommen.' (#64) from bug/63-übergang-auf-home-seite-blitz-kurz-gelb-auf into development
Reviewed-on: #64
Reviewed-by: Felix Kirchner <felix.kirchner.fk@gmail.com>
2025-11-23 21:51:04 +00:00
f25737cdc5 Merge branch 'development' into bug/63-übergang-auf-home-seite-blitz-kurz-gelb-auf
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Pull Request Pipeline / lint (pull_request) Successful in 2m9s
2025-11-23 21:48:48 +00:00
0b500b5248 Merge pull request 'Bugfix bei Spieleranzeige und Vereinfachung der Keine-Player-Logik' (#66) from bug/60-CreateGroupView-erstellter-Spieler-erscheint-nicht-in-alle-Spieler into development
Reviewed-on: #66
Reviewed-by: Felix Kirchner <felix.kirchner.fk@gmail.com>
2025-11-23 21:41:08 +00:00
974d6e9b56 refactor empty state logic in CreateGroupView
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m22s
Pull Request Pipeline / lint (pull_request) Successful in 2m24s
The diff introduces boolean variables `doneLoading` and `snapshotDataEmpty` to simplify the conditional check for displaying the empty state message. It specifically fixes the logic to correctly show the "No players found" message when both the snapshot and the local `allPlayers` list are empty, removing the dependency on `selectedPlayers.isEmpty`.
2025-11-23 22:14:13 +01:00
694cac7f26 Fix bug where the skeleton was edited while it was visible and
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
match the “no games available” container size to the size used when games are available.
2025-11-23 21:16:13 +01:00
2 changed files with 8 additions and 16 deletions

View File

@@ -209,12 +209,13 @@ class _CreateGroupViewState extends State<CreateGroupView> {
), ),
); );
} }
if (snapshot.connectionState == bool doneLoading =
ConnectionState.done && snapshot.connectionState ==
(!snapshot.hasData || ConnectionState.done;
snapshot.data!.isEmpty || bool snapshotDataEmpty =
(selectedPlayers.isEmpty && !snapshot.hasData || snapshot.data!.isEmpty;
allPlayers.isEmpty))) { if (doneLoading &&
(snapshotDataEmpty && allPlayers.isEmpty)) {
return const Center( return const Center(
child: TopCenteredMessage( child: TopCenteredMessage(
icon: Icons.info, icon: Icons.info,

View File

@@ -151,15 +151,6 @@ class _HomeViewState extends State<HomeView> {
), ),
); );
} }
if (snapshot.connectionState ==
ConnectionState.done &&
(!snapshot.hasData ||
snapshot.data!.isEmpty)) {
return const Center(
heightFactor: 4,
child: Text('No recent games available.'),
);
}
final List<Game> games = final List<Game> games =
(isLoading (isLoading
? skeletonData ? skeletonData
@@ -214,7 +205,7 @@ class _HomeViewState extends State<HomeView> {
); );
} else { } else {
return const Center( return const Center(
heightFactor: 4, heightFactor: 12,
child: Text('No recent games available.'), child: Text('No recent games available.'),
); );
} }