Merge pull request 'Bugfix bei Spieleranzeige und Vereinfachung der Keine-Player-Logik' (#66 ) from bug/60-CreateGroupView-erstellter-Spieler-erscheint-nicht-in-alle-Spieler into development

Reviewed-on: #66 Reviewed-by: Felix Kirchner <felix.kirchner.fk@gmail.com>
refactor empty state logic in CreateGroupView
2025-11-23 21:41:08 +00:00 · 2025-11-23 22:14:13 +01:00
1 changed files with 7 additions and 6 deletions
--- a/lib/presentation/views/main_menu/create_group_view.dart
+++ b/lib/presentation/views/main_menu/create_group_view.dart
@@ -209,12 +209,13 @@ class _CreateGroupViewState extends State<CreateGroupView> {
                                ),
                              );
                            }
-                            if (snapshot.connectionState ==
+                            bool doneLoading =
-                                    ConnectionState.done &&
+                                snapshot.connectionState ==
-                                (!snapshot.hasData ||
+                                ConnectionState.done;
-                                    snapshot.data!.isEmpty ||
+                            bool snapshotDataEmpty =
-                                    (selectedPlayers.isEmpty &&
+                                !snapshot.hasData || snapshot.data!.isEmpty;
-                                        allPlayers.isEmpty))) {
+                            if (doneLoading &&
                                (snapshotDataEmpty && allPlayers.isEmpty)) {
                              return const Center(
                                child: TopCenteredMessage(
                                  icon: Icons.info,
Author	SHA1	Message	Date
Felix Kirchner	0b500b5248	Merge pull request 'Bugfix bei Spieleranzeige und Vereinfachung der Keine-Player-Logik' (#66 ) from bug/60-CreateGroupView-erstellter-Spieler-erscheint-nicht-in-alle-Spieler into development Reviewed-on: #66 Reviewed-by: Felix Kirchner <felix.kirchner.fk@gmail.com>	2025-11-23 21:41:08 +00:00
mathiskirchner	974d6e9b56	refactor empty state logic in CreateGroupView All checks were successful Pull Request Pipeline / test (pull_request) Successful in 2m22s Details Pull Request Pipeline / lint (pull_request) Successful in 2m24s Details The diff introduces boolean variables `doneLoading` and `snapshotDataEmpty` to simplify the conditional check for displaying the empty state message. It specifically fixes the logic to correctly show the "No players found" message when both the snapshot and the local `allPlayers` list are empty, removing the dependency on `selectedPlayers.isEmpty`.	2025-11-23 22:14:13 +01:00