remove futurebuilder from match view and refactor

lib/presentation/views/main_menu/group_view/groups_view.dart

@@ -19,15 +19,15 @@ class GroupsView extends StatefulWidget {
 }
 
 class _GroupsViewState extends State<GroupsView> {
-  late Future<List<Group>> _allGroupsFuture;
   late final AppDatabase db;
+  late List<Group> loadedGroups;
+  bool isLoading = true;
 
-  final player = Player(name: 'Skeleton Player');
-  late final List<Group> skeletonData = List.filled(
+  List<Group> groups = List.filled(
     7,
     Group(
-      name: 'Skeleton Match',
-      members: [player, player, player, player, player, player],
+      name: 'Skeleton Group',
+      members: List.filled(6, Player(name: 'Skeleton Player')),
     ),
   );
 
@@ -35,10 +35,7 @@ class _GroupsViewState extends State<GroupsView> {
   void initState() {
     super.initState();
     db = Provider.of<AppDatabase>(context, listen: false);
-    _allGroupsFuture = Future.wait([
-      db.groupDao.getAllGroups(),
-      Future.delayed(minimumSkeletonDuration),
-    ]).then((results) => results[0] as List<Group>);
+    loadGroups();
   }
 
   @override
@@ -48,50 +45,30 @@ class _GroupsViewState extends State<GroupsView> {
       body: Stack(
         alignment: Alignment.center,
         children: [
-          FutureBuilder<List<Group>>(
-            future: _allGroupsFuture,
-            builder:
-                (BuildContext context, AsyncSnapshot<List<Group>> snapshot) {
-                  if (snapshot.hasError) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.report,
-                        title: 'Error',
-                        message: 'Group data couldn\'t\nbe loaded',
-                      ),
+          AppSkeleton(
+            enabled: isLoading,
+            child: Visibility(
+              visible: groups.isNotEmpty,
+              replacement: const Center(
+                child: TopCenteredMessage(
+                  icon: Icons.info,
+                  title: 'Info',
+                  message: 'No groups created yet',
+                ),
+              ),
+              child: ListView.builder(
+                padding: const EdgeInsets.only(bottom: 85),
+                itemCount: groups.length + 1,
+                itemBuilder: (BuildContext context, int index) {
+                  if (index == groups.length) {
+                    return SizedBox(
+                      height: MediaQuery.paddingOf(context).bottom - 20,
                     );
                   }
-                  if (snapshot.connectionState == ConnectionState.done &&
-                      (!snapshot.hasData || snapshot.data!.isEmpty)) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.info,
-                        title: 'Info',
-                        message: 'No groups created yet',
-                      ),
-                    );
-                  }
-                  final bool isLoading =
-                      snapshot.connectionState == ConnectionState.waiting;
-                  final List<Group> groups =
-                      isLoading ? skeletonData : (snapshot.data ?? [])
-                        ..sort((a, b) => b.createdAt.compareTo(a.createdAt));
-                  return AppSkeleton(
-                    enabled: isLoading,
-                    child: ListView.builder(
-                      padding: const EdgeInsets.only(bottom: 85),
-                      itemCount: groups.length + 1,
-                      itemBuilder: (BuildContext context, int index) {
-                        if (index == groups.length) {
-                          return SizedBox(
-                            height: MediaQuery.paddingOf(context).bottom - 20,
-                          );
-                        }
-                        return GroupTile(group: groups[index]);
-                      },
-                    ),
-                  );
+                  return GroupTile(group: groups[index]);
                 },
+              ),
+            ),
           ),
           Positioned(
             bottom: MediaQuery.paddingOf(context).bottom,
@@ -108,7 +85,7 @@ class _GroupsViewState extends State<GroupsView> {
                   ),
                 );
                 setState(() {
-                  _allGroupsFuture = db.groupDao.getAllGroups();
+                  loadGroups();
                 });
               },
             ),
@@ -117,4 +94,18 @@ class _GroupsViewState extends State<GroupsView> {
       ),
     );
   }
+
+  void loadGroups() {
+    Future.wait([
+      db.groupDao.getAllGroups(),
+      Future.delayed(minimumSkeletonDuration),
+    ]).then((results) {
+      loadedGroups = results[0] as List<Group>;
+      setState(() {
+        groups = loadedGroups
+          ..sort((a, b) => b.createdAt.compareTo(a.createdAt));
+      });
+      isLoading = false;
+    });
+  }
 }

lib/presentation/views/main_menu/match_view/match_view.dart

@@ -24,16 +24,16 @@ class MatchView extends StatefulWidget {
 }
 
 class _MatchViewState extends State<MatchView> {
-  late Future<List<Match>> _gameListFuture;
   late final AppDatabase db;
+  bool isLoading = true;
 
-  late final List<Match> skeletonData = List.filled(
+  List<Match> matches = List.filled(
     4,
     Match(
       name: 'Skeleton Gamename',
       group: Group(
         name: 'Groupname',
-        members: List.generate(5, (index) => Player(name: 'Player')),
+        members: List.filled(5, Player(name: 'Player')),
       ),
       winner: Player(name: 'Player'),
       players: [Player(name: 'Player')],
@@ -44,10 +44,7 @@ class _MatchViewState extends State<MatchView> {
   void initState() {
     super.initState();
     db = Provider.of<AppDatabase>(context, listen: false);
-    _gameListFuture = Future.wait([
-      db.matchDao.getAllMatches(),
-      Future.delayed(minimumSkeletonDuration),
-    ]).then((results) => results[0] as List<Match>);
+    loadGames();
   }
 
   @override
@@ -57,67 +54,44 @@ class _MatchViewState extends State<MatchView> {
       body: Stack(
         alignment: Alignment.center,
         children: [
-          FutureBuilder<List<Match>>(
-            future: _gameListFuture,
-            builder:
-                (BuildContext context, AsyncSnapshot<List<Match>> snapshot) {
-                  if (snapshot.hasError) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.report,
-                        title: 'Error',
-                        message: 'Game data could not be loaded',
-                      ),
+          AppSkeleton(
+            enabled: isLoading,
+            child: Visibility(
+              visible: matches.isNotEmpty,
+              replacement: const Center(
+                child: TopCenteredMessage(
+                  icon: Icons.report,
+                  title: 'Info',
+                  message: 'No games created yet',
+                ),
+              ),
+              child: ListView.builder(
+                padding: const EdgeInsets.only(bottom: 85),
+                itemCount: matches.length + 1,
+                itemBuilder: (BuildContext context, int index) {
+                  if (index == matches.length) {
+                    return SizedBox(
+                      height: MediaQuery.paddingOf(context).bottom - 80,
                     );
                   }
-                  if (snapshot.connectionState == ConnectionState.done &&
-                      (!snapshot.hasData || snapshot.data!.isEmpty)) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.report,
-                        title: 'Info',
-                        message: 'No games created yet',
-                      ),
-                    );
-                  }
-                  final bool isLoading =
-                      snapshot.connectionState == ConnectionState.waiting;
-                  final List<Match> matches =
-                      (isLoading ? skeletonData : (snapshot.data ?? [])
-                            ..sort(
-                              (a, b) => b.createdAt.compareTo(a.createdAt),
-                            ))
-                          .toList();
-                  return AppSkeleton(
-                    enabled: isLoading,
-                    child: ListView.builder(
-                      padding: const EdgeInsets.only(bottom: 85),
-                      itemCount: matches.length + 1,
-                      itemBuilder: (BuildContext context, int index) {
-                        if (index == matches.length) {
-                          return SizedBox(
-                            height: MediaQuery.paddingOf(context).bottom - 80,
-                          );
-                        }
-                        return GameHistoryTile(
-                          onTap: () async {
-                            Navigator.push(
-                              context,
-                              CupertinoPageRoute(
-                                fullscreenDialog: true,
-                                builder: (context) => GameResultView(
-                                  match: matches[index],
-                                  onWinnerChanged: refreshGameList,
-                                ),
-                              ),
-                            );
-                          },
-                          match: matches[index],
-                        );
-                      },
-                    ),
+                  return GameHistoryTile(
+                    onTap: () async {
+                      Navigator.push(
+                        context,
+                        CupertinoPageRoute(
+                          fullscreenDialog: true,
+                          builder: (context) => GameResultView(
+                            match: matches[index],
+                            onWinnerChanged: loadGames,
+                          ),
+                        ),
+                      );
+                    },
+                    match: matches[index],
                   );
                 },
+              ),
+            ),
           ),
           Positioned(
             bottom: MediaQuery.paddingOf(context).bottom,
@@ -129,7 +103,7 @@ class _MatchViewState extends State<MatchView> {
                   context,
                   MaterialPageRoute(
                     builder: (context) =>
-                        CreateMatchView(onWinnerChanged: refreshGameList),
+                        CreateMatchView(onWinnerChanged: loadGames),
                   ),
                 );
               },
@@ -140,9 +114,17 @@ class _MatchViewState extends State<MatchView> {
     );
   }
 
-  void refreshGameList() {
-    setState(() {
-      _gameListFuture = db.matchDao.getAllMatches();
+  void loadGames() {
+    Future.wait([
+      db.matchDao.getAllMatches(),
+      Future.delayed(minimumSkeletonDuration),
+    ]).then((results) {
+      final loadedMatches = results[0] as List<Match>;
+      matches = loadedMatches
+        ..sort((a, b) => b.createdAt.compareTo(a.createdAt));
+      setState(() {
+        isLoading = false;
+      });
     });
   }
 }

lib/presentation/widgets/player_selection.dart

@@ -30,6 +30,7 @@ class _PlayerSelectionState extends State<PlayerSelection> {
   List<Player> selectedPlayers = [];
   List<Player> suggestedPlayers = [];
   List<Player> allPlayers = [];
+  bool isLoading = true;
   late final TextEditingController _searchBarController =
       TextEditingController();
   late final AppDatabase db;
@@ -43,6 +44,7 @@ class _PlayerSelectionState extends State<PlayerSelection> {
   void initState() {
     super.initState();
     db = Provider.of<AppDatabase>(context, listen: false);
+    suggestedPlayers = skeletonData;
     loadPlayerList();
   }
 
@@ -51,7 +53,6 @@ class _PlayerSelectionState extends State<PlayerSelection> {
       db.playerDao.getAllPlayers(),
       Future.delayed(minimumSkeletonDuration),
     ]).then((results) => results[0] as List<Player>);
-    suggestedPlayers = skeletonData;
     _allPlayersFuture.then((loadedPlayers) {
       setState(() {
         // If a list of available players is provided, use that list.
@@ -77,6 +78,7 @@ class _PlayerSelectionState extends State<PlayerSelection> {
           suggestedPlayers = [...loadedPlayers];
         }
       });
+      isLoading = false;
     });
   }
 
@@ -163,75 +165,44 @@ class _PlayerSelectionState extends State<PlayerSelection> {
             style: TextStyle(fontSize: 16, fontWeight: FontWeight.bold),
           ),
           const SizedBox(height: 10),
-          FutureBuilder(
-            future: _allPlayersFuture,
-            builder:
-                (BuildContext context, AsyncSnapshot<List<Player>> snapshot) {
-                  if (snapshot.hasError) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.report,
-                        title: 'Error',
-                        message: 'Player data couldn\'t\nbe loaded.',
-                      ),
+          /*
+
+           */
+          Expanded(
+            child: AppSkeleton(
+              enabled: isLoading,
+              child: Visibility(
+                visible: suggestedPlayers.isNotEmpty,
+                replacement: TopCenteredMessage(
+                  icon: Icons.info,
+                  title: 'Info',
+                  message: allPlayers.isEmpty
+                      ? 'No players created yet.'
+                      : (selectedPlayers.length == allPlayers.length)
+                      ? 'No more players to add.'
+                      : 'No players found with that name.',
+                ),
+                child: ListView.builder(
+                  itemCount: suggestedPlayers.length,
+                  itemBuilder: (BuildContext context, int index) {
+                    return TextIconListTile(
+                      text: suggestedPlayers[index].name,
+                      onPressed: () {
+                        setState(() {
+                          if (!selectedPlayers.contains(
+                            suggestedPlayers[index],
+                          )) {
+                            selectedPlayers.add(suggestedPlayers[index]);
+                            widget.onChanged([...selectedPlayers]);
+                            suggestedPlayers.remove(suggestedPlayers[index]);
+                          }
+                        });
+                      },
                     );
-                  }
-                  bool doneLoading =
-                      snapshot.connectionState == ConnectionState.done;
-                  bool snapshotDataEmpty =
-                      !snapshot.hasData || snapshot.data!.isEmpty;
-                  if (doneLoading &&
-                      (snapshotDataEmpty && allPlayers.isEmpty)) {
-                    return const Center(
-                      child: TopCenteredMessage(
-                        icon: Icons.info,
-                        title: 'Info',
-                        message: 'No players created yet.',
-                      ),
-                    );
-                  }
-                  final bool isLoading =
-                      snapshot.connectionState == ConnectionState.waiting;
-                  return Expanded(
-                    child: AppSkeleton(
-                      enabled: isLoading,
-                      child: Visibility(
-                        visible:
-                            (suggestedPlayers.isEmpty && allPlayers.isNotEmpty),
-                        replacement: ListView.builder(
-                          itemCount: suggestedPlayers.length,
-                          itemBuilder: (BuildContext context, int index) {
-                            return TextIconListTile(
-                              text: suggestedPlayers[index].name,
-                              onPressed: () {
-                                setState(() {
-                                  if (!selectedPlayers.contains(
-                                    suggestedPlayers[index],
-                                  )) {
-                                    selectedPlayers.add(
-                                      suggestedPlayers[index],
-                                    );
-                                    widget.onChanged([...selectedPlayers]);
-                                    suggestedPlayers.remove(
-                                      suggestedPlayers[index],
-                                    );
-                                  }
-                                });
-                              },
-                            );
-                          },
-                        ),
-                        child: TopCenteredMessage(
-                          icon: Icons.info,
-                          title: 'Info',
-                          message: (selectedPlayers.length == allPlayers.length)
-                              ? 'No more players to add.'
-                              : 'No players found with that name.',
-                        ),
-                      ),
-                    ),
-                  );
-                },
+                  },
+                ),
+              ),
+            ),
           ),
         ],
       ),