liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Ausgewählte Spieler durch Gruppe werden nicht aussortiert #124

Merged
sneeex merged 4 commits from bug/113-ausgewählte-spieler-durch-gruppe-werden-nicht-aussortiert into development 2026-01-02 20:22:45 +00:00
Conversation 2 Commits 4 Files Changed 2 +29 -17
flixcoo commented 2026-01-01 22:17:53 +00:00
Owner
Copy Link

Ausgewählte Spieler durch Gruppe werden nicht aussortiert

Zugehörige Issue(s):
Closes #113

Beschreibung

Bug behoben, welcher enstanden ist, wenn die alle in der App verfügbaren Spieler Mitglieder in der Gruppe waren, welche in der CreateMatchView dem Match hinzugefügt waren

Änderungen

  • availablePlayers-Liste unterscheided jetzt zwischen leer ([] bzw. Gruppenmitglieder = Spieler in der Datenbank) und nicht übergeben (null)
  • Info-Text erweitert und in Funktion ausgelagert
# Ausgewählte Spieler durch Gruppe werden nicht aussortiert **Zugehörige Issue(s):** Closes #113 ## Beschreibung Bug behoben, welcher enstanden ist, wenn die alle in der App verfügbaren Spieler Mitglieder in der Gruppe waren, welche in der `CreateMatchView` dem Match hinzugefügt waren ## Änderungen - [x] `availablePlayers`-Liste unterscheided jetzt zwischen leer (`[]` bzw. Gruppenmitglieder = Spieler in der Datenbank) und nicht übergeben (`null`) - [x] Info-Text erweitert und in Funktion ausgelagert
flixcoo added this to the Minimum Viable Product (MVP) milestone 2026-01-01 22:17:53 +00:00
flixcoo added the
PR
Ready for Review
2
 label 2026-01-01 22:17:53 +00:00
flixcoo self-assigned this 2026-01-01 22:17:53 +00:00
flixcoo added 1 commit 2026-01-01 22:17:53 +00:00
Fixed bug in player selection
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m7s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
304fa82a93
flixcoo requested review from gelbeinhalb 2026-01-01 22:17:53 +00:00
flixcoo requested review from sneeex 2026-01-01 22:17:53 +00:00
sneeex requested changes 2026-01-02 17:28:03 +00:00
Dismissed
sneeex left a comment
Owner
Copy Link

Bug anscheinend nicht gefixxt:
Group ABC mit Player A, Player B und Player C erstellt, führt zu folgendem CreateMatch Screen:
grafik.png

Hier nochmal die Groups View:
grafik.png

In der CreateGroupView werden die Spieler angezeigt:
grafik.png

Bug anscheinend nicht gefixxt: Group ABC mit Player A, Player B und Player C erstellt, führt zu folgendem CreateMatch Screen: <img width="274" alt="grafik.png" src="attachments/512b14ae-e464-4651-b2b9-bfa390b44027"> Hier nochmal die Groups View: <img width="234" alt="grafik.png" src="attachments/d5974098-8ab8-4692-858d-00c575f3ff42"> In der CreateGroupView werden die Spieler angezeigt: <img width="266" alt="grafik.png" src="attachments/0e2cb685-cdb5-4e6b-a903-6a72e3414dc8">
grafik.png
103 KiB
grafik.png
14 KiB
grafik.png
92 KiB
👍 1
lib/presentation/widgets/player_selection.dart
@@ -276,0 +281,4 @@
return 'No players created yet';
} else if (selectedPlayers.length == allPlayers.length) {
// All players have been selected
return 'No more players to add';
sneeex commented 2026-01-02 17:19:16 +00:00
Owner
Copy Link

All players added to the match und no more players to add zusammenfassen

`All players added to the match` und `no more players to add` zusammenfassen
flixcoo marked this conversation as resolved
flixcoo added 2 commits 2026-01-02 17:41:44 +00:00
Fixed Problem with widget state cb7804cf55
Simplified info texts
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m8s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m8s
Details
87856e6548
flixcoo requested review from sneeex 2026-01-02 17:41:59 +00:00
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2026-01-02 17:42:04 +00:00
sneeex added 1 commit 2026-01-02 20:20:33 +00:00
correct spelling mistake
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m9s
Details
bdc3453d7f
sneeex approved these changes 2026-01-02 20:22:01 +00:00
sneeex scheduled this pull request to auto merge when all checks succeed 2026-01-02 20:22:44 +00:00
sneeex merged commit d081a597db into development 2026-01-02 20:22:45 +00:00
sneeex deleted branch bug/113-ausgewählte-spieler-durch-gruppe-werden-nicht-aussortiert 2026-01-02 20:22:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
sneeex
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#124
Delete Branch "bug/113-ausgewählte-spieler-durch-gruppe-werden-nicht-aussortiert"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?