liquid-development/game-tracker
3
1
Fork 0
Code Issues 8 Pull Requests 4 Actions Releases 1 Activity

Konstanten für Länge von Namen #170

Merged
sneeex merged 7 commits from enhancement/158-konstanten-für-länge-von-namen into development 2026-01-17 13:42:50 +00:00
Conversation 5 Commits 7 Files Changed 12 +46 -10
flixcoo commented 2026-01-16 20:56:03 +00:00
Owner
Copy Link

Zugehörige Issue(s)

Closes #158

Beschreibung

Es wurden Konstanten für die maximale Länge diverse Inputfelder implementiert.

Änderungen

  • Linterregel zum Filtern von Konstantennamen deaktiviert
  • MAX_PLAYER_NAME_LENGTH, MAX_GROUP_NAME_LENGTH, MAX_MATCH_NAME_LENGTH, MAX_GAME_NAME_LENGTH, MAX_TEAM_NAME_LENGTH implementiert
  • Längen-Konstanten in CreateGroupView, CreateMatchView und PlayerSelection implementiert

Zusätzliche Anmerkungen

Für Teamname und Gamename gibt es aktuell noch keine Views, deswegen wurden diese noch nicht verwendet

### Zugehörige Issue(s) Closes #158 ### Beschreibung Es wurden Konstanten für die maximale Länge diverse Inputfelder implementiert. ### Änderungen - Linterregel zum Filtern von Konstantennamen deaktiviert - `MAX_PLAYER_NAME_LENGTH`, `MAX_GROUP_NAME_LENGTH`, `MAX_MATCH_NAME_LENGTH`, `MAX_GAME_NAME_LENGTH`, `MAX_TEAM_NAME_LENGTH` implementiert - Längen-Konstanten in `CreateGroupView`, `CreateMatchView` und `PlayerSelection` implementiert ### Zusätzliche Anmerkungen Für Teamname und Gamename gibt es aktuell noch keine Views, deswegen wurden diese noch nicht verwendet
flixcoo added 3 commits 2026-01-16 20:56:03 +00:00
Added constants 1b709707b5
Adjusted constant name b7930d5e2e
Implemented constants
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m41s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m45s
Details
783f772da1
flixcoo requested review from Owners 2026-01-16 20:56:07 +00:00
flixcoo self-assigned this 2026-01-16 20:56:10 +00:00
flixcoo added this to the Alpha milestone 2026-01-16 20:56:12 +00:00
flixcoo added the
PR
Ready for Review
2
 label 2026-01-16 20:56:15 +00:00
sneeex requested changes 2026-01-17 09:35:47 +00:00
Dismissed
analysis_options.yaml
@@ -12,2 +12,3 @@
lines_longer_than_80_chars: false
lines_longer_than_80_chars: false
constant_identifier_names: false
sneeex commented 2026-01-17 09:30:31 +00:00
Owner
Copy Link

was ist constant identifier names?

was ist constant identifier names?
flixcoo commented 2026-01-17 13:30:56 +00:00
Author
Owner
Copy Link

Das deaktiviert, dass es eine Linter-Warnung gibt, wenn ich konstanten in SCREAMING_CAMEL_CASE schreibe, weil Flutter die normalerweise in lowerCamelCase will

Das deaktiviert, dass es eine Linter-Warnung gibt, wenn ich konstanten in `SCREAMING_CAMEL_CASE` schreibe, weil Flutter die normalerweise in `lowerCamelCase` will
sneeex marked this conversation as resolved
lib/core/constants.dart Outdated
@@ -7,0 +18,4 @@
static const int MAX_GAME_NAME_LENGTH = 256;
/// Maximum length for team names
static const int MAX_TEAM_NAME_LENGTH = 256;
sneeex commented 2026-01-17 09:32:24 +00:00
Owner
Copy Link

warum Match, Game, Team so lang?

warum Match, Game, Team so lang?
flixcoo commented 2026-01-17 13:31:10 +00:00
Author
Owner
Copy Link

ups, das war wohl copilto auto complete

ups, das war wohl copilto auto complete
sneeex commented 2026-01-17 13:32:29 +00:00
Owner
Copy Link

ups, das war wohl copilto auto complete

bro hat wieder kein finger gekrümmt

> ups, das war wohl copilto auto complete bro hat wieder kein finger gekrümmt
sneeex commented 2026-01-17 13:32:36 +00:00
Owner
Copy Link

und kontrollierts nicht mal

und kontrollierts nicht mal
sneeex marked this conversation as resolved
lib/presentation/widgets/text_input/text_input_field.dart Outdated
@@ -6,11 +6,13 @@ class TextInputField extends StatelessWidget {
/// - [controller]: The controller for the text input field.
/// - [onChanged]: The callback invoked when the text in the field changes.
/// - [hintText]: The hint text displayed in the text input field when it is empty
/// - [maxLength]: The maximum length of the input text.
sneeex commented 2026-01-17 09:35:37 +00:00
Owner
Copy Link

optional ergänzen? gleiche bei onchanged? bzw. onChanged kann ja auch required sein

optional ergänzen? gleiche bei onchanged? bzw. onChanged kann ja auch required sein
👍 1
sneeex marked this conversation as resolved
flixcoo added 2 commits 2026-01-17 13:33:30 +00:00
Changed length to 32 9f44f02a35
Edited comment
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m10s
Details
0e747710ab
flixcoo requested review from sneeex 2026-01-17 13:33:33 +00:00
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2026-01-17 13:33:37 +00:00
sneeex commented 2026-01-17 13:34:11 +00:00
Owner
Copy Link

ja und onchanged??
entweder required oder optional comment

ja und onchanged?? entweder required oder optional comment
sneeex requested changes 2026-01-17 13:35:20 +00:00
Dismissed
sneeex left a comment
Owner
Copy Link

comment

comment
flixcoo added 2 commits 2026-01-17 13:35:51 +00:00
Edited comment db41f40a52
Merge remote-tracking branch 'origin/enhancement/158-konstanten-für-länge-von-namen' into enhancement/158-konstanten-für-länge-von-namen
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m14s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m18s
Details
4fd8d2129b
sneeex approved these changes 2026-01-17 13:36:49 +00:00
Dismissed
flixcoo requested review from sneeex 2026-01-17 13:36:52 +00:00
sneeex scheduled this pull request to auto merge when all checks succeed 2026-01-17 13:36:55 +00:00
sneeex approved these changes 2026-01-17 13:42:48 +00:00
sneeex merged commit 2d1ac3a17c into development 2026-01-17 13:42:50 +00:00
sneeex deleted branch enhancement/158-konstanten-für-länge-von-namen 2026-01-17 13:42:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sneeex
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Hotfix
Task
Refactoring
Tasks that only involve refactoring and do not add any new functionality
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
actions flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#170
Delete Branch "enhancement/158-konstanten-für-länge-von-namen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?