liquid-development/game-tracker
3
1
Fork 0
Code Issues 9 Pull Requests 2 Actions Releases 1 Activity

Score implementation ergänzen #196

Merged
flixcoo merged 28 commits from feature/191-score-implementation-ergaenzen into development 2026-04-14 16:12:05 +00:00
Conversation 2 Commits 28 Files Changed 54 +3084 -2033
flixcoo commented 2026-04-08 20:21:26 +00:00
Owner
Copy Link

Zugehörige Issue(s)

Closes #191

Beschreibung

Es wurde die Implementation der Scores überarbeitet, so dass nun keine Redundanten Scores mehr gespeichert werden. Die Tests für die Scores wurden überarbeitet. Der DataTransferService wurde refactored und Tests für diesen hinzugefügt.

Änderungen

  • Ordner dto/ in models/ und ScoreDao in ScoreEntryDao umbenannt
  • ScoreEntry.dart Model Klasse hinzugefügt
  • Methoden hasWinner(), getWinner(), setWinner() und removeWinner() implementiert
  • Methoden hasLooser(), getLooser(), setLooser() und removeLooser() implementiert
  • Score-Spalte aus MatchTable entfernt
  • Score-Tests angepasst und erweitert
  • JSON-Schema angepasst
  • Test-JSON um Scores erweitern
  • Methode importData() in DataTransferService in kleinere Methoden refatored
  • Tests für DataTransferService hinzugefügt

Zusätzliche Anmerkungen

No response

### Zugehörige Issue(s) Closes #191 ### Beschreibung Es wurde die Implementation der Scores überarbeitet, so dass nun keine Redundanten Scores mehr gespeichert werden. Die Tests für die Scores wurden überarbeitet. Der DataTransferService wurde refactored und Tests für diesen hinzugefügt. ### Änderungen - [x] Ordner `dto/` in `models/` und `ScoreDao` in `ScoreEntryDao` umbenannt - [x] `ScoreEntry.dart` Model Klasse hinzugefügt - [x] Methoden `hasWinner()`, `getWinner()`, `setWinner()` und `removeWinner()` implementiert - [x] Methoden `hasLooser()`, `getLooser()`, `setLooser()` und `removeLooser()` implementiert - [x] Score-Spalte aus `MatchTable` entfernt - [x] Score-Tests angepasst und erweitert - [x] JSON-Schema angepasst - [x] [Test-JSON](https://discord.com/channels/921763177245605888/938410896299028570/1493349080662020209) um Scores erweitern - [x] Methode `importData()` in `DataTransferService` in kleinere Methoden refatored - [x] Tests für `DataTransferService` hinzugefügt ### Zusätzliche Anmerkungen _No response_
flixcoo self-assigned this 2026-04-08 20:21:26 +00:00
flixcoo added 4 commits 2026-04-08 20:21:26 +00:00
Removed score column 42f476919b
Added scores to match class 98c846ddc6
Added scores to match class b6fa71726e
Seperated score entry class
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 42s
Details
Pull Request Pipeline / lint (pull_request) Failing after 47s
Details
14d46d7e52
flixcoo added this to the Alpha milestone 2026-04-08 21:54:20 +00:00
flixcoo added 7 commits 2026-04-11 20:33:41 +00:00
Renamed folder to "models" ad6d08374e
Temp fixed all database functionality e10f05adb5
Moved dao methods 855b7c8bea
Moved dao methods 6a49b92310
Refactoring + fixed tests be58c9ce01
Renamed ScoreEntry to Score 73533b8c4f
Removed matchId from Score class
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 43s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
520edd0ca6
flixcoo added 2 commits 2026-04-11 22:07:22 +00:00
Updated score saving in match 26d60fc8b2
Overhauled score tests
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 40s
Details
Pull Request Pipeline / lint (pull_request) Successful in 45s
Details
541cbe9a54
flixcoo added 1 commit 2026-04-11 23:20:19 +00:00
Refactored method, added tests for DTS
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 44s
Details
Pull Request Pipeline / lint (pull_request) Successful in 45s
Details
22753d29c1
flixcoo added 1 commit 2026-04-11 23:21:22 +00:00
Corrected type
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 42s
Details
Pull Request Pipeline / lint (pull_request) Successful in 46s
Details
0823a4ed41
flixcoo added 1 commit 2026-04-11 23:32:25 +00:00
Added test for json schema
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 44s
Details
Pull Request Pipeline / lint (pull_request) Successful in 46s
Details
723699d363
flixcoo added 2 commits 2026-04-11 23:42:07 +00:00
Added restriction to schema f40113ef2c
Updated schema to add scores attribute
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
65704b4a03
flixcoo added 1 commit 2026-04-11 23:42:54 +00:00
Removed tester input
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 41s
Details
Pull Request Pipeline / lint (pull_request) Successful in 45s
Details
eeb68496d5
flixcoo added 4 commits 2026-04-12 00:02:55 +00:00
Refactoring 8a312152a5
Refactoring bed8a05057
Refactoring d903a9fd7e
Refactoring
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 41s
Details
Pull Request Pipeline / lint (pull_request) Successful in 48s
Details
80672343b9
flixcoo commented 2026-04-13 20:36:16 +00:00
Author
Owner
Copy Link

Testdaten Version 9 sind hier zu finden

Testdaten Version 9 sind [hier zu finden](https://discord.com/channels/921763177245605888/938410896299028570/1493349080662020209)
flixcoo added 3 commits 2026-04-13 20:47:36 +00:00
Refactoring fcca74cea5
Added edge cases for games, groups, teams and matches c9188c222a
Updated comments
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 44s
Details
Pull Request Pipeline / lint (pull_request) Successful in 46s
Details
c43b7b478c
flixcoo added 1 commit 2026-04-13 20:49:49 +00:00
Renamed score dao
Some checks failed
Pull Request Pipeline / lint (pull_request) Failing after 44s
Details
Pull Request Pipeline / test (pull_request) Failing after 1m33s
Details
73c85b1ff2
flixcoo added the
PR
Ready for Review
2
 label 2026-04-13 20:52:15 +00:00
flixcoo requested review from gelbeinhalb 2026-04-13 20:52:19 +00:00
flixcoo added 1 commit 2026-04-13 20:53:51 +00:00
Fixed references
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 42s
Details
Pull Request Pipeline / lint (pull_request) Successful in 47s
Details
e827f4c527
flixcoo changed title from WIP: Score implementation ergänzen to Score implementation ergänzen 2026-04-13 20:56:49 +00:00
gelbeinhalb approved these changes 2026-04-14 16:11:07 +00:00
gelbeinhalb left a comment
Owner
Copy Link

Sieht gut aus :)

Sieht gut aus :)
flixcoo merged commit 52b78e44e4 into development 2026-04-14 16:12:05 +00:00
flixcoo deleted branch feature/191-score-implementation-ergaenzen 2026-04-14 16:12:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Hotfix
Task
Refactoring
Tasks that only involve refactoring and do not add any new functionality
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Technical Debt
Issues related to code that needs to be refactored, cleaned up, or improved due to shortcuts or outdated implementations and to keep the codebase maintainable.
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
actions flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#196
Delete Branch "feature/191-score-implementation-ergaenzen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?