liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Navbar Position fix #21

Merged
sneeex merged 11 commits from enhancement/18-navbar-alignment into development 2025-11-22 17:06:04 +00:00
Conversation 12 Commits 11 Files Changed 2 +9 -7
gelbeinhalb commented 2025-11-14 16:33:29 +00:00
Owner
Copy Link

Navbar Position fix

Zugehörige Issue(s):
Closes #18

# Navbar Position fix **Zugehörige Issue(s):** Closes #18
gelbeinhalb added 1 commit 2025-11-14 16:33:30 +00:00
move navbar up 1536e2b2af
gelbeinhalb requested review from flixcoo 2025-11-14 16:33:30 +00:00
gelbeinhalb requested review from sneeex 2025-11-14 16:33:30 +00:00
gelbeinhalb added the
Layer
FE
PR
Ready for Review
2
Priority
Low
4
Task
Enhancement
 labels 2025-11-14 16:33:45 +00:00
gelbeinhalb was assigned by flixcoo 2025-11-14 21:01:37 +00:00
flixcoo commented 2025-11-15 14:38:40 +00:00
Owner
Copy Link

Ja passt, wir sollten aber in den nächsten Issues SafeArea()-Widgets über all einführen, die sollten das Verhindern

Ja passt, wir sollten aber in den nächsten Issues `SafeArea()`-Widgets über all einführen, die sollten das Verhindern
flixcoo approved these changes 2025-11-15 14:39:37 +00:00
Dismissed
sneeex commented 2025-11-15 15:24:27 +00:00
Owner
Copy Link

ich habe gerade im simulator gecheckt, da sieht eng aus, ich gucke aber später nochmal am handy direkt

ich habe gerade im simulator gecheckt, da sieht eng aus, ich gucke aber später nochmal am handy direkt
sneeex commented 2025-11-15 15:24:39 +00:00
Owner
Copy Link

also nicht mergen

also nicht mergen
sneeex added 1 commit 2025-11-15 16:11:59 +00:00
wrapped custom_navigation_bar in safearea 36aa4722a3
sneeex dismissed flixcoo's review 2025-11-15 16:11:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

sneeex approved these changes 2025-11-15 16:13:04 +00:00
Dismissed
flixcoo commented 2025-11-15 16:19:36 +00:00
Owner
Copy Link

NavBar ist vor der letzten GameTile

NavBar ist vor der letzten GameTile
Bildschirmaufnahme 2025-11-15 um 17.17.43.mov
650 KiB
gelbeinhalb commented 2025-11-15 19:08:37 +00:00
Author
Owner
Copy Link

NavBar ist vor der letzten GameTile

In erster Linie sieht die in dem clip viel zu weit unten aus :0

> NavBar ist vor der letzten GameTile In erster Linie sieht die in dem clip viel zu weit unten aus :0
sneeex commented 2025-11-15 19:10:13 +00:00
Owner
Copy Link

NavBar ist vor der letzten GameTile

ja muss halt in ne safe area die gametiles

> NavBar ist vor der letzten GameTile ja muss halt in ne safe area die gametiles
sneeex commented 2025-11-15 19:16:08 +00:00
Owner
Copy Link

NavBar ist vor der letzten GameTile

war das mit meinem neuen commit mit der safearea?

bei mir ist das i.O.
grafik.png

> NavBar ist vor der letzten GameTile war das mit meinem neuen commit mit der safearea? bei mir ist das i.O. ![grafik.png](/attachments/7b5c0ac9-3f2d-487d-bc25-1ac3c7b90e26)
grafik.png
26 KiB
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2025-11-16 17:34:21 +00:00
flixcoo commented 2025-11-16 17:36:04 +00:00
Owner
Copy Link

NavBar ist vor der letzten GameTile

war das mit meinem neuen commit mit der safearea?

bei mir ist das i.O.
grafik.png

Es geht um die GameHistoryView nicht um die HomeView

> > NavBar ist vor der letzten GameTile > > war das mit meinem neuen commit mit der safearea? > > bei mir ist das i.O. > ![grafik.png](/attachments/7b5c0ac9-3f2d-487d-bc25-1ac3c7b90e26) Es geht um die `GameHistoryView` nicht um die `HomeView`
sneeex changed title from Navbar Position fix to WIP: Navbar Position fix 2025-11-17 09:02:58 +00:00
sneeex removed the
PR
In Review
1
 label 2025-11-17 09:03:07 +00:00
flixcoo removed the
Layer
FE
Task
Enhancement
 labels 2025-11-17 12:27:10 +00:00
flixcoo added 1 commit 2025-11-20 09:50:18 +00:00
Merge branch 'development' into enhancement/18-navbar-alignment
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
ec9e34305a
sneeex was assigned by flixcoo 2025-11-22 13:10:50 +00:00
sneeex added 2 commits 2025-11-22 15:18:42 +00:00
Merge remote-tracking branch 'origin/development' into enhancement/18-navbar-alignment d809d80506
Adjust padding in CustomNavigationBar
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m10s
Details
63d9ed400d 
- Add vertical minimum padding to SafeArea
- Remove bottom padding in bottomNavigationBar
- replaced left/right padding in bottomNavigationBar with EdgeInsets.symmetric
- removed bottom padding from bottomNavigationBar
sneeex dismissed sneeex's review 2025-11-22 15:18:42 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

sneeex added 1 commit 2025-11-22 15:31:20 +00:00
fix black top/bottom bar when wrapping scaffold in safearea
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m10s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m19s
Details
b668f6b9ae
sneeex added 2 commits 2025-11-22 16:40:28 +00:00
wrap navbar in SafeArea and replaced Material with Container 28ed22ce73
Made bottom padding adaptive to screen
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m8s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m8s
Details
df3215ef76
sneeex added 2 commits 2025-11-22 16:58:39 +00:00
Adjust safeareas minimum padding for custom navigation bar 5062196463
made CustomWidthButton's position adaptive to bottom padding of safearea
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
fd13fe6e90
sneeex changed title from WIP: Navbar Position fix to Navbar Position fix 2025-11-22 16:59:03 +00:00
sneeex added the
PR
Ready for Review
2
 label 2025-11-22 16:59:12 +00:00
flixcoo requested review from flixcoo 2025-11-22 17:01:39 +00:00
flixcoo approved these changes 2025-11-22 17:02:59 +00:00
Dismissed
flixcoo left a comment
Owner
Copy Link

NavBar kriegt auf jeden Fall n Redesign, aber ist in Ordnung

NavBar kriegt auf jeden Fall n Redesign, aber ist in Ordnung
sneeex scheduled this pull request to auto merge when all checks succeed 2025-11-22 17:03:24 +00:00
sneeex added 1 commit 2025-11-22 17:03:50 +00:00
Merge branch 'development' into enhancement/18-navbar-alignment
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m12s
Details
c3deaa3974
sneeex dismissed flixcoo's review 2025-11-22 17:03:50 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo approved these changes 2025-11-22 17:04:18 +00:00
sneeex scheduled this pull request to auto merge when all checks succeed 2025-11-22 17:04:50 +00:00
sneeex merged commit e464ddb466 into development 2025-11-22 17:06:04 +00:00
sneeex deleted branch enhancement/18-navbar-alignment 2025-11-22 17:06:04 +00:00
gelbeinhalb added this to the Minimum Viable Product (MVP) milestone 2026-01-05 11:09:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Priority
Low
4
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees gelbeinhalb sneeex
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#21
Delete Branch "enhancement/18-navbar-alignment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?