liquid-development/game-tracker
3
1
Fork 0
Code Issues 7 Pull Requests 4 Actions Releases 1 Activity

Neuer Regelsatz: Platzierung #213

Merged
sneeex merged 22 commits from feature/206-Neuer-Regelsatz-Platzierung into development 2026-05-09 21:37:30 +00:00
Conversation 6 Commits 22 Files Changed 14 +309 -38
sneeex commented 2026-05-08 22:10:16 +00:00
Owner
Copy Link

Zugehörige Issue(s)

Closes #206

Beschreibung

Regelsatz Platzierung implementiert

Änderungen

  • TextIconTile überarbeitet um icon custom setzbar zu machen
  • Screen für Platzierungs drag/drop erstellt
  • aktualisieren von Winner/Platzierung im callback gefixxt

Zusätzliche Anmerkungen

No response

### Zugehörige Issue(s) Closes #206 ### Beschreibung Regelsatz Platzierung implementiert ### Änderungen - TextIconTile überarbeitet um icon custom setzbar zu machen - Screen für Platzierungs drag/drop erstellt - aktualisieren von Winner/Platzierung im callback gefixxt ### Zusätzliche Anmerkungen _No response_
sneeex added this to the Alpha milestone 2026-05-08 22:10:16 +00:00
sneeex self-assigned this 2026-05-08 22:10:16 +00:00
sneeex requested review from Owners 2026-05-08 22:10:17 +00:00
sneeex added 1 commit 2026-05-09 00:08:44 +00:00
feat: add placement ruleset and related localization
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 45s
Details
Pull Request Pipeline / lint (pull_request) Failing after 48s
Details
bc997633eb
sneeex added 1 commit 2026-05-09 09:50:53 +00:00
feat: update TextIconListTile to support custom icons
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Failing after 49s
Details
868460b023
sneeex added 1 commit 2026-05-09 09:51:16 +00:00
fix: update string interpolation and use const TextStyle for consistency
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
8b7a519e64
sneeex added 1 commit 2026-05-09 10:33:56 +00:00
remove scroll-physics from single winner & placement ruleset listview
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Failing after 50s
Details
6f155182b5
sneeex added 1 commit 2026-05-09 10:34:09 +00:00
add const
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
f0062dd9d9
sneeex added 1 commit 2026-05-09 10:57:46 +00:00
implement updateMatchStateAfterSave to refresh match scores
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 45s
Details
Pull Request Pipeline / lint (pull_request) Successful in 52s
Details
350c5430a4
sneeex added 1 commit 2026-05-09 11:01:45 +00:00
remove unecessessary prefix text
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 48s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
2fdcc3e8aa
sneeex added 1 commit 2026-05-09 11:02:45 +00:00
add translation for drag to set placement
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 50s
Details
5b668d28b7
sneeex added the
PR
Ready for Review
2
 label 2026-05-09 11:03:09 +00:00
sneeex changed title from WIP: Neuer Regelsatz: Platzierung to Neuer Regelsatz: Platzierung 2026-05-09 11:03:13 +00:00
flixcoo added a new dependency 2026-05-09 11:21:45 +00:00
#203 Implementierung der Games
flixcoo requested changes 2026-05-09 13:20:19 +00:00
Dismissed
lib/presentation/views/main_menu/match_view/match_detail_view.dart Outdated
@@ -206,3 +206,3 @@
onWinnerChanged: () {
widget.onMatchUpdate.call();
setState(() {});
updateMatchStateAfterSave();
flixcoo commented 2026-05-09 13:17:49 +00:00
Owner
Copy Link

Schau mal nach dem Pull von #207 ich glaub da ist schon ein fix dafür implementiert

Schau mal nach dem Pull von #207 ich glaub da ist schon ein fix dafür implementiert
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/match_view/match_detail_view.dart Outdated
@@ -290,3 +301,3 @@
/// Returns the result widget for scores
/// Returns the result widget for scores or placement
Widget getScoreResultWidget(AppLocalizations loc) {
flixcoo commented 2026-05-09 13:20:13 +00:00
Owner
Copy Link

Würde glaub ich hierfür Links in Orange Bold Font "1. (2., 3., ...) Platz" und Rechts dann den Namen des Spielers in White Normal Font

Würde glaub ich hierfür Links in Orange Bold Font "1. (2., 3., ...) Platz" und Rechts dann den Namen des Spielers in White Normal Font
sneeex commented 2026-05-09 15:17:07 +00:00
Author
Owner
Copy Link

ist aber irgendwie bisschen weird dann anders als die anderen oder?1 weil bisher ist ja alle infos immer rechts und links die spielernamen

ist aber irgendwie bisschen weird dann anders als die anderen oder?1 weil bisher ist ja alle infos immer rechts und links die spielernamen
flixcoo commented 2026-05-09 15:25:02 +00:00
Owner
Copy Link

Ja sonst ersetz mal erstmal die #<num> durch <num>. Platz

Ja sonst ersetz mal erstmal die `#<num>` durch `<num>. Platz`
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/match_view/match_result_view.dart Outdated
@@ -180,0 +198,4 @@
alignment: Alignment.center,
height: 60,
child: Container(
decoration:
flixcoo commented 2026-05-09 13:17:06 +00:00
Owner
Copy Link

Vielleicht andere box decoration, maybe keine border und kompletter container in der border color

Vielleicht andere box decoration, maybe keine border und kompletter container in der border color
sneeex commented 2026-05-09 15:22:00 +00:00
Author
Owner
Copy Link

tote nummer
grafik.png

tote nummer ![grafik.png](/attachments/a399a850-1b2f-4afe-8f74-e4c28f80941a)
grafik.png
13 KiB
flixcoo commented 2026-05-09 15:24:01 +00:00
Owner
Copy Link

ja fair, aber irgendwie würd ich die gern anders darstellen. Nicht genau so wie die list tiles. Und macht die mal quadratisch

ja fair, aber irgendwie würd ich die gern anders darstellen. Nicht genau so wie die list tiles. Und macht die mal quadratisch
sneeex commented 2026-05-09 15:24:48 +00:00
Author
Owner
Copy Link

so?
grafik.png

so? ![grafik.png](/attachments/41e1acb6-75c3-4487-86a6-fa77c0b1ff90)
grafik.png
20 KiB
flixcoo commented 2026-05-09 15:25:48 +00:00
Owner
Copy Link

Mach mal color: orange, fontcolor: weiß

Mach mal color: orange, fontcolor: weiß
sneeex commented 2026-05-09 15:49:49 +00:00
Author
Owner
Copy Link

meinst du so?
sonst probier selber mal rum, du weißt ja besser was du willst

grafik.png

meinst du so? sonst probier selber mal rum, du weißt ja besser was du willst ![grafik.png](/attachments/f4030533-907c-4c68-b5ff-f90cc676859e)
grafik.png
15 KiB
flixcoo marked this conversation as resolved
lib/presentation/views/main_menu/match_view/match_result_view.dart Outdated
@@ -180,0 +221,4 @@
physics: const NeverScrollableScrollPhysics(),
padding: EdgeInsets.zero,
proxyDecorator: (child, index, animation) {
return Material(
flixcoo commented 2026-05-09 13:15:28 +00:00
Owner
Copy Link

Gerne hier noch ein kleines Highlighting implementieren, wenn ein Tile gedraggt wird

Gerne hier noch ein kleines Highlighting implementieren, wenn ein Tile gedraggt wird
sneeex commented 2026-05-09 15:36:32 +00:00
Author
Owner
Copy Link

so nen highlighting?

so nen highlighting?
flixcoo commented 2026-05-09 15:38:59 +00:00
Owner
Copy Link

Das mag ich garnicht. Lieber was simples, z.B. BG color etwas heller, ne weiße border oder so

Das mag ich garnicht. Lieber was simples, z.B. BG color etwas heller, ne weiße border oder so
sneeex commented 2026-05-09 16:00:05 +00:00
Author
Owner
Copy Link

dann schau mal selber ich habe wirklich keine ahnung

dann schau mal selber ich habe wirklich keine ahnung
flixcoo marked this conversation as resolved
lib/presentation/views/main_menu/match_view/match_result_view.dart Outdated
@@ -270,0 +345,4 @@
/// Handles saving the placement for each player in the database.
Future<void> _handlePlacement() async {
for (int i = 0; i < allPlayers.length; i++) {
await db.scoreEntryDao.addScore(
flixcoo commented 2026-05-09 13:13:41 +00:00
Owner
Copy Link

Bitte neue Methode setPlacements(List<Player> player) bei der die Platzierung anhand des Index gesetzt wird.

Bitte neue Methode `setPlacements(List<Player> player)` bei der die Platzierung anhand des Index gesetzt wird.
sneeex commented 2026-05-09 15:29:02 +00:00
Author
Owner
Copy Link

du bist weird, warum soll ich das auslagern, die methode hat doch nur die einzige funktion mit handlePlacement hä

du bist weird, warum soll ich das auslagern, die methode hat doch nur die einzige funktion mit handlePlacement hä
flixcoo commented 2026-05-09 15:30:20 +00:00
Owner
Copy Link

Die Methode soll in die score_entry_dao.dart zu den anderen Methoden wie setWinner(), addScore() etc

Die Methode soll in die `score_entry_dao.dart ` zu den anderen Methoden wie `setWinner()`, `addScore()` etc
sneeex marked this conversation as resolved
flixcoo commented 2026-05-09 13:26:18 +00:00
Owner
Copy Link

Für die Testdaten erstell mal bitte ein Game mit Ruleset.placement und ein Match mit diesem Game, welches beendet ist.

Für die Testdaten erstell mal bitte ein `Game` mit `Ruleset.placement` und ein `Match` mit diesem `Game`, welches beendet ist.
flixcoo commented 2026-05-09 13:34:34 +00:00
Owner
Copy Link

Und in der MatchTile musst du bei getMvpText() noch einen Case für Ruleset.placement hinzufügen

Und in der `MatchTile` musst du bei `getMvpText()` noch einen Case für `Ruleset.placement` hinzufügen
👍 1
sneeex added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2026-05-09 15:12:25 +00:00
sneeex added 2 commits 2026-05-09 15:30:48 +00:00
remove matchStateUpdate bcs alr implement in another pr 2d2a83ea4c
change placement tile decoration
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 49s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
385bd39aa1
sneeex added 1 commit 2026-05-09 15:36:21 +00:00
implement dragging animation
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 50s
Details
9781a20b38
flixcoo added a new dependency 2026-05-09 15:46:57 +00:00
#207 Live-Edit Modus
sneeex added 1 commit 2026-05-09 15:47:26 +00:00
change placement to text in match detail view
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 50s
Details
616c239375
sneeex commented 2026-05-09 16:18:35 +00:00
Author
Owner
Copy Link

Für die Testdaten erstell mal bitte ein Game mit Ruleset.placement und ein Match mit diesem Game, welches beendet ist.

mach ich wenn games da ist

> Für die Testdaten erstell mal bitte ein `Game` mit `Ruleset.placement` und ein `Match` mit diesem `Game`, welches beendet ist. mach ich wenn games da ist
sneeex added 1 commit 2026-05-09 16:19:32 +00:00
implement setPlacement in Score Dao & add placement game type to match tile
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 48s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
79ce3efd0a
sneeex requested review from flixcoo 2026-05-09 16:19:47 +00:00
flixcoo added 2 commits 2026-05-09 16:41:08 +00:00
feat: updated drag effect 496d411af6
feat: updated placement num styling
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 50s
Details
1de0ef52ad
sneeex added 2 commits 2026-05-09 17:19:20 +00:00
Merge remote-tracking branch 'origin/development' into feature/206-Neuer-Regelsatz-Platzierung 759e168216 
# Conflicts:
#	lib/l10n/arb/app_de.arb
#	lib/l10n/arb/app_en.arb
#	lib/l10n/generated/app_localizations.dart
#	lib/l10n/generated/app_localizations_de.dart
#	lib/l10n/generated/app_localizations_en.dart
regenerate localization
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 48s
Details
Pull Request Pipeline / lint (pull_request) Failing after 51s
Details
3923e955fd
sneeex added 1 commit 2026-05-09 17:48:05 +00:00
add icon for placement ruleset
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 49s
Details
0eb27ab284
flixcoo added 1 commit 2026-05-09 17:54:30 +00:00
Updated icon and match tile icon style
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 48s
Details
Pull Request Pipeline / lint (pull_request) Successful in 50s
Details
518bbb407c
flixcoo added 1 commit 2026-05-09 18:32:46 +00:00
feat: placement text color
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 54s
Details
f0ff4fbfc0
flixcoo approved these changes 2026-05-09 18:40:45 +00:00
Dismissed
flixcoo added 1 commit 2026-05-09 21:16:23 +00:00
Merge branch 'development' into feature/206-Neuer-Regelsatz-Platzierung
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 48s
Details
28222cbd2a 
# Conflicts:
#	lib/l10n/generated/app_localizations.dart
#	lib/presentation/views/main_menu/match_view/match_detail_view.dart
#	lib/presentation/views/main_menu/match_view/match_result_view.dart
flixcoo dismissed flixcoo's review 2026-05-09 21:16:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo added 1 commit 2026-05-09 21:17:08 +00:00
localizations
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 44s
Details
Pull Request Pipeline / lint (pull_request) Successful in 47s
Details
df73fc87eb
flixcoo approved these changes 2026-05-09 21:17:34 +00:00
sneeex merged commit c225599aa3 into development 2026-05-09 21:37:30 +00:00
sneeex deleted branch feature/206-Neuer-Regelsatz-Platzierung 2026-05-09 21:37:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Proposal
This issue contains a proposal for a new feature, change, or improvement. It is open for discussion and feedback before any decision is made.
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Hotfix
Task
Refactoring
Tasks that only involve refactoring and do not add any new functionality
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Technical Debt
Issues related to code that needs to be refactored, cleaned up, or improved due to shortcuts or outdated implementations and to keep the codebase maintainable.
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
actions flixcoo gelbeinhalb sneeex
No Assignees sneeex
2 Participants
Notifications
Due Date
No due date set.
Depends on
#203 Implementierung der Games
liquid-development/game-tracker
#207 Live-Edit Modus
liquid-development/game-tracker
Reference: liquid-development/game-tracker#213
Delete Branch "feature/206-Neuer-Regelsatz-Platzierung"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?