liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Datenbankkorrekturen #25

Merged
flixcoo merged 7 commits from enhancement/24-datenbankkorrekturen into development 2025-11-16 20:57:40 +00:00
Conversation 2 Commits 7 Files Changed 4 +159 -105
flixcoo commented 2025-11-16 18:14:51 +00:00
Owner
Copy Link

Datenbankkorrekturen

Zugehörige Issue(s):
Closes #24

Beschreibung

Dieses PR implementiert kleine Datenbankkorrekturen für Rückggabewerte und ergänz tests für die getAll Methoden

Änderungen

  • Tests für getAllPlayers() und getAllGroups() ergänzt
  • Rückgabetypen für Funktionen Datenbankfunktionen angepasst

Zusätzliche Anmerkungen

Diese PR enthält auch die Commits aus #22

# Datenbankkorrekturen **Zugehörige Issue(s):** Closes #24 ## Beschreibung Dieses PR implementiert kleine Datenbankkorrekturen für Rückggabewerte und ergänz tests für die getAll Methoden ## Änderungen - [x] Tests für `getAllPlayers()` und `getAllGroups()` ergänzt - [x] Rückgabetypen für Funktionen Datenbankfunktionen angepasst ## Zusätzliche Anmerkungen Diese PR enthält auch die Commits aus #22
flixcoo added this to the Minimum Viable Product (MVP) milestone 2025-11-16 18:14:51 +00:00
flixcoo added the
PR
Ready for Review
2
 label 2025-11-16 18:14:51 +00:00
flixcoo self-assigned this 2025-11-16 18:14:51 +00:00
flixcoo requested review from gelbeinhalb 2025-11-16 18:14:51 +00:00
flixcoo requested review from sneeex 2025-11-16 18:14:51 +00:00
flixcoo changed title from enhancement/24-datenbankkorrekturen to Datenbankkorrekturen 2025-11-16 18:17:30 +00:00
flixcoo changed target branch from main to development 2025-11-16 19:55:30 +00:00
flixcoo added 24 commits 2025-11-16 19:55:30 +00:00
implemented basic layout & functionality for add group button & group tiles 2ee4d8e6fa
rearrange imports and fix wrong syntax in widget call 1081fb8be7
implemented groups view with create group button d08c79fc26
added skeleton loading d36348c59c
added skeletonizer package requirement 352fdc13f1
increased skeleton item count & added daos as import d07bc6e8bb
reduced mock data loading time 511124e323
added missing const's ac6f3d0f92
fixed black bar behind nav bar by removing safearea 7c34e51779
Merge remote-tracking branch 'origin/development' into feature/4-groupview-erstellen 2a7d409df0
ignored text for players in skeleton loading b475237b9e
added todo for getAllGroups tests 168d7748a9
fixed getAllGroups not returning members 640830d8ab
add sample groups with sample members at app startup 2dad822d79
removed sample groups from groups view 2dd4f52336
change colors to fit home page 3bd522df6e
added new color: onBoxColor a707990356
changed member tile color d931e85e9f
added missing const a6f40456d8
Added missing test 02735b5b1d
Added fallbacks for groups when same group already exists 5c09dfb47d
Added fallbacks for players when same player already exists 74402f2e04
Added getAllPlayers test e709edbf7a
Updates getAllGroups test d3de0fda49
sneeex requested changes 2025-11-16 20:43:44 +00:00
Dismissed
lib/main.dart Outdated
@@ -19,6 +21,7 @@ class GameTracker extends StatelessWidget {
@override
Widget build(BuildContext context) {
addSampleGroupData(context);
sneeex commented 2025-11-16 20:40:55 +00:00
Owner
Copy Link

musst dir die neue branch von mir reinmergen, sonst hast du ganz viele konflikte, unteranderem hier

musst dir die neue branch von mir reinmergen, sonst hast du ganz viele konflikte, unteranderem hier
flixcoo marked this conversation as resolved
lib/presentation/views/main_menu/game_history_view.dart Outdated
@@ -181,3 +181,2 @@
return TopCenteredMessage("Keine Spiele erstellt");
return TopCenteredMessage(message: "Keine Spiele erstellt");
} else if (suggestedGameData.isEmpty) {
return TopCenteredMessage("Kein Spiel mit den Suchparametern gefunden.");
sneeex commented 2025-11-16 20:42:01 +00:00
Owner
Copy Link

hier z.B. auch

hier z.B. auch
flixcoo marked this conversation as resolved
test/db_tests/group_test.dart Outdated
@@ -36,2 +36,4 @@
await database.close();
});
group('group tests', () {
test('all groups get fetched correclty', () async {
sneeex commented 2025-11-16 20:43:10 +00:00
Owner
Copy Link

correclty

correclty
flixcoo marked this conversation as resolved
test/db_tests/player_test.dart Outdated
@@ -24,6 +24,25 @@ void main() {
});
group('player tests', () {
test('all players get fetched correclty', () async {
sneeex commented 2025-11-16 20:42:50 +00:00
Owner
Copy Link

"correclty"

"correclty"
flixcoo marked this conversation as resolved
flixcoo added 2 commits 2025-11-16 20:53:27 +00:00
Merge branch 'development' into enhancement/24-datenbankkorrekturen f06f333a8e
typo 630836d40c
flixcoo requested review from sneeex 2025-11-16 20:54:32 +00:00
sneeex approved these changes 2025-11-16 20:57:10 +00:00
flixcoo merged commit 729cd5eff1 into development 2025-11-16 20:57:40 +00:00
flixcoo deleted branch enhancement/24-datenbankkorrekturen 2025-11-16 20:57:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
sneeex
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#25
Delete Branch "enhancement/24-datenbankkorrekturen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?