liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Spieler erstellen in CreateGroupView #43

Merged
flixcoo merged 9 commits from feature/42-spieler-erstellen-in-create-group-view-implementieren into development 2025-11-20 21:18:21 +00:00
Conversation 2 Commits 9 Files Changed 2 +141 -41
sneeex commented 2025-11-20 10:04:33 +00:00
Owner
Copy Link

Spieler erstellen in CreateGroupView

Zugehörige Issue(s):
Closes #42

Beschreibung

Neues Feature, was es ermöglicht Spieler in der CreateGroupAnsicht zu erstellen.

Änderungen

  • Spieler-Lade-Logik in separate loadPlayerList-Methode ausgelagert
  • Trailing-Button zur Suchleiste hinzugefügt, um neue Spieler direkt zu erstellen
  • Datenbank-Logik zum Speichern neuer Spieler mit sofortiger Listen-Aktualisierung implementiert
  • Erfolgs- und Fehler-SnackBars für direktes Benutzer-Feedback eingebaut
# Spieler erstellen in CreateGroupView **Zugehörige Issue(s):** Closes #42 ## Beschreibung Neues Feature, was es ermöglicht Spieler in der `CreateGroup`Ansicht zu erstellen. ## Änderungen - [x] Spieler-Lade-Logik in separate loadPlayerList-Methode ausgelagert - [x] Trailing-Button zur Suchleiste hinzugefügt, um neue Spieler direkt zu erstellen - [x] Datenbank-Logik zum Speichern neuer Spieler mit sofortiger Listen-Aktualisierung implementiert - [x] Erfolgs- und Fehler-SnackBars für direktes Benutzer-Feedback eingebaut
sneeex added this to the Minimum Viable Product (MVP) milestone 2025-11-20 10:04:33 +00:00
sneeex self-assigned this 2025-11-20 10:04:33 +00:00
sneeex added the
Priority
Medium
3
 label 2025-11-20 10:06:19 +00:00
sneeex changed title from WIP: Spieler erstellen in CreateGroupView ermöglicht to WIP: Spieler erstellen in CreateGroupView 2025-11-20 15:03:34 +00:00
sneeex added 2 commits 2025-11-20 15:53:48 +00:00
add trailing button functionality to CustomSearchBar fa0e9a5dfd
Enable player creation via search bar in CreateGroupView
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m0s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m5s
Details
bce4cdcb2d
sneeex requested review from flixcoo 2025-11-20 15:56:33 +00:00
sneeex requested review from gelbeinhalb 2025-11-20 15:56:33 +00:00
sneeex added the
PR
Ready for Review
2
 label 2025-11-20 15:56:54 +00:00
sneeex added 1 commit 2025-11-20 15:59:53 +00:00
added missing consts & mounted check
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m0s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m4s
Details
8ff3c01435
sneeex changed title from WIP: Spieler erstellen in CreateGroupView to Spieler erstellen in CreateGroupView 2025-11-20 16:00:14 +00:00
sneeex added 1 commit 2025-11-20 20:27:05 +00:00
Trim whitespace from group and player names in CreateGroupView
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m7s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
0111774308
flixcoo requested changes 2025-11-20 20:29:19 +00:00
Dismissed
lib/presentation/views/main_menu/create_group_view.dart Outdated
@@ -102,0 +107,4 @@
trailingButtonEnabled:
_searchBarController.text.isNotEmpty,
onTrailingButtonPressed: () async {
String playerName = _searchBarController.text;
flixcoo commented 2025-11-20 20:26:04 +00:00
Owner
Copy Link

Mit trim() alle Leerzeichen vorne und hinten wegmachen (ich glaube es ist trim)

Mit `trim()` alle Leerzeichen vorne und hinten wegmachen (ich glaube es ist trim)
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/create_group_view.dart Outdated
@@ -102,0 +108,4 @@
_searchBarController.text.isNotEmpty,
onTrailingButtonPressed: () async {
String playerName = _searchBarController.text.trim();
if (playerName.isEmpty) return;
flixcoo commented 2025-11-20 20:28:17 +00:00
Owner
Copy Link

Der Button ist doch nur aktiv, wenn _searchBarController.text.isNotEmpty, warum fragst du das dann nochmal ab?

Der Button ist doch nur aktiv, wenn `_searchBarController.text.isNotEmpty`, warum fragst du das dann nochmal ab?
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/create_group_view.dart Outdated
@@ -102,0 +113,4 @@
player: Player(name: playerName),
);
if (!context.mounted) return;
if (success) {
flixcoo commented 2025-11-20 20:26:33 +00:00
Owner
Copy Link

Snackbar Logik auslagern damit build nicht so lange ist (Vllt generell die komplette button logik in funktion auslagern)

Snackbar Logik auslagern damit build nicht so lange ist (Vllt generell die komplette button logik in funktion auslagern)
sneeex marked this conversation as resolved
lib/presentation/widgets/custom_search_bar.dart Outdated
@@ -25,6 +31,20 @@ class CustomSearchBar extends StatelessWidget {
onChanged: onChanged,
hintStyle: WidgetStateProperty.all(const TextStyle(fontSize: 16)),
leading: const Icon(Icons.search),
trailing: trailingButtonShown
flixcoo commented 2025-11-20 20:29:05 +00:00
Owner
Copy Link

Lieber mit Visibility() Widget lösen

Lieber mit `Visibility()` Widget lösen
sneeex marked this conversation as resolved
sneeex added 1 commit 2025-11-20 20:54:48 +00:00
felix mach jetzt
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m3s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m4s
Details
d16beed490
flixcoo added 4 commits 2025-11-20 21:18:00 +00:00
Added name parameters and function doc b67f321276
Added Visibility Widget 01fede2951
Fixed error adding player with empty name eb7b247cae
Added icon as parameter for custom search bar
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m5s
Details
195ebf569a
flixcoo approved these changes 2025-11-20 21:18:13 +00:00
flixcoo merged commit e364e15d0a into development 2025-11-20 21:18:21 +00:00
flixcoo deleted branch feature/42-spieler-erstellen-in-create-group-view-implementieren 2025-11-20 21:18:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Priority
Medium
3
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees sneeex
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#43
Delete Branch "feature/42-spieler-erstellen-in-create-group-view-implementieren"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?