HomeView Mock-Daten entfernen #51

Merged
sneeex merged 7 commits from enhancement/46-homeview-mockdaten-entfernen into development 2025-11-23 18:19:54 +00:00
Owner

HomeView Mock-Daten entfernen

Zugehörige Issue(s):
Closes #46

Beschreibung

Implementiert, dass echte Daten bei Recent Games im HomeView angezeigt werden.

Änderungen

  • FutureBuilder für RecentGames
  • Darstellung der Daten von den zwei letzten Spielen

Zusätzliche Anmerkungen

Bei Ruleset und Gametype Attribute bei recent games wurden erstmal die Mockdaten beibehalten, weil diese Attribute beim Game noch nicht existieren.

# HomeView Mock-Daten entfernen **Zugehörige Issue(s):** Closes #46 ## Beschreibung Implementiert, dass echte Daten bei Recent Games im HomeView angezeigt werden. ## Änderungen - [x] FutureBuilder für RecentGames - [x] Darstellung der Daten von den zwei letzten Spielen ## Zusätzliche Anmerkungen Bei Ruleset und Gametype Attribute bei recent games wurden erstmal die Mockdaten beibehalten, weil diese Attribute beim Game noch nicht existieren.
sneeex added this to the Minimum Viable Product (MVP) milestone 2025-11-22 22:58:19 +00:00
sneeex self-assigned this 2025-11-22 22:58:19 +00:00
sneeex added 1 commit 2025-11-22 22:58:19 +00:00
Implemented displaying real recent games in home view
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m13s
Pull Request Pipeline / lint (pull_request) Failing after 2m13s
f658a88849
sneeex added a new dependency 2025-11-22 22:58:28 +00:00
sneeex changed title from Echte recent games Daten in HomeView anzeigen to WIP: Echte recent games Daten in HomeView anzeigen 2025-11-22 22:58:40 +00:00
flixcoo changed title from WIP: Echte recent games Daten in HomeView anzeigen to WIP: HomeView Mock-Daten entfernen 2025-11-23 00:16:48 +00:00
sneeex added 2 commits 2025-11-23 13:56:59 +00:00
Refactor Recent Games tile in HomeView
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m7s
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
def37aa640
- Move FutureBuilder inside InfoTile content
- Replace hardcoded winner and game type strings with actual game data
- Limit displayed recent games to 2 items and handle cases with fewer games
- Update player text generation to show player count instead of names
- Remove TopCenteredMessage usage and replace with simple text for empty/error states
- Update skeleton data to use Player object for winner
sneeex added the
PR
Ready for Review
2
label 2025-11-23 13:58:58 +00:00
sneeex requested review from gelbeinhalb 2025-11-23 13:59:02 +00:00
sneeex requested review from flixcoo 2025-11-23 14:04:54 +00:00
sneeex changed title from WIP: HomeView Mock-Daten entfernen to HomeView Mock-Daten entfernen 2025-11-23 14:24:59 +00:00
flixcoo requested changes 2025-11-23 16:01:08 +00:00
Dismissed
@@ -132,0 +153,4 @@
child: Text('No recent games available.'),
);
}
final List<Game> games =
Owner

Fehler taucht auf, wenn man die App startet. Könnte an dieser Zeile liegen. Ggf. die Skeleton Daten in der gleichen Variable wie die reelen Daten speichern und dann überhscreiben, wenn diese geladen sind

grafik.png

Fehler taucht auf, wenn man die App startet. Könnte an dieser Zeile liegen. Ggf. die Skeleton Daten in der gleichen Variable wie die reelen Daten speichern und dann überhscreiben, wenn diese geladen sind ![grafik.png](/attachments/c5f0c078-7338-480e-9c90-457afca0237c)
285 KiB
sneeex marked this conversation as resolved
@@ -192,0 +262,4 @@
String _getPlayerText(Game game) {
if (game.group == null) {
final playerCount = game.players?.length ?? 0;
return '$playerCount Player(s)';
Owner

Eigentlich reicht "Players", es soll eigentlich keine Spieler mit einem Spieler geben

Eigentlich reicht "Players", es soll eigentlich keine Spieler mit einem Spieler geben
sneeex marked this conversation as resolved
flixcoo reviewed 2025-11-23 16:30:05 +00:00
@@ -132,0 +185,4 @@
ruleset: 'Ruleset',
players: _getPlayerText(games[1]),
winner: games[1].winner == null
? 'No winner set.'
Owner

Lieber sowas wie Game in Progress oder so

Lieber sowas wie `Game in Progress` oder so
sneeex marked this conversation as resolved
sneeex added 2 commits 2025-11-23 17:08:08 +00:00
Refactor FutureBuilder logic in HomeView to handle empty game lists and improve code formatting
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m11s
Pull Request Pipeline / lint (pull_request) Failing after 2m12s
2616f7c113
sneeex added 1 commit 2025-11-23 17:09:50 +00:00
fix linter errors
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m27s
Pull Request Pipeline / lint (pull_request) Successful in 2m31s
e4abf53f66
sneeex requested review from flixcoo 2025-11-23 17:10:21 +00:00
flixcoo approved these changes 2025-11-23 17:54:56 +00:00
Dismissed
sneeex added 1 commit 2025-11-23 18:04:41 +00:00
Merge remote-tracking branch 'origin/development' into enhancement/46-homeview-mockdaten-entfernen
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Pull Request Pipeline / lint (pull_request) Successful in 2m11s
22d95b0015
# Conflicts:
#	lib/presentation/views/main_menu/home_view.dart
sneeex dismissed flixcoo's review 2025-11-23 18:04:41 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo approved these changes 2025-11-23 18:04:50 +00:00
sneeex merged commit 692a3ef3a4 into development 2025-11-23 18:19:54 +00:00
sneeex deleted branch enhancement/46-homeview-mockdaten-entfernen 2025-11-23 18:19:55 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Depends on
#50 Winner soll Player-Objekt sein
liquid-development/game-tracker
Reference: liquid-development/game-tracker#51