liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Winner als Player-Objekte #52

Merged
sneeex merged 12 commits from feature/50-winner-soll-player-objekt-sein into development 2025-11-23 10:48:46 +00:00
Conversation 1 Commits 12 Files Changed 6 +386 -16
flixcoo commented 2025-11-22 23:19:29 +00:00
Owner
Copy Link

Winner als Player-Objekte

Zugehörige Issue(s):
Closes #50

Beschreibung

Das winner-Attribut der Games-Klasse ist nun ein Player-Objekt statt nur einer Player-ID

Änderungen

  • JSON-Schema angepasst
  • Game-Klasse: winner-Attribut angepasst, toJson() & fromJson() Methoden angepasst
  • Anpassungen in `GameDao´-Klasse vorgenommen
  • Kleinere Anpassungen für Zugriff auf winner-Attribut in StatisticsView

Zusätzliche Anmerkungen

Branch enthät schon die Änderungen aus #6 um die Veränderungen zu testen

# Winner als Player-Objekte **Zugehörige Issue(s):** Closes #50 ## Beschreibung Das `winner`-Attribut der `Games`-Klasse ist nun ein `Player`-Objekt statt nur einer Player-ID ## Änderungen - [x] JSON-Schema angepasst - [x] `Game`-Klasse: `winner`-Attribut angepasst, `toJson()` & `fromJson()` Methoden angepasst - [x] Anpassungen in `GameDao´-Klasse vorgenommen - [x] Kleinere Anpassungen für Zugriff auf `winner`-Attribut in `StatisticsView` ## Zusätzliche Anmerkungen Branch enthät schon die Änderungen aus #6 um die Veränderungen zu testen
flixcoo added the
PR
Ready for Review
2
 label 2025-11-22 23:19:29 +00:00
flixcoo self-assigned this 2025-11-22 23:19:29 +00:00
flixcoo added 10 commits 2025-11-22 23:19:29 +00:00
Implemented StatisticsWidget tile 310b9aa43b
Implemented first version of statistics view
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m5s
Details
b2036e4e68
Changed values attribute & maxBarWidth 59c041699d
Added new metric & changed layout builder of Skeletonizer e60961730f
changed skeletonizer transition duration back to normal fba35521cb
Docs, small changes
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m13s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m15s
Details
feb5fa0615
Altered game class fa841e328e
Updated methods in gameDao cfed05595c
Updated json schema 338f4294dc
Changed winner access in statistics view
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m10s
Details
82b344a145
flixcoo requested review from Owners 2025-11-22 23:19:29 +00:00
flixcoo added 1 commit 2025-11-22 23:22:57 +00:00
Adjust tests
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
4ff131770e
flixcoo changed title from WIP: feature/50-winner-soll-player-objekt-sein to feature/50-winner-soll-player-objekt-sein 2025-11-22 23:23:24 +00:00
flixcoo changed title from feature/50-winner-soll-player-objekt-sein to Winner als Player-Objekte 2025-11-22 23:35:49 +00:00
flixcoo added 1 commit 2025-11-22 23:36:17 +00:00
Merge branch 'development' into feature/50-winner-soll-player-objekt-sein
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m33s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m34s
Details
24babe06d2
sneeex approved these changes 2025-11-23 10:48:26 +00:00
sneeex merged commit de60c942ea into development 2025-11-23 10:48:46 +00:00
sneeex deleted branch feature/50-winner-soll-player-objekt-sein 2025-11-23 10:48:46 +00:00
gelbeinhalb added this to the Minimum Viable Product (MVP) milestone 2026-01-05 11:09:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sneeex
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#52
Delete Branch "feature/50-winner-soll-player-objekt-sein"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?