liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

GameResultView erstellen #62

Merged
flixcoo merged 31 commits from feature/48-game-result-view-erstellen into development 2025-12-06 14:06:29 +00:00
Conversation 11 Commits 31 Files Changed 5 +311 -118
sneeex commented 2025-11-23 19:44:03 +00:00
Owner
Copy Link

Game Result View erstellen

Zugehörige Issue(s):
Closes #48

Beschreibung

Es wurde ein GameResultView erstellt, der die Möglichkeit bietet einen Gewinner eines Games auszuwählen.

Änderungen

  • Radio mit Save Button zum auswählen von Winnern eines übergebenen Games implementiert
  • Wenn einer Winner bereits selected war, ist der Standardmäßig ausgewählt
  • Die vorherige Seite GameHistoryView wird neugeladen

Zusätzliche Anmerkungen

Ich habe jetzt noch nichts im GameCreateView angepasst, weil der ja noch aktuell in Progress ist, Felix hat aber ja verkackt und das mit in die DB Branch gemacht, die ja vorhin reingemergt wurde.

# Game Result View erstellen **Zugehörige Issue(s):** Closes #48 ## Beschreibung Es wurde ein GameResultView erstellt, der die Möglichkeit bietet einen Gewinner eines Games auszuwählen. ## Änderungen - Radio mit Save Button zum auswählen von Winnern eines übergebenen Games implementiert - Wenn einer Winner bereits selected war, ist der Standardmäßig ausgewählt - Die vorherige Seite `GameHistoryView` wird neugeladen ## Zusätzliche Anmerkungen Ich habe jetzt noch nichts im GameCreateView angepasst, weil der ja noch aktuell in Progress ist, Felix hat aber ja verkackt und das mit in die DB Branch gemacht, die ja vorhin reingemergt wurde.
sneeex added this to the Minimum Viable Product (MVP) milestone 2025-11-23 19:44:03 +00:00
sneeex self-assigned this 2025-11-23 19:44:03 +00:00
sneeex added 2 commits 2025-11-23 19:44:03 +00:00
create GameResultView with basic structure and styling 46d1c25bb5
made settingsbutton redirect to game result view
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m14s
Details
937f1e3ac8
sneeex changed title from Game Result View erstellen to WIP: Game Result View erstellen 2025-11-23 19:44:11 +00:00
flixcoo changed title from WIP: Game Result View erstellen to WIP: GameResultView erstellen 2025-11-25 08:10:57 +00:00
sneeex added a new dependency 2025-11-25 10:28:17 +00:00
#20 GameHistoryView anpassen
sneeex added 1 commit 2025-11-25 10:28:30 +00:00
Merge branch 'development' into feature/48-game-result-view-erstellen
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m9s
Details
b291673899
sneeex added a new dependency 2025-11-25 16:20:27 +00:00
#74 Fehlende Methoden für Games Datenbank inplementieren
sneeex added 5 commits 2025-11-25 16:23:22 +00:00
Implement basic logic and UI for selecting game winners in GameResultView 6dc74ca82e
Update GameResultView with dummy Game data in CustomNavigationBar 424a258df1
update GameResultView to accept and use a given Game instance bd616c510a
Implement CustomRadioListTile and update GameResultView to select a winner currently without saving to the db 07d81d687b
Merge remote-tracking branch 'origin/feature/48-game-result-view-erstellen' into feature/48-game-result-view-erstellen
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m18s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m23s
Details
649330f358
sneeex added 1 commit 2025-11-25 16:24:39 +00:00
add todo comment
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m14s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m17s
Details
00fd6880e9
sneeex added 1 commit 2025-11-25 16:29:27 +00:00
fix lint
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m0s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m9s
Details
d97871d15b
sneeex added 2 commits 2025-11-25 21:03:43 +00:00
add spacing between title and list and rename appbar title to game name 479e9a2575
add textoverflow behaviour
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m8s
Details
86ec4de5c0
sneeex added 1 commit 2025-11-25 22:22:07 +00:00
added missing consts
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m7s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
9ba3dd7909
sneeex requested review from Owners 2025-11-25 22:22:14 +00:00
sneeex added the
PR
Ready for Review
2
 label 2025-11-25 22:22:18 +00:00
sneeex changed title from WIP: GameResultView erstellen to GameResultView erstellen 2025-11-25 22:22:26 +00:00
sneeex changed title from GameResultView erstellen to WIP: GameResultView erstellen 2025-11-25 22:24:37 +00:00
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2025-11-26 11:42:03 +00:00
flixcoo changed title from WIP: GameResultView erstellen to GameResultView erstellen 2025-11-26 11:58:54 +00:00
flixcoo commented 2025-11-26 12:00:33 +00:00
Owner
Copy Link

Review macht noch keinen Sinn, ich warte auf die entsprechenden PRs

Review macht noch keinen Sinn, ich warte auf die entsprechenden PRs
flixcoo added
PR
Ready for Review
2
Workflow
On Hold
3
 and removed
PR
In Review
1
 labels 2025-11-26 12:00:44 +00:00
sneeex commented 2025-11-26 12:08:56 +00:00
Author
Owner
Copy Link

Review macht noch keinen Sinn, ich warte auf die entsprechenden PRs

Aber kannst dir doch das schon mal angucken, das wichtigste steht ja

> Review macht noch keinen Sinn, ich warte auf die entsprechenden PRs Aber kannst dir doch das schon mal angucken, das wichtigste steht ja
flixcoo commented 2025-11-26 12:19:25 +00:00
Owner
Copy Link

Aber kannst dir doch das schon mal angucken, das wichtigste steht ja

ja hab ich, sieht gut soweit aus

> Aber kannst dir doch das schon mal angucken, das wichtigste steht ja ja hab ich, sieht gut soweit aus
flixcoo added a new dependency 2025-12-02 15:41:23 +00:00
#78 Game zu Match umbenennen
sneeex added 1 commit 2025-12-02 19:48:37 +00:00
Merge branch 'development' into feature/48-game-result-view-erstellen
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m9s
Details
09b407eba8
sneeex added 1 commit 2025-12-05 17:55:04 +00:00
Merge branch 'development' into feature/48-game-result-view-erstellen
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
dd2024e96e
sneeex added 7 commits 2025-12-05 18:41:08 +00:00
removed settings icon leading to game result view e77896c1d4
added ontap feature & argument 9ac6b6e04c
made tapping on game tile redirect to GameResultView f7f97fcdcb
re-set gameListFuture to reload the games after changing the winner 8f2c7493d0
add db functionality d8551b3a27
added const dba448b9c1
remove todo
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m9s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m11s
Details
e3ac91bf48
sneeex removed the
Workflow
On Hold
3
 label 2025-12-05 18:43:35 +00:00
sneeex added 1 commit 2025-12-05 18:44:41 +00:00
remove print
All checks were successful
Pull Request Pipeline / lint (pull_request) Successful in 2m12s
Details
Pull Request Pipeline / test (pull_request) Successful in 2m14s
Details
f5842f9c4a
sneeex added 1 commit 2025-12-05 19:33:32 +00:00
add delay and change empty games message
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m11s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m11s
Details
7323f52153
flixcoo requested changes 2025-12-05 23:37:44 +00:00
Dismissed
lib/presentation/views/main_menu/game_history_view.dart
@@ -109,0 +105,4 @@
onTap: () async {
await Navigator.push(
context,
MaterialPageRoute(
flixcoo commented 2025-12-05 23:28:36 +00:00
Owner
Copy Link

ich fände hier noch `fullscreenDialog: true' cool, ich finde das passt besser zur Navigation, also:

onTap: () async {
  await Navigator.push(
    context,
    MaterialPageRoute(
      fullscreenDialog: true,
      builder: (context) =>
          GameResultView(game: games[index]),
    ),
  );
  setState(() {
    _gameListFuture = db.gameDao.getAllGames();
  });
}
ich fände hier noch `fullscreenDialog: true' cool, ich finde das passt besser zur Navigation, also: ```dart onTap: () async { await Navigator.push( context, MaterialPageRoute( fullscreenDialog: true, builder: (context) => GameResultView(game: games[index]), ), ); setState(() { _gameListFuture = db.gameDao.getAllGames(); }); } ```
sneeex commented 2025-12-06 08:59:01 +00:00
Author
Owner
Copy Link

aber finde die animation dann komisch, das fadet so ein und sehe da jetzt keinen großen unterschied, also warum fullscreendialog und nicht das normale?

aber finde die animation dann komisch, das fadet so ein und sehe da jetzt keinen großen unterschied, also warum fullscreendialog und nicht das normale?
flixcoo commented 2025-12-06 11:27:36 +00:00
Owner
Copy Link

Korrektur:

 onTap: () async {
  await Navigator.push(
    context,
    CupertinoPageRoute(
      fullscreenDialog: true,
      builder: (context) =>
          GameResultView(game: games[index]),
    ),
  );
  setState(() {
    _gameListFuture = db.gameDao.getAllGames();
  });
}
Korrektur: ```dart onTap: () async { await Navigator.push( context, CupertinoPageRoute( fullscreenDialog: true, builder: (context) => GameResultView(game: games[index]), ), ); setState(() { _gameListFuture = db.gameDao.getAllGames(); }); } ```
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/game_result_view.dart Outdated
@@ -0,0 +20,4 @@
class _GameResultViewState extends State<GameResultView> {
late final List<Player> allPlayers;
late final AppDatabase db;
Player? _player;
flixcoo commented 2025-12-05 23:30:36 +00:00
Owner
Copy Link

Umbenennen in selectedPlayer oder currentWinner o.Ä.

Umbenennen in `selectedPlayer` oder `currentWinner` o.Ä.
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/game_result_view.dart Outdated
@@ -0,0 +78,4 @@
fontWeight: FontWeight.bold,
),
),
const SizedBox(height: 2),
flixcoo commented 2025-12-05 23:31:34 +00:00
Owner
Copy Link

Würde height mindestens auf 10 erhöhen

Würde `height` mindestens auf 10 erhöhen
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/game_result_view.dart Outdated
@@ -0,0 +81,4 @@
const SizedBox(height: 2),
Visibility(
visible: allPlayers.isNotEmpty,
replacement: const TopCenteredMessage(
flixcoo commented 2025-12-05 23:32:19 +00:00
Owner
Copy Link

Macht das Sinn überhaupt zu implementieren? Gibt es Fälle in denen ein Spiel keine Spieler hat?

Macht das Sinn überhaupt zu implementieren? Gibt es Fälle in denen ein Spiel keine Spieler hat?
sneeex commented 2025-12-06 08:34:52 +00:00
Author
Owner
Copy Link

Eigentlich nicht, soll ich's weglassen dann?

Eigentlich nicht, soll ich's weglassen dann?
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/game_result_view.dart Outdated
@@ -0,0 +153,4 @@
List<Player> getAllPlayers(Game game) {
if (game.group == null && game.players != null) {
return [...game.players!];
flixcoo commented 2025-12-05 23:35:14 +00:00
Owner
Copy Link

Warum wird an dieser Stelle und in Zeile 160 der Spread-Operator gebraucht?

Warum wird an dieser Stelle und in Zeile 160 der Spread-Operator gebraucht?
sneeex commented 2025-12-06 08:33:12 +00:00
Author
Owner
Copy Link

Gebraucht nicht zwingend, aber ich will lieber eine Kopie als die Referenz zu der ursprünglichen Liste übergeben, damit diese nicht im Widget im Umlauf ist

Gebraucht nicht zwingend, aber ich will lieber eine Kopie als die Referenz zu der ursprünglichen Liste übergeben, damit diese nicht im Widget im Umlauf ist
sneeex commented 2025-12-06 08:33:24 +00:00
Author
Owner
Copy Link

Damit die auf jeden Fall gleich bleibt

Damit die auf jeden Fall gleich bleibt
flixcoo commented 2025-12-06 11:29:30 +00:00
Owner
Copy Link

Okay safe, das hatte ich nicht auf dem schirm

Okay safe, das hatte ich nicht auf dem schirm
flixcoo marked this conversation as resolved
lib/presentation/widgets/tiles/custom_radio_list_tile.dart
@@ -0,0 +6,4 @@
final T value;
final ValueChanged<T> onContainerTap;
const CustomRadioListTile({
flixcoo commented 2025-12-05 23:36:36 +00:00
Owner
Copy Link

Würde Umbennenen in RadioListTile, weil das gibt es bisher noch nicht, oder? Würde Custom[Widget] immer nur verwenden, wenn es [Widget] bereits gibt (z.B. SearchBar)

Würde Umbennenen in `RadioListTile`, weil das gibt es bisher noch nicht, oder? Würde `Custom[Widget]` immer nur verwenden, wenn es [Widget] bereits gibt (z.B. `SearchBar`)
sneeex commented 2025-12-06 08:34:05 +00:00
Author
Owner
Copy Link

Ja fair aber dann Guck vielleicht mal was es gibt und was nicht xD https://api.flutter.dev/flutter/material/RadioListTile-class.html

Ja fair aber dann Guck vielleicht mal was es gibt und was nicht xD https://api.flutter.dev/flutter/material/RadioListTile-class.html
sneeex marked this conversation as resolved
flixcoo requested review from gelbeinhalb 2025-12-05 23:37:55 +00:00
sneeex added 1 commit 2025-12-06 09:01:05 +00:00
refactor game result view variable naming and layout
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m12s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m12s
Details
03035138ac
gelbeinhalb commented 2025-12-06 09:27:43 +00:00
Owner
Copy Link

wäre es nicht entspannter, wenn man nicht auf den save button drücken müsste um zu speichern?
Also dass die buttons im menü das sofort in die db speichern?

wäre es nicht entspannter, wenn man nicht auf den save button drücken müsste um zu speichern? Also dass die buttons im menü das sofort in die db speichern?
image.png
49 KiB
image.png
👍 1
gelbeinhalb requested changes 2025-12-06 09:55:55 +00:00
Dismissed
lib/presentation/views/main_menu/game_history_view.dart Outdated
@@ -84,2 +80,2 @@
title: 'Error',
message: 'No Games Available',
title: 'Info',
message: 'No games created yet.',
gelbeinhalb commented 2025-12-06 09:54:28 +00:00
Owner
Copy Link

Ich finde wir sollten für solche generischen Statusmeldungen nicht komplette Sätze mit Punkt machen oder?
Finde No games created yet passt da besser rein als die Version mit Punkt am Ende

Ich finde wir sollten für solche generischen Statusmeldungen nicht komplette Sätze mit Punkt machen oder? Finde `No games created yet` passt da besser rein als die Version mit Punkt am Ende
sneeex marked this conversation as resolved
lib/presentation/views/main_menu/game_result_view.dart Outdated
@@ -0,0 +126,4 @@
backgroundColor: CustomTheme.boxColor,
content: const Center(
child: Text(
'Error while setting winner, please try again',
gelbeinhalb commented 2025-12-06 09:55:33 +00:00
Owner
Copy Link

Hier ist auch kein Punkt :)
Würde ich aber auch so lassen höhö

Hier ist auch kein Punkt :) Würde ich aber auch so lassen höhö
sneeex marked this conversation as resolved
sneeex added 1 commit 2025-12-06 10:22:39 +00:00
removed dots after TopCenteredMessage text
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m17s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m20s
Details
306a783d67
flixcoo commented 2025-12-06 11:33:02 +00:00
Owner
Copy Link

Deselection mit einbauen

Deselection mit einbauen
👍 1
flixcoo commented 2025-12-06 11:33:52 +00:00
Owner
Copy Link

Save Button wegmachen und direkte selection zum Speichern in der Datenbank nutzen

Save Button wegmachen und direkte selection zum Speichern in der Datenbank nutzen
👍 1
sneeex added 1 commit 2025-12-06 12:31:13 +00:00
made winner deselectable and added auto save on select
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m8s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m11s
Details
697767f0de
sneeex added 1 commit 2025-12-06 12:34:16 +00:00
changed MaterialPageRoute to CupertinoPageRoute for ios animation
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m21s
Details
b1bb8b919f
gelbeinhalb approved these changes 2025-12-06 12:35:32 +00:00
Dismissed
gelbeinhalb left a comment
Owner
Copy Link

lgtm

lgtm
sneeex added 2 commits 2025-12-06 13:20:42 +00:00
madio radio list tile toggleable 91a7273964
Refactor winner selection and persistence logic in GameResultView
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m25s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m25s
Details
1ed6290628
sneeex dismissed gelbeinhalb's review 2025-12-06 13:20:42 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

sneeex added 1 commit 2025-12-06 13:21:21 +00:00
add braces to if/else statement in game_result_view.dart
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m18s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m20s
Details
dbbe04d4cc
sneeex requested review from flixcoo 2025-12-06 13:21:36 +00:00
sneeex requested review from gelbeinhalb 2025-12-06 13:21:42 +00:00
flixcoo commented 2025-12-06 14:06:19 +00:00
Owner
Copy Link

ja perfekt, so passt das doch

ja perfekt, so passt das doch
flixcoo approved these changes 2025-12-06 14:06:25 +00:00
flixcoo merged commit dcd8b460c1 into development 2025-12-06 14:06:29 +00:00
flixcoo deleted branch feature/48-game-result-view-erstellen 2025-12-06 14:06:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees sneeex
3 Participants
Notifications
Due Date
No due date set.
Blocks
#78 Game zu Match umbenennen
liquid-development/game-tracker
Depends on
#20 GameHistoryView anpassen
liquid-development/game-tracker
#74 Fehlende Methoden für Games Datenbank inplementieren
liquid-development/game-tracker
Reference: liquid-development/game-tracker#62
Delete Branch "feature/48-game-result-view-erstellen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?