liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

PlayerSelection Widget implementiert #72

Merged
sneeex merged 15 commits from feature/65-spieler-suche-in-eigenes-widget-umwandeln into development 2025-11-24 21:10:55 +00:00
Conversation 2 Commits 15 Files Changed 2 +269 -264
sneeex commented 2025-11-24 20:19:48 +00:00
Owner
Copy Link

PlayerSelection Widget implementiert

Zugehörige Issue(s):
Closes #65

Beschreibung

Das PlayerSelection Widget was vorher Teil vom CreateGameView war, wurde in ein wiederverwendbares Widget umgewandelt.

Änderungen

  • PlayerSelection Widget implementiert
# PlayerSelection Widget implementiert **Zugehörige Issue(s):** Closes #65 ## Beschreibung Das PlayerSelection Widget was vorher Teil vom CreateGameView war, wurde in ein wiederverwendbares Widget umgewandelt. ## Änderungen - [x] PlayerSelection Widget implementiert
sneeex added this to the Minimum Viable Product (MVP) milestone 2025-11-24 20:19:48 +00:00
sneeex added the
PR
Ready for Review
2
 label 2025-11-24 20:19:48 +00:00
sneeex self-assigned this 2025-11-24 20:19:48 +00:00
sneeex added 6 commits 2025-11-24 20:19:49 +00:00
put player selection from creategroupview into own widget 744a402602
Refactor CreateGroupView to use SelectPlayerWidget 6c9b742bdf
Made selectedPlayers local to SelectPlayerWidget because its not needed in CreateGroupView f1bd9c18e0
rename to PlayerSelection 6a77028171
refactor for new name and remove hide in material import 686463720a
remove print
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m0s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m4s
Details
54b54796e8
sneeex requested review from Owners 2025-11-24 20:19:49 +00:00
sneeex added 1 commit 2025-11-24 20:24:55 +00:00
remove uneccessary groupNameController
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m0s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m17s
Details
442e1d64a3
sneeex added 1 commit 2025-11-24 20:27:00 +00:00
rename searchBarController to controller in PlayerSelection widget
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m2s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
a2522cef13
sneeex added 2 commits 2025-11-24 20:33:33 +00:00
Remove unused _searchBarController from CreateGroupView fc9779153d
initialize _searchBarController internally instead of using widget controller
Some checks failed
Pull Request Pipeline / lint (pull_request) Failing after 2m24s
Details
Pull Request Pipeline / test (pull_request) Successful in 2m24s
Details
ebb531d825
sneeex added 1 commit 2025-11-24 20:33:59 +00:00
Remove unused TextEditingController from PlayerSelection widget
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m13s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m18s
Details
f8c0dbba5a
sneeex added 1 commit 2025-11-24 20:44:45 +00:00
Translate player selection UI text to English
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m1s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m2s
Details
7be80e6f91
sneeex added 1 commit 2025-11-24 20:57:02 +00:00
Added comments to explain player filtering and selection logic in PlayerSelection widget
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m1s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m4s
Details
0653700f9c
flixcoo approved these changes 2025-11-24 20:57:45 +00:00
Dismissed
sneeex added 2 commits 2025-11-24 21:08:46 +00:00
Merge remote-tracking branch 'origin/development' into feature/65-spieler-suche-in-eigenes-widget-umwandeln 2b9f038b0d 
# Conflicts:
#	lib/presentation/views/main_menu/create_group_view.dart
Refactor PlayerSelection to use AppSkeleton widget
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m2s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
51e3c04e72
sneeex dismissed flixcoo's review 2025-11-24 21:08:46 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo approved these changes 2025-11-24 21:09:03 +00:00
sneeex scheduled this pull request to auto merge when all checks succeed 2025-11-24 21:10:45 +00:00
sneeex merged commit 4c3b2152eb into development 2025-11-24 21:10:55 +00:00
sneeex deleted branch feature/65-spieler-suche-in-eigenes-widget-umwandeln 2025-11-24 21:10:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees sneeex
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#72
Delete Branch "feature/65-spieler-suche-in-eigenes-widget-umwandeln"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?