MVP-Refactoring #139

Merged
flixcoo merged 20 commits from refactoring/68-mvp-refactoring into development 2026-01-08 20:24:01 +00:00
7 changed files with 9 additions and 50 deletions
Showing only changes of commit 02d79574dd - Show all commits

View File

@@ -25,10 +25,13 @@ class CustomTheme {
backgroundColor: backgroundColor,
foregroundColor: Colors.white,
elevation: 0,
scrolledUnderElevation: 0,
centerTitle: true,
titleTextStyle: const TextStyle(
color: Colors.white,
fontSize: 20,
fontWeight: FontWeight.bold,
overflow: TextOverflow.ellipsis,
),
iconTheme: const IconThemeData(color: Colors.white),
);

View File

@@ -46,15 +46,7 @@ class _CreateGroupViewState extends State<CreateGroupView> {
final loc = AppLocalizations.of(context);
return Scaffold(
backgroundColor: CustomTheme.backgroundColor,
appBar: AppBar(
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
title: Text(
loc.create_new_group,
style: const TextStyle(fontSize: 20, fontWeight: FontWeight.bold),
),
centerTitle: true,
),
appBar: AppBar(title: Text(loc.create_new_group)),
sneeex marked this conversation as resolved
Review

schatz irgendwas passt hier nicht:
grafik.png

warum hast du alles weggelassen außer den title??? das ganze design ist anders jetzt und kacke auch

schatz irgendwas passt hier nicht: ![grafik.png](/attachments/2e570ad8-7b7b-4551-bb0c-576a4704f5f2) warum hast du alles weggelassen außer den title??? das ganze design ist anders jetzt und kacke auch
body: SafeArea(
child: Column(
mainAxisAlignment: MainAxisAlignment.start,

View File

@@ -38,19 +38,13 @@ class _ChooseGameViewState extends State<ChooseGameView> {
return Scaffold(
backgroundColor: CustomTheme.backgroundColor,
appBar: AppBar(
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
leading: IconButton(
flixcoo marked this conversation as resolved
Review

auch hier mit dem design weird alles aufeinmal anders wie sonst
grafik.png

auch hier mit dem design weird alles aufeinmal anders wie sonst ![grafik.png](/attachments/93727713-90f7-42d7-ae20-1444d8709b44)
icon: const Icon(Icons.arrow_back_ios),
onPressed: () {
Navigator.of(context).pop(selectedGameIndex);
},
),
title: Text(
loc.choose_game,
style: const TextStyle(fontSize: 20, fontWeight: FontWeight.bold),
),
centerTitle: true,
title: Text(loc.choose_game),
),
body: PopScope(
// This fixes that the Android Back Gesture didn't return the

View File

@@ -38,8 +38,6 @@ class _ChooseGroupViewState extends State<ChooseGroupView> {
return Scaffold(
backgroundColor: CustomTheme.backgroundColor,
appBar: AppBar(
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
leading: IconButton(
icon: const Icon(Icons.arrow_back_ios),
onPressed: () {
@@ -52,11 +50,7 @@ class _ChooseGroupViewState extends State<ChooseGroupView> {
);
},
),
title: Text(
loc.choose_group,
style: const TextStyle(fontSize: 20, fontWeight: FontWeight.bold),
),
centerTitle: true,
title: Text(loc.choose_group),
),
flixcoo marked this conversation as resolved
Review

grafik.png

![grafik.png](/attachments/a9c6941a-0805-49e8-8585-7c0a56c3ce4d)
body: PopScope(
// This fixes that the Android Back Gesture didn't return the

View File

@@ -37,8 +37,6 @@ class _ChooseRulesetViewState extends State<ChooseRulesetView> {
child: Scaffold(
backgroundColor: CustomTheme.backgroundColor,
appBar: AppBar(
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
leading: IconButton(
icon: const Icon(Icons.arrow_back_ios),
onPressed: () {
flixcoo marked this conversation as resolved
Review

grafik.png

![grafik.png](/attachments/357e0556-4575-4f60-b812-dc7b582bf8b6)
@@ -49,11 +47,7 @@ class _ChooseRulesetViewState extends State<ChooseRulesetView> {
);
},
),
title: Text(
loc.choose_ruleset,
style: const TextStyle(fontSize: 20, fontWeight: FontWeight.bold),
),
centerTitle: true,
title: Text(loc.choose_ruleset),
),
body: PopScope(
// This fixes that the Android Back Gesture didn't return the

View File

@@ -121,15 +121,7 @@ class _CreateMatchViewState extends State<CreateMatchView> {
final loc = AppLocalizations.of(context);
return Scaffold(
backgroundColor: CustomTheme.backgroundColor,
appBar: AppBar(
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
title: Text(
loc.create_new_match,
style: const TextStyle(fontSize: 20, fontWeight: FontWeight.bold),
),
centerTitle: true,
),
appBar: AppBar(title: Text(loc.create_new_match)),
body: SafeArea(
child: Column(
mainAxisAlignment: MainAxisAlignment.start,

View File

@@ -51,17 +51,7 @@ class _MatchResultViewState extends State<MatchResultView> {
Navigator.of(context).pop();
},
),
backgroundColor: CustomTheme.backgroundColor,
scrolledUnderElevation: 0,
title: Text(
widget.match.name,
style: const TextStyle(
fontSize: 20,
fontWeight: FontWeight.bold,
overflow: TextOverflow.ellipsis,
),
),
centerTitle: true,
title: Text(widget.match.name),
),
flixcoo marked this conversation as resolved
Review

grafik.png

![grafik.png](/attachments/06706384-fe63-4ea8-8886-07737018c7f5)
body: SafeArea(
child: Column(