liquid-development/game-tracker
3
1
Fork 0
Code Issues 9 Pull Requests 3 Actions Releases 1 Activity

Bearbeiten und Löschen von Gruppen #148

Merged
sneeex merged 20 commits from feature/118-bearbeiten-und-löschen-von-gruppen into development 2026-03-09 20:30:38 +00:00
Conversation 16 Commits 20 Files Changed 11 +56 -50
1 changed files with 56 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5b7ef4051d - Show all commits

48
lib/presentation/views/main_menu/group_view/create_group_view.dart
View File

@@ -146,15 +146,31 @@ class _CreateGroupViewState extends State<CreateGroupView> {
(_groupNameController.text.isEmpty ||
(selectedPlayers.length < 2))
? null
: () async {
: _saveGroup,
),
sneeex marked this conversation as resolved Outdated
flixcoo commented 2026-03-08 10:11:25 +00:00
Outdated
Review
Copy Link

Kompletten Code hier in mindestens eine Methode auslagern, falls sinnvoll auch mehrere

Kompletten Code hier in mindestens eine Methode auslagern, falls sinnvoll auch mehrere
const SizedBox(height: 20),
],
),
),
),
);
}
/// Saves the group by creating a new one or updating the existing one,
/// depending on whether the widget is in edit mode.
Future<void> _saveGroup() async {
sneeex marked this conversation as resolved Outdated
flixcoo commented 2026-03-08 11:19:05 +00:00
Outdated
Review
Copy Link

gerne die Methode nochmal aufteilen, wie bei mir in CreateMatchView:

  void buttonNavigation(BuildContext context) async {
    if (widget.matchToEdit != null) {
      await updateMatch();
      if (context.mounted) {
        Navigator.pop(context);
      }
    } else {
      final match = await createMatch();

      if (context.mounted) {
        Navigator.pushReplacement(
          context,
          adaptivePageRoute(
            fullscreenDialog: true,
            builder: (context) => MatchResultView(
              match: match,
              onWinnerChanged: widget.onWinnerChanged,
            ),
          ),
        );
      }
    }
  }
gerne die Methode nochmal aufteilen, wie bei mir in `CreateMatchView`: ```dart void buttonNavigation(BuildContext context) async { if (widget.matchToEdit != null) { await updateMatch(); if (context.mounted) { Navigator.pop(context); } } else { final match = await createMatch(); if (context.mounted) { Navigator.pushReplacement( context, adaptivePageRoute( fullscreenDialog: true, builder: (context) => MatchResultView( match: match, onWinnerChanged: widget.onWinnerChanged, ), ), ); } } } ```
sneeex commented 2026-03-08 11:25:30 +00:00
Outdated
Review
Copy Link

nö

nö
final loc = AppLocalizations.of(context);
Group? updatedGroup;
bool successfullNameChange = true;
bool successfullMemberChange = true;
late bool success;
final groupName = _groupNameController.text.trim();
if (widget.groupToEdit == null) {
success = await db.groupDao.addGroup(
group: Group(
name: _groupNameController.text.trim(),
name: groupName,
description: '',
members: selectedPlayers,
),
@@ -162,30 +178,28 @@ class _CreateGroupViewState extends State<CreateGroupView> {
} else {
updatedGroup = Group(
id: widget.groupToEdit!.id,
name: _groupNameController.text.trim(),
name: groupName,
description: '',
members: selectedPlayers,
);
if (widget.groupToEdit!.name !=
_groupNameController.text.trim()) {
successfullNameChange = await db.groupDao
.updateGroupName(
if (widget.groupToEdit!.name != groupName) {
successfullNameChange = await db.groupDao.updateGroupName(
groupId: widget.groupToEdit!.id,
newName: _groupNameController.text.trim(),
newName: groupName,
);
}
if (widget.groupToEdit!.members != selectedPlayers) {
successfullMemberChange = await db.groupDao
.replaceGroupPlayers(
successfullMemberChange = await db.groupDao.replaceGroupPlayers(
sneeex marked this conversation as resolved Outdated
flixcoo commented 2026-03-09 19:17:55 +00:00
Outdated
Review
Copy Link

Kurzen doc comment nochmal zu dieser Methode vllt

Kurzen doc comment nochmal zu dieser Methode vllt
groupId: widget.groupToEdit!.id,
sneeex marked this conversation as resolved Outdated
flixcoo commented 2026-03-09 19:20:52 +00:00
Outdated
Review
Copy Link

Lieber Methode getMatchesToGroup() in groupDao.dart, kann ggf. später auch noch einmal verwendet werden

Lieber Methode `getMatchesToGroup()` in `groupDao.dart`, kann ggf. später auch noch einmal verwendet werden
sneeex commented 2026-03-09 19:34:13 +00:00
Outdated
Review
Copy Link

hast das auch so gemacht

hast das auch so gemacht
sneeex commented 2026-03-09 19:34:25 +00:00
Outdated
Review
Copy Link

habs von dir kopiert

habs von dir kopiert
flixcoo commented 2026-03-09 19:36:58 +00:00
Outdated
Review
Copy Link

wo hab ich das gemacht? File und Zeile

wo hab ich das gemacht? File und Zeile
sneeex commented 2026-03-09 19:43:57 +00:00
Outdated
Review
Copy Link

hast das auch so gemacht, group detail view
grafik.png

hast das auch so gemacht, group detail view <img width="491" alt="grafik.png" src="attachments/ae2ff61f-bc2e-45fc-baa5-62254ff3a2e1">
grafik.png
101 KiB
flixcoo commented 2026-03-09 19:44:55 +00:00
Outdated
Review
Copy Link

ja aber da diese vorgehensweise jetzt mehr als einmal im code ist machts erst recht sinn dafür ne methode zu schreiben und entsprechende vorkommen zu ersetzen

ja aber da diese vorgehensweise jetzt mehr als einmal im code ist machts erst recht sinn dafür ne methode zu schreiben und entsprechende vorkommen zu ersetzen
newPlayers: selectedPlayers,
);
}
success =
successfullNameChange && successfullMemberChange;
success = successfullNameChange && successfullMemberChange;
}
if (!context.mounted) return;
if (!mounted) return;
if (success) {
Navigator.pop(context, updatedGroup);
} else {
@@ -195,14 +209,6 @@ class _CreateGroupViewState extends State<CreateGroupView> {
: loc.error_editing_group,
);
}
},
),
const SizedBox(height: 20),
],
),
),
),
);
}
/// Displays a snackbar with the given message and optional action.