liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

Datenbankstruktur für Spiele #16

Merged
flixcoo merged 22 commits from feature/13-datenbankstruktur-fuer-spiele into development 2025-11-15 15:56:40 +00:00
Conversation 2 Commits 22 Files Changed 27 +2 -2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7be86b3d9e - Show all commits

2
lib/data/dao/game_dao.dart
View File

@@ -24,7 +24,7 @@ class GameDao extends DatabaseAccessor<AppDatabase> with _$GameDaoMixin {
final result = await query.getSingle(); final result = await query.getSingle();
List<Player>? players; List<Player>? players;
sneeex marked this conversation as resolved
sneeex commented 2025-11-14 20:15:07 +00:00
Review
Copy Link

Wieso gehst du überall davon aus, dass players null sein kann? Man kann doch kein Game ohne Player erstellen oder in welchem case ist das der Fall?

Wieso gehst du überall davon aus, dass players null sein kann? Man kann doch kein Game ohne Player erstellen oder in welchem case ist das der Fall?
flixcoo commented 2025-11-14 21:29:27 +00:00
Review
Copy Link

Weil ein Game ja auch nur eine Group bekommern kann

Weil ein `Game` ja auch nur eine `Group` bekommern kann
if (await db.playerGameDao.hasGamePlayers(gameId: gameId)) { if (await db.playerGameDao.gameHasPlayers(gameId: gameId)) {
players = await db.playerGameDao.getPlayersByGameId(gameId: gameId); players = await db.playerGameDao.getPlayersByGameId(gameId: gameId);
} }
Group? group; Group? group;

2
lib/data/dao/player_game_dao.dart
View File

@@ -12,7 +12,7 @@ class PlayerGameDao extends DatabaseAccessor<AppDatabase>
/// Checks if there are any players associated with the given [gameId]. /// Checks if there are any players associated with the given [gameId].
/// Returns `true` if there are players, otherwise `false`. /// Returns `true` if there are players, otherwise `false`.
Future<bool> hasGamePlayers({required String gameId}) async { Future<bool> gameHasPlayers({required String gameId}) async {
final count = final count =
flixcoo marked this conversation as resolved
sneeex commented 2025-11-14 20:24:44 +00:00
Review
Copy Link

Finde den namen hasGamePlayers schlecht, besser gameHasPlayers

Finde den namen hasGamePlayers schlecht, besser `gameHasPlayers`
await (selectOnly(playerGameTable) await (selectOnly(playerGameTable)
..where(playerGameTable.gameId.equals(gameId)) ..where(playerGameTable.gameId.equals(gameId))