liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

GameHistoryView anpassen #20

Merged
flixcoo merged 27 commits from feature/2-gamehistoryview-anpassen into development 2025-11-30 15:59:25 +00:00
Conversation 18 Commits 27 Files Changed 4 +9 -6
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8c005d6e5e - Show all commits

15
lib/presentation/widgets/tiles/game_history_tile.dart
View File

@@ -103,12 +103,15 @@ class _GameHistoryTileState extends State<GameHistoryTile> {
color: Colors.amber, color: Colors.amber,
), ),
gelbeinhalb marked this conversation as resolved Outdated
flixcoo commented 2025-11-24 11:30:19 +00:00
Outdated
Review
Copy Link

Entweder die beiden Group Widgets in ein Visibility bzw Offstage Widget wrappen, oder in ein If-Statement zusammenführen:

if(group != null)
[...SizedBox(), Row()]
Entweder die beiden Group Widgets in ein `Visibility` bzw `Offstage` Widget wrappen, oder in ein If-Statement zusammenführen: ```dart if(group != null) [...SizedBox(), Row()] ```
👍 1
sneeex commented 2025-11-24 12:48:05 +00:00
Outdated
Review
Copy Link

Von Docs: "Offstage can be used to measure the dimensions of a widget without bringing it on screen (yet). To hide a widget from view while it is not needed, prefer removing the widget from the tree entirely rather than keeping it alive in an Offstage subtree" also eher das if

Von Docs: "Offstage can be used to measure the dimensions of a widget without bringing it on screen (yet). To hide a widget from view while it is not needed, prefer removing the widget from the tree entirely rather than keeping it alive in an Offstage subtree" also eher das if
👍 1
flixcoo commented 2025-11-24 12:55:17 +00:00
Outdated
Review
Copy Link

Ja dann mach das lieber mit If

Ja dann mach das lieber mit If
const SizedBox(width: 8), const SizedBox(width: 8),
Text( Expanded(
'Winner: ${winner.name}', child: Text(
style: const TextStyle( 'Winner: ${winner.name}',
fontSize: 14, style: const TextStyle(
fontWeight: FontWeight.w600, fontSize: 14,
color: Colors.white, fontWeight: FontWeight.w600,
color: Colors.white,
),
overflow: TextOverflow.ellipsis,
), ),
), ),
], ],