Datenbankkorrekturen #25

Merged
flixcoo merged 7 commits from enhancement/24-datenbankkorrekturen into development 2025-11-16 20:57:40 +00:00
4 changed files with 159 additions and 105 deletions

View File

@@ -38,7 +38,8 @@ class GroupDao extends DatabaseAccessor<AppDatabase> with _$GroupDaoMixin {
/// Adds a new group with the given [id] and [name] to the database. /// Adds a new group with the given [id] and [name] to the database.
/// This method also adds the group's members to the [PlayerGroupTable]. /// This method also adds the group's members to the [PlayerGroupTable].
Future<void> addGroup({required Group group}) async { Future<bool> addGroup({required Group group}) async {
if (!await groupExists(groupId: group.id)) {
await db.transaction(() async { await db.transaction(() async {
await into( await into(
groupTable, groupTable,
@@ -59,8 +60,11 @@ class GroupDao extends DatabaseAccessor<AppDatabase> with _$GroupDaoMixin {
await Future.wait( await Future.wait(
group.members.map((player) => db.playerDao.addPlayer(player: player)), group.members.map((player) => db.playerDao.addPlayer(player: player)),
); );
return true;
}); });
} }
return false;
}
/// Deletes the group with the given [id] from the database. /// Deletes the group with the given [id] from the database.
/// Returns `true` if more than 0 rows were affected, otherwise `false`. /// Returns `true` if more than 0 rows were affected, otherwise `false`.

View File

@@ -26,14 +26,14 @@ class PlayerDao extends DatabaseAccessor<AppDatabase> with _$PlayerDaoMixin {
/// Adds a new [player] to the database. /// Adds a new [player] to the database.
/// If a player with the same ID already exists, updates their name to /// If a player with the same ID already exists, updates their name to
/// the new one. /// the new one.
Future<void> addPlayer({required Player player}) async { Future<bool> addPlayer({required Player player}) async {
if (!await playerExists(playerId: player.id)) { if (!await playerExists(playerId: player.id)) {
await into( await into(
playerTable, playerTable,
).insert(PlayerTableCompanion.insert(id: player.id, name: player.name)); ).insert(PlayerTableCompanion.insert(id: player.id, name: player.name));
} else { return true;
await updatePlayername(playerId: player.id, newName: player.name);
} }
return false;
} }
/// Deletes the player with the given [id] from the database. /// Deletes the player with the given [id] from the database.

View File

@@ -35,12 +35,36 @@ void main() {
tearDown(() async { tearDown(() async {
await database.close(); await database.close();
}); });
group('group tests', () {
test('all groups get fetched correctly', () async {
final testgroup2 = Group(
id: 'gr2',
name: 'Second Group',
members: [player2, player3, player4],
);
await database.groupDao.addGroup(group: testgroup);
await database.groupDao.addGroup(group: testgroup2);
final allGroups = await database.groupDao.getAllGroups();
expect(allGroups.length, 2);
final fetchedGroup1 = allGroups.firstWhere((g) => g.id == testgroup.id);
expect(fetchedGroup1.name, testgroup.name);
expect(fetchedGroup1.members.length, testgroup.members.length);
expect(fetchedGroup1.members.elementAt(0).id, player1.id);
final fetchedGroup2 = allGroups.firstWhere((g) => g.id == testgroup2.id);
expect(fetchedGroup2.name, testgroup2.name);
expect(fetchedGroup2.members.length, testgroup2.members.length);
expect(fetchedGroup2.members.elementAt(0).id, player2.id);
});
//TODO: test getAllGroups method
test('group and group members gets added correctly', () async { test('group and group members gets added correctly', () async {
await database.groupDao.addGroup(group: testgroup); await database.groupDao.addGroup(group: testgroup);
final result = await database.groupDao.getGroupById(groupId: testgroup.id); final result = await database.groupDao.getGroupById(
groupId: testgroup.id,
);
expect(result.id, testgroup.id); expect(result.id, testgroup.id);
expect(result.name, testgroup.name); expect(result.name, testgroup.name);
@@ -76,7 +100,9 @@ void main() {
newName: newGroupName, newName: newGroupName,
); );
final result = await database.groupDao.getGroupById(groupId: testgroup.id); final result = await database.groupDao.getGroupById(
groupId: testgroup.id,
);
expect(result.name, newGroupName); expect(result.name, newGroupName);
}); });
@@ -104,7 +130,9 @@ void main() {
expect(playerAdded, true); expect(playerAdded, true);
final result = await database.groupDao.getGroupById(groupId: testgroup.id); final result = await database.groupDao.getGroupById(
groupId: testgroup.id,
);
expect(result.members.length, testgroup.members.length + 1); expect(result.members.length, testgroup.members.length + 1);
final addedPlayer = result.members.firstWhere((p) => p.id == player4.id); final addedPlayer = result.members.firstWhere((p) => p.id == player4.id);
@@ -122,7 +150,9 @@ void main() {
); );
expect(removed, true); expect(removed, true);
final result = await database.groupDao.getGroupById(groupId: testgroup.id); final result = await database.groupDao.getGroupById(
groupId: testgroup.id,
);
expect(result.members.length, testgroup.members.length - 1); expect(result.members.length, testgroup.members.length - 1);
final playerExists = result.members.any((p) => p.id == playerToRemove.id); final playerExists = result.members.any((p) => p.id == playerToRemove.id);
@@ -146,4 +176,5 @@ void main() {
final finalCount = await database.groupDao.getGroupCount(); final finalCount = await database.groupDao.getGroupCount();
expect(finalCount, 0); expect(finalCount, 0);
}); });
});
} }

View File

@@ -24,6 +24,25 @@ void main() {
}); });
group('player tests', () { group('player tests', () {
test('all players get fetched correctly', () async {
final testPlayer2 = Player(id: 'gr2', name: 'Second Group');
await database.playerDao.addPlayer(player: testPlayer);
await database.playerDao.addPlayer(player: testPlayer2);
final allPlayers = await database.playerDao.getAllPlayers();
expect(allPlayers.length, 2);
final fetchedPlayer1 = allPlayers.firstWhere(
(g) => g.id == testPlayer.id,
);
expect(fetchedPlayer1.name, testPlayer.name);
final fetchedPlayer2 = allPlayers.firstWhere(
(g) => g.id == testPlayer2.id,
);
expect(fetchedPlayer2.name, testPlayer2.name);
});
test('players get inserted correcly ', () async { test('players get inserted correcly ', () async {
await database.playerDao.addPlayer(player: testPlayer); await database.playerDao.addPlayer(player: testPlayer);
final result = await database.playerDao.getPlayerById( final result = await database.playerDao.getPlayerById(