liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

CreateGroupView erstellt #28

Merged
flixcoo merged 37 commits from feature/5-creategroupview-erstellen into development 2025-11-19 17:32:44 +00:00
Conversation 13 Commits 37 Files Changed 16 +27 -14
2 changed files with 27 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d3a63bd299 - Show all commits

28
lib/presentation/widgets/tiles/text_icon_list_tile.dart
View File

@@ -1,16 +1,16 @@
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:game_tracker/core/custom_theme.dart'; import 'package:game_tracker/core/custom_theme.dart';
class IconListTile extends StatelessWidget { class TextIconListTile extends StatelessWidget {
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-11-18 19:37:29 +00:00
Outdated
Review
Copy Link

Klassenname stimmt nicht mit Dateiname überein

Klassenname stimmt nicht mit Dateiname überein
final String text; final String text;
final IconData icon;
final VoidCallback onPressed; final VoidCallback onPressed;
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-11-18 19:39:48 +00:00
Outdated
Review
Copy Link

Falls das Icon bisher nur ein Icon ist, ggf. nur das Icon deaktivierbar machen anstatt es komplett selbst zu setzen

Falls das Icon bisher nur ein Icon ist, ggf. nur das Icon deaktivierbar machen anstatt es komplett selbst zu setzen
final bool iconEnabled;
const IconListTile({ const TextIconListTile({
sneeex marked this conversation as resolved
flixcoo commented 2025-11-19 00:01:45 +00:00
Review
Copy Link

grafik.png

Alignment irgendwie komisch, Abstand vom Button zum Rand viel größer als vom Namen zum rand

![grafik.png](/attachments/a1c43803-f0d1-4a01-9ab5-e2e43c651ee5) Alignment irgendwie komisch, Abstand vom Button zum Rand viel größer als vom Namen zum rand
grafik.png
8.6 KiB
super.key, super.key,
required this.text, required this.text,
required this.icon,
required this.onPressed, required this.onPressed,
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-11-19 00:00:58 +00:00
Outdated
Review
Copy Link

onPressed sollte nich required sein wenn das icon nicht immer zu sehen ist

onPressed sollte nich required sein wenn das icon nicht immer zu sehen ist
this.iconEnabled = true,
}); });
@override @override
@@ -28,13 +28,23 @@ class IconListTile extends StatelessWidget {
mainAxisSize: MainAxisSize.max, mainAxisSize: MainAxisSize.max,
children: [ children: [
Flexible( Flexible(
child: Text( child: Container(
text, padding: const EdgeInsets.symmetric(vertical: 12.5),
overflow: TextOverflow.ellipsis, child: Text(
style: const TextStyle(fontSize: 16, fontWeight: FontWeight.w500), text,
overflow: TextOverflow.ellipsis,
style: const TextStyle(
fontSize: 16,
fontWeight: FontWeight.w500,
),
),
), ),
), ),
IconButton(icon: Icon(icon, size: 20), onPressed: onPressed), if (iconEnabled)
IconButton(
icon: const Icon(Icons.add, size: 20),
onPressed: onPressed,
),
], ],
), ),
); );

13
lib/presentation/widgets/tiles/text_icon_tile.dart
View File

@@ -3,14 +3,14 @@ import 'package:game_tracker/core/custom_theme.dart';
class TextIconTile extends StatelessWidget { class TextIconTile extends StatelessWidget {
final String text; final String text;
final IconData? icon; final bool iconEnabled;
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-11-18 19:40:00 +00:00
Outdated
Review
Copy Link

Falls das Icon bisher nur ein Icon ist, ggf. nur das Icon deaktivierbar machen anstatt es komplett selbst zu setzen

Falls das Icon bisher nur ein Icon ist, ggf. nur das Icon deaktivierbar machen anstatt es komplett selbst zu setzen
final VoidCallback? onIconTap; final VoidCallback? onIconTap;
const TextIconTile({ const TextIconTile({
super.key, super.key,
required this.text, required this.text,
this.icon,
this.onIconTap, this.onIconTap,
this.iconEnabled = true,
}); });
@override @override
@@ -25,7 +25,7 @@ class TextIconTile extends StatelessWidget {
mainAxisAlignment: MainAxisAlignment.spaceBetween, mainAxisAlignment: MainAxisAlignment.spaceBetween,
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
children: [ children: [
if (icon != null) const SizedBox(width: 3), if (iconEnabled) const SizedBox(width: 3),
Flexible( Flexible(
child: Text( child: Text(
text, text,
@@ -33,9 +33,12 @@ class TextIconTile extends StatelessWidget {
style: const TextStyle(fontSize: 14, fontWeight: FontWeight.w500), style: const TextStyle(fontSize: 14, fontWeight: FontWeight.w500),
), ),
), ),
if (icon != null) ...<Widget>[ if (iconEnabled) ...<Widget>[
const SizedBox(width: 3), const SizedBox(width: 3),
GestureDetector(onTap: onIconTap, child: Icon(icon, size: 20)), GestureDetector(
onTap: onIconTap,
child: const Icon(Icons.close, size: 20),
),
], ],
], ],
), ),