liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

Timestamp zu allen Objekten hinzufügen #36

Merged
flixcoo merged 10 commits from feature/29-timestamp-zu-allen-objekten-hinzufügen into development 2025-11-19 19:23:32 +00:00
Conversation 5 Commits 10 Files Changed 14 +156 -108
3 changed files with 156 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 75c6f4e01c - Show all commits

17
test/db_tests/game_test.dart
View File

@@ -1,3 +1,4 @@
import 'package:clock/clock.dart';
import 'package:drift/drift.dart'; import 'package:drift/drift.dart';
import 'package:drift/native.dart'; import 'package:drift/native.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
@@ -15,6 +16,8 @@ void main() {
late Player player5; late Player player5;
late Group testgroup; late Group testgroup;
late Game testgame; late Game testgame;
final fixedDate = DateTime(2025, 19, 11, 00, 11, 23);
final fakeClock = Clock(() => fixedDate);
setUp(() { setUp(() {
database = AppDatabase( database = AppDatabase(
@@ -25,24 +28,30 @@ void main() {
), ),
); );
withClock(fakeClock, () {
player1 = Player(name: 'Alice'); player1 = Player(name: 'Alice');
player2 = Player(name: 'Bob'); player2 = Player(name: 'Bob');
player3 = Player(name: 'Charlie'); player3 = Player(name: 'Charlie');
player4 = Player(name: 'Diana'); player4 = Player(name: 'Diana');
player5 = Player(name: 'Eve'); player5 = Player(name: 'Eve');
testgroup = Group(name: 'Test Group', members: [player1, player2, player3]); testgroup = Group(
name: 'Test Group',
members: [player1, player2, player3],
);
testgame = Game( testgame = Game(
name: 'Test Game', name: 'Test Game',
group: testgroup, group: testgroup,
players: [player4, player5], players: [player4, player5],
); );
}); });
});
tearDown(() async { tearDown(() async {
await database.close(); await database.close();
}); });
group('game tests', () { group('game tests', () {
test('game is added correctly', () async { test('game is added correctly', () async {
await withClock(fakeClock, () async {
await database.gameDao.addGame(game: testgame); await database.gameDao.addGame(game: testgame);
final result = await database.gameDao.getGameById(gameId: testgame.id); final result = await database.gameDao.getGameById(gameId: testgame.id);
@@ -50,6 +59,7 @@ void main() {
expect(result.id, testgame.id); expect(result.id, testgame.id);
expect(result.name, testgame.name); expect(result.name, testgame.name);
expect(result.winner, testgame.winner); expect(result.winner, testgame.winner);
expect(result.createdAt, testgame.createdAt);
if (result.group != null) { if (result.group != null) {
expect(result.group!.members.length, testgroup.members.length); expect(result.group!.members.length, testgroup.members.length);
@@ -67,11 +77,16 @@ void main() {
for (int i = 0; i < testgame.players!.length; i++) { for (int i = 0; i < testgame.players!.length; i++) {
expect(result.players![i].id, testgame.players![i].id); expect(result.players![i].id, testgame.players![i].id);
expect(result.players![i].name, testgame.players![i].name); expect(result.players![i].name, testgame.players![i].name);
expect(
result.players![i].createdAt,
testgame.players![i].createdAt,
);
} }
} else { } else {
fail('Players is null'); fail('Players is null');
} }
}); });
});
test('game is deleted correctly', () async { test('game is deleted correctly', () async {
await database.gameDao.addGame(game: testgame); await database.gameDao.addGame(game: testgame);

31
test/db_tests/group_test.dart
View File

@@ -1,3 +1,4 @@
import 'package:clock/clock.dart';
import 'package:drift/drift.dart'; import 'package:drift/drift.dart';
import 'package:drift/native.dart'; import 'package:drift/native.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
@@ -12,6 +13,8 @@ void main() {
late Player player3; late Player player3;
late Player player4; late Player player4;
late Group testgroup; late Group testgroup;
final fixedDate = DateTime(2025, 19, 11, 00, 11, 23);
final fakeClock = Clock(() => fixedDate);
setUp(() { setUp(() {
database = AppDatabase( database = AppDatabase(
@@ -22,17 +25,23 @@ void main() {
), ),
); );
withClock(fakeClock, () {
player1 = Player(name: 'Alice'); player1 = Player(name: 'Alice');
player2 = Player(name: 'Bob'); player2 = Player(name: 'Bob');
player3 = Player(name: 'Charlie'); player3 = Player(name: 'Charlie');
player4 = Player(name: 'Diana'); player4 = Player(name: 'Diana');
testgroup = Group(name: 'Test Group', members: [player1, player2, player3]); testgroup = Group(
name: 'Test Group',
members: [player1, player2, player3],
);
});
}); });
tearDown(() async { tearDown(() async {
await database.close(); await database.close();
}); });
group('group tests', () { group('group tests', () {
test('all groups get fetched correctly', () async { test('all groups get fetched correctly', () async {
await withClock(fakeClock, () async {
final testgroup2 = Group( final testgroup2 = Group(
id: 'gr2', id: 'gr2',
name: 'Second Group', name: 'Second Group',
@@ -48,14 +57,20 @@ void main() {
expect(fetchedGroup1.name, testgroup.name); expect(fetchedGroup1.name, testgroup.name);
expect(fetchedGroup1.members.length, testgroup.members.length); expect(fetchedGroup1.members.length, testgroup.members.length);
expect(fetchedGroup1.members.elementAt(0).id, player1.id); expect(fetchedGroup1.members.elementAt(0).id, player1.id);
expect(fetchedGroup1.members.elementAt(0).createdAt, player1.createdAt);
final fetchedGroup2 = allGroups.firstWhere((g) => g.id == testgroup2.id); final fetchedGroup2 = allGroups.firstWhere(
(g) => g.id == testgroup2.id,
);
expect(fetchedGroup2.name, testgroup2.name); expect(fetchedGroup2.name, testgroup2.name);
expect(fetchedGroup2.members.length, testgroup2.members.length); expect(fetchedGroup2.members.length, testgroup2.members.length);
expect(fetchedGroup2.members.elementAt(0).id, player2.id); expect(fetchedGroup2.members.elementAt(0).id, player2.id);
expect(fetchedGroup2.members.elementAt(0).createdAt, player2.createdAt);
});
}); });
test('group and group members gets added correctly', () async { test('group and group members gets added correctly', () async {
await withClock(fakeClock, () async {
await database.groupDao.addGroup(group: testgroup); await database.groupDao.addGroup(group: testgroup);
final result = await database.groupDao.getGroupById( final result = await database.groupDao.getGroupById(
@@ -64,13 +79,16 @@ void main() {
expect(result.id, testgroup.id); expect(result.id, testgroup.id);
expect(result.name, testgroup.name); expect(result.name, testgroup.name);
expect(result.createdAt, testgroup.createdAt);
expect(result.members.length, testgroup.members.length); expect(result.members.length, testgroup.members.length);
for (int i = 0; i < testgroup.members.length; i++) { for (int i = 0; i < testgroup.members.length; i++) {
expect(result.members[i].id, testgroup.members[i].id); expect(result.members[i].id, testgroup.members[i].id);
expect(result.members[i].name, testgroup.members[i].name); expect(result.members[i].name, testgroup.members[i].name);
expect(result.members[i].createdAt, testgroup.members[i].createdAt);
} }
}); });
});
test('group gets deleted correctly', () async { test('group gets deleted correctly', () async {
await database.groupDao.addGroup(group: testgroup); await database.groupDao.addGroup(group: testgroup);
@@ -103,6 +121,7 @@ void main() {
}); });
test('Adding player to group works correctly', () async { test('Adding player to group works correctly', () async {
await withClock(fakeClock, () async {
await database.groupDao.addGroup(group: testgroup); await database.groupDao.addGroup(group: testgroup);
await database.playerGroupDao.addPlayerToGroup( await database.playerGroupDao.addPlayerToGroup(
@@ -124,15 +143,17 @@ void main() {
expect(playerNotAdded, true); expect(playerNotAdded, true);
expect(playerAdded, true);
final result = await database.groupDao.getGroupById( final result = await database.groupDao.getGroupById(
groupId: testgroup.id, groupId: testgroup.id,
); );
expect(result.members.length, testgroup.members.length + 1); expect(result.members.length, testgroup.members.length + 1);
final addedPlayer = result.members.firstWhere((p) => p.id == player4.id); final addedPlayer = result.members.firstWhere(
(p) => p.id == player4.id,
);
expect(addedPlayer.name, player4.name); expect(addedPlayer.name, player4.name);
expect(addedPlayer.createdAt, player4.createdAt);
});
}); });
test('Removing player from group works correctly', () async { test('Removing player from group works correctly', () async {

12
test/db_tests/player_test.dart
View File

@@ -1,3 +1,4 @@
import 'package:clock/clock.dart';
import 'package:drift/drift.dart'; import 'package:drift/drift.dart';
import 'package:drift/native.dart'; import 'package:drift/native.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
@@ -7,6 +8,8 @@ import 'package:game_tracker/data/dto/player.dart';
void main() { void main() {
late AppDatabase database; late AppDatabase database;
late Player testPlayer; late Player testPlayer;
final fixedDate = DateTime(2025, 19, 11, 00, 11, 23);
final fakeClock = Clock(() => fixedDate);
setUp(() { setUp(() {
database = AppDatabase( database = AppDatabase(
@@ -17,14 +20,17 @@ void main() {
), ),
); );
withClock(fakeClock, () {
testPlayer = Player(name: 'Test Player'); testPlayer = Player(name: 'Test Player');
}); });
});
tearDown(() async { tearDown(() async {
await database.close(); await database.close();
}); });
group('player tests', () { group('player tests', () {
test('all players get fetched correctly', () async { test('all players get fetched correctly', () async {
await withClock(fakeClock, () async {
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-11-18 23:45:24 +00:00
Outdated
Review
Copy Link

Kannst du anstatt die fake clock verwenden nicht einfach überprüfen ob die timestamp des players = timestamp des db players ist?

Kannst du anstatt die fake clock verwenden nicht einfach überprüfen ob die timestamp des players = timestamp des db players ist?
sneeex commented 2025-11-18 23:46:34 +00:00
Outdated
Review
Copy Link

Nein ist ungenau, hab's probiert, funkt net

Nein ist ungenau, hab's probiert, funkt net
sneeex commented 2025-11-18 23:46:59 +00:00
Outdated
Review
Copy Link

Gibt dann abweichungen von Millisekunden, vermutlich weil die DB nicht so genau speichern kann wie das datetime object, weil die DB intern nämlich timestamps speichert und der ja nicht so genau ist.

["Drift supports two approaches of storing DateTime values in SQL:
As unix timestamp (the default): In this mode, drift stores date time values as an SQL INTEGER containing the unix timestamp (in seconds).]

Gibt dann abweichungen von Millisekunden, vermutlich weil die DB nicht so genau speichern kann wie das datetime object, weil die DB intern nämlich timestamps speichert und der ja nicht so genau ist. _["Drift supports two approaches of storing DateTime values in SQL: As unix timestamp (the default): In this mode, drift stores date time values as an SQL INTEGER containing the unix timestamp (in seconds).]_
flixcoo commented 2025-11-18 23:52:54 +00:00
Outdated
Review
Copy Link

Und wenn du ein Datum übergibst und danach checkst? Wir müssen ja nicht Testen das Datetime funktioniert sondern nur das der datentransfer geht

Und wenn du ein Datum übergibst und danach checkst? Wir müssen ja nicht Testen das Datetime funktioniert sondern nur das der datentransfer geht
sneeex commented 2025-11-18 23:55:25 +00:00
Outdated
Review
Copy Link

Ich finde das so schön und ist wohl auch Common practice, spricht doch nichts dagegen oder? Ich will ja eben auch wissen, ob der das Datum mit Zeit in der richtigen Genauigkeit speichert und nicht nur ob er es überhaupt tut. Sollte es mal durch ein Update oder so nicht mehr korrekt sein, ist es ja wichtig zu wissen, ob der datetime der in der DB gespeichert ist dem wahren entspricht. Außerdem will ich das ja so realitätsgetreu wie möglich halten und das datetime auch von der Klasse selbst erzeugen lassen, auch wenn ich es hijacke und nicht selber bei den Playern, groups und Games setzen.

Ich finde das so schön und ist wohl auch Common practice, spricht doch nichts dagegen oder? Ich will ja eben auch wissen, ob der das Datum mit Zeit in der richtigen Genauigkeit speichert und nicht nur ob er es überhaupt tut. Sollte es mal durch ein Update oder so nicht mehr korrekt sein, ist es ja wichtig zu wissen, ob der datetime der in der DB gespeichert ist dem wahren entspricht. Außerdem will ich das ja so realitätsgetreu wie möglich halten und das datetime auch von der Klasse selbst erzeugen lassen, auch wenn ich es hijacke und nicht selber bei den Playern, groups und Games setzen.
flixcoo commented 2025-11-19 08:20:46 +00:00
Outdated
Review
Copy Link

Also was mich halt bisschen genervt hat, das man diverse Sachen jetzt in await withClock(fakeClock, () async {}); wrappen muss. Kannst du es nicht sonst so machen, dass alle Objekte die genutzt werden in der setUp(() {}); Methode erstellt, damit man die fake clock nicht mehr in den einzelnen Tests brauch?

Also was mich halt bisschen genervt hat, das man diverse Sachen jetzt in `await withClock(fakeClock, () async {});` wrappen muss. Kannst du es nicht sonst so machen, dass alle Objekte die genutzt werden in der `setUp(() {});` Methode erstellt, damit man die fake clock nicht mehr in den einzelnen Tests brauch?
sneeex commented 2025-11-19 08:22:11 +00:00
Outdated
Review
Copy Link

Also was mich halt bisschen genervt hat, das man diverse Sachen jetzt in await withClock(fakeClock, () async {}); wrappen muss. Kannst du es nicht sonst so machen, dass alle Objekte die genutzt werden in der setUp(() {}); Methode erstellt, damit man die fake clock nicht mehr in den einzelnen Tests brauch?

Bestimmt muss mal schauen

> Also was mich halt bisschen genervt hat, das man diverse Sachen jetzt in `await withClock(fakeClock, () async {});` wrappen muss. Kannst du es nicht sonst so machen, dass alle Objekte die genutzt werden in der `setUp(() {});` Methode erstellt, damit man die fake clock nicht mehr in den einzelnen Tests brauch? Bestimmt muss mal schauen
final testPlayer2 = Player(name: 'Second Group'); final testPlayer2 = Player(name: 'Second Group');
await database.playerDao.addPlayer(player: testPlayer); await database.playerDao.addPlayer(player: testPlayer);
await database.playerDao.addPlayer(player: testPlayer2); await database.playerDao.addPlayer(player: testPlayer2);
@@ -36,14 +42,18 @@ void main() {
(g) => g.id == testPlayer.id, (g) => g.id == testPlayer.id,
); );
expect(fetchedPlayer1.name, testPlayer.name); expect(fetchedPlayer1.name, testPlayer.name);
expect(fetchedPlayer1.createdAt, testPlayer.createdAt);
final fetchedPlayer2 = allPlayers.firstWhere( final fetchedPlayer2 = allPlayers.firstWhere(
(g) => g.id == testPlayer2.id, (g) => g.id == testPlayer2.id,
); );
expect(fetchedPlayer2.name, testPlayer2.name); expect(fetchedPlayer2.name, testPlayer2.name);
expect(fetchedPlayer2.createdAt, testPlayer2.createdAt);
});
}); });
test('players get inserted correcly ', () async { test('players get inserted correcly ', () async {
await withClock(fakeClock, () async {
await database.playerDao.addPlayer(player: testPlayer); await database.playerDao.addPlayer(player: testPlayer);
final result = await database.playerDao.getPlayerById( final result = await database.playerDao.getPlayerById(
playerId: testPlayer.id, playerId: testPlayer.id,
@@ -51,6 +61,8 @@ void main() {
expect(result.id, testPlayer.id); expect(result.id, testPlayer.id);
expect(result.name, testPlayer.name); expect(result.name, testPlayer.name);
expect(result.createdAt, testPlayer.createdAt);
});
}); });
test('players get deleted correcly ', () async { test('players get deleted correcly ', () async {