liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

GameResultView erstellen #62

Merged
flixcoo merged 31 commits from feature/48-game-result-view-erstellen into development 2025-12-06 14:06:29 +00:00
Conversation 11 Commits 31 Files Changed 5 +27 -34
1 changed files with 27 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 03035138ac - Show all commits

29
lib/presentation/views/main_menu/game_result_view.dart
View File

@@ -5,7 +5,6 @@ import 'package:game_tracker/data/dto/game.dart';
import 'package:game_tracker/data/dto/player.dart';
import 'package:game_tracker/presentation/widgets/buttons/custom_width_button.dart';
import 'package:game_tracker/presentation/widgets/tiles/custom_radio_list_tile.dart';
import 'package:game_tracker/presentation/widgets/top_centered_message.dart';
import 'package:provider/provider.dart';
class GameResultView extends StatefulWidget {
@@ -20,14 +19,16 @@ class GameResultView extends StatefulWidget {
class _GameResultViewState extends State<GameResultView> {
late final List<Player> allPlayers;
late final AppDatabase db;
Player? _player;
Player? _selectedPlayer;
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-12-05 23:30:36 +00:00
Outdated
Review
Copy Link

Umbenennen in selectedPlayer oder currentWinner o.Ä.

Umbenennen in `selectedPlayer` oder `currentWinner` o.Ä.
@override
void initState() {
db = Provider.of<AppDatabase>(context, listen: false);
allPlayers = getAllPlayers(widget.game);
if (widget.game.winner != null) {
_player = allPlayers.firstWhere((p) => p.id == widget.game.winner!.id);
_selectedPlayer = allPlayers.firstWhere(
(p) => p.id == widget.game.winner!.id,
);
}
super.initState();
}
@@ -78,20 +79,13 @@ class _GameResultViewState extends State<GameResultView> {
fontWeight: FontWeight.bold,
),
),
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-12-05 23:31:34 +00:00
Outdated
Review
Copy Link

Würde height mindestens auf 10 erhöhen

Würde `height` mindestens auf 10 erhöhen
const SizedBox(height: 2),
Visibility(
visible: allPlayers.isNotEmpty,
replacement: const TopCenteredMessage(
icon: Icons.info,
title: 'Info',
message: 'No players in this game.',
),
child: Expanded(
const SizedBox(height: 10),
Expanded(
child: RadioGroup<Player>(
sneeex marked this conversation as resolved Outdated
flixcoo commented 2025-12-05 23:32:19 +00:00
Outdated
Review
Copy Link

Macht das Sinn überhaupt zu implementieren? Gibt es Fälle in denen ein Spiel keine Spieler hat?

Macht das Sinn überhaupt zu implementieren? Gibt es Fälle in denen ein Spiel keine Spieler hat?
sneeex commented 2025-12-06 08:34:52 +00:00
Outdated
Review
Copy Link

Eigentlich nicht, soll ich's weglassen dann?

Eigentlich nicht, soll ich's weglassen dann?
groupValue: _player,
groupValue: _selectedPlayer,
onChanged: (Player? value) {
setState(() {
_player = value;
_selectedPlayer = value;
});
},
child: ListView.builder(
@@ -102,7 +96,7 @@ class _GameResultViewState extends State<GameResultView> {
value: allPlayers[index],
onContainerTap: (value) {
setState(() {
_player = value;
_selectedPlayer = value;
});
},
);
@@ -110,7 +104,6 @@ class _GameResultViewState extends State<GameResultView> {
),
),
),
),
],
),
),
@@ -118,11 +111,11 @@ class _GameResultViewState extends State<GameResultView> {
CustomWidthButton(
text: 'Save',
sizeRelativeToWidth: 0.95,
onPressed: _player != null
onPressed: _selectedPlayer != null
? () async {
bool success = await db.gameDao.setWinner(
gameId: widget.game.id,
winnerId: _player!.id,
winnerId: _selectedPlayer!.id,
);
if (!context.mounted) return;
if (success) {