liquid-development/game-tracker
3
0
Fork 0
Code Issues 17 Pull Requests 7 Actions Releases 1 Activity

Navbar Anpassen #9

Merged
gelbeinhalb merged 11 commits from enhancement/8-tabbar-angleichen into development 2025-11-09 19:59:56 +00:00
Conversation 2 Commits 11 Files Changed 2 +42 -17
2 changed files with 42 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1b090a43a0 - Show all commits

32
lib/presentation/views/main_menu/custom_navigation_bar.dart
View File

@@ -67,10 +67,34 @@ class _CustomNavigationBarState extends State<CustomNavigationBar>
child: Row( child: Row(
mainAxisAlignment: MainAxisAlignment.spaceAround, mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[ children: <Widget>[
NavbarItem(currentIndex: currentIndex, index: 0, icon: Icons.home_rounded, label: 'Home', onTabTapped: onTabTapped), NavbarItem(
NavbarItem(currentIndex: currentIndex, index: 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped), index: 0,
NavbarItem(currentIndex: currentIndex, index: 2, icon: Icons.group_rounded, label: 'Groups', onTabTapped: onTabTapped), isSelected: currentIndex == 0,
NavbarItem(currentIndex: currentIndex, index: 3, icon: Icons.bar_chart_rounded, label: 'Stats', onTabTapped: onTabTapped), icon: Icons.home_rounded,
label: 'Home',
onTabTapped: onTabTapped,
),
NavbarItem(
index: 1,
isSelected: currentIndex == 1,
icon: Icons.gamepad_rounded,
label: 'Games',
onTabTapped: onTabTapped,
flixcoo marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 16:38:17 +00:00
Outdated
Review
Copy Link

Ich würde das Widget entweder Auslagern (als nav_item.dart im widgets Ordner) oder das Expanded Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.

Ich würde das Widget entweder Auslagern (als `nav_item.dart` im `widgets` Ordner) oder das `Expanded` Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.
gelbeinhalb commented 2025-11-08 16:43:37 +00:00
Outdated
Review
Copy Link

Ja stimmt.
Ich lager das dann aus.

Ja stimmt. Ich lager das dann aus.
),
NavbarItem(
index: 2,
gelbeinhalb marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 16:39:04 +00:00
Outdated
Review
Copy Link

Chat GPT kommentare?

Chat GPT kommentare?
isSelected: currentIndex == 2,
icon: Icons.group_rounded,
label: 'Groups',
onTabTapped: onTabTapped,
),
NavbarItem(
index: 3,
isSelected: currentIndex == 3,
icon: Icons.bar_chart_rounded,
label: 'Stats',
onTabTapped: onTabTapped,
),
], ],
), ),
), ),

27
lib/presentation/widgets/navbar_item.dart
View File

@@ -1,18 +1,20 @@
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
class NavbarItem extends StatefulWidget { class NavbarItem extends StatefulWidget {
final int currentIndex;
final int index; final int index;
final bool isSelected;
final IconData icon; final IconData icon;
final String label; final String label;
final Function(int) onTabTapped; final Function(int) onTabTapped;
const NavbarItem( const NavbarItem({
{super.key, required this.currentIndex, required this.index, super.key,
required this.icon, required this.label, required this.onTabTapped required this.index,
} required this.isSelected,
); required this.icon,
required this.label,
required this.onTabTapped,
});
@override @override
State<NavbarItem> createState() => _NavbarItemState(); State<NavbarItem> createState() => _NavbarItemState();
@@ -21,9 +23,6 @@ class NavbarItem extends StatefulWidget {
class _NavbarItemState extends State<NavbarItem> { class _NavbarItemState extends State<NavbarItem> {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
flixcoo marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 17:13:05 +00:00
Outdated
Review
Copy Link

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter
gelbeinhalb commented 2025-11-08 22:59:40 +00:00
Outdated
Review
Copy Link

ja überleg dir ma was

ja überleg dir ma was
flixcoo commented 2025-11-09 16:52:29 +00:00
Outdated
Review
Copy Link

Du könntest z.B. einen Parameter isSelected übergeben der gesetzt wird wenn currentIndex == 0 // 1, 2, 3, also folgendermaßen:

NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped)
Du könntest z.B. einen Parameter `isSelected` übergeben der gesetzt wird wenn `currentIndex == 0 // 1, 2, 3`, also folgendermaßen: ```dart NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped) ```
gelbeinhalb commented 2025-11-09 19:38:43 +00:00
Outdated
Review
Copy Link

wäre das fine mit dir?

NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped )
wäre das fine mit dir? ```dart NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped ) ```
bool isSelected = widget.currentIndex == widget.index;
return Expanded( return Expanded(
child: GestureDetector( child: GestureDetector(
onTap: () => widget.onTabTapped(widget.index), onTap: () => widget.onTabTapped(widget.index),
@@ -36,15 +35,17 @@ class _NavbarItemState extends State<NavbarItem> {
children: [ children: [
Icon( Icon(
widget.icon, widget.icon,
color: isSelected ? Colors.white : Colors.black, color: widget.isSelected ? Colors.white : Colors.black,
), ),
const SizedBox(height: 4), const SizedBox(height: 4),
Text( Text(
widget.label, widget.label,
style: TextStyle( style: TextStyle(
color: isSelected ? Colors.white : Colors.black, color: widget.isSelected ? Colors.white : Colors.black,
fontSize: 12, fontSize: 12,
fontWeight: isSelected ? FontWeight.bold : FontWeight.normal, fontWeight: widget.isSelected
? FontWeight.bold
: FontWeight.normal,
), ),
), ),
], ],