liquid-development/game-tracker
3
0
Fork 0
Code Issues 14 Pull Requests 6 Actions Releases 1 Activity

Navbar Anpassen #9

Merged
gelbeinhalb merged 11 commits from enhancement/8-tabbar-angleichen into development 2025-11-09 19:59:56 +00:00
Conversation 2 Commits 11 Files Changed 2 +49 -40
2 changed files with 49 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 92817bc4db - Show all commits

42
lib/presentation/views/main_menu/custom_navigation_bar.dart
View File

@@ -5,6 +5,7 @@ import 'package:game_tracker/presentation/views/main_menu/groups_view.dart';
import 'package:game_tracker/presentation/views/main_menu/home_view.dart';
import 'package:game_tracker/presentation/views/main_menu/settings_view.dart';
import 'package:game_tracker/presentation/views/main_menu/statistics_view.dart';
import 'package:game_tracker/presentation/widgets/navbar_item.dart';
class CustomNavigationBar extends StatefulWidget {
const CustomNavigationBar({super.key});
@@ -66,10 +67,10 @@ class _CustomNavigationBarState extends State<CustomNavigationBar>
child: Row(
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
_buildNavItem(Icons.home, 'Home', 0),
_buildNavItem(Icons.history, 'Games', 1),
_buildNavItem(Icons.groups, 'Groups', 2),
_buildNavItem(Icons.bar_chart, 'Stats', 3),
NavbarItem(currentIndex: currentIndex, index: 0, icon: Icons.home_rounded, label: 'Home', onTabTapped: onTabTapped),
NavbarItem(currentIndex: currentIndex, index: 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped),
NavbarItem(currentIndex: currentIndex, index: 2, icon: Icons.group_rounded, label: 'Groups', onTabTapped: onTabTapped),
NavbarItem(currentIndex: currentIndex, index: 3, icon: Icons.bar_chart_rounded, label: 'Stats', onTabTapped: onTabTapped),
],
),
),
@@ -79,39 +80,6 @@ class _CustomNavigationBarState extends State<CustomNavigationBar>
);
}
flixcoo marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 16:38:17 +00:00
Outdated
Review
Copy Link

Ich würde das Widget entweder Auslagern (als nav_item.dart im widgets Ordner) oder das Expanded Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.

Ich würde das Widget entweder Auslagern (als `nav_item.dart` im `widgets` Ordner) oder das `Expanded` Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.
gelbeinhalb commented 2025-11-08 16:43:37 +00:00
Outdated
Review
Copy Link

Ja stimmt.
Ich lager das dann aus.

Ja stimmt. Ich lager das dann aus.
Widget _buildNavItem(IconData icon, String label, int index) {
final isSelected = currentIndex == index;
return Expanded(
child: GestureDetector(
onTap: () => onTabTapped(index),
behavior: HitTestBehavior.opaque,
child: Padding(
padding: const EdgeInsets.symmetric(vertical: 5.0),
child: Column(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.center,
children: [
Icon(
icon,
color: isSelected ? Colors.white : Colors.black,
),
const SizedBox(height: 4),
Text(
label,
style: TextStyle(
color: isSelected ? Colors.white : Colors.black,
fontSize: 12,
fontWeight: isSelected ? FontWeight.bold : FontWeight.normal,
),
),
],
),
),
),
);
}
void onTabTapped(int index) {
setState(() {
currentIndex = index;
gelbeinhalb marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 16:39:04 +00:00
Outdated
Review
Copy Link

Chat GPT kommentare?

Chat GPT kommentare?

47
lib/presentation/widgets/navbar_item.dart
View File

@@ -1,7 +1,18 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
class NavbarItem extends StatefulWidget {
const NavbarItem({super.key});
final int currentIndex;
final int index;
final IconData icon;
final String label;
final Function(int) onTabTapped;
const NavbarItem(
{super.key, required this.currentIndex, required this.index,
required this.icon, required this.label, required this.onTabTapped
}
);
@override
State<NavbarItem> createState() => _NavbarItemState();
@@ -10,6 +21,36 @@ class NavbarItem extends StatefulWidget {
class _NavbarItemState extends State<NavbarItem> {
@override
Widget build(BuildContext context) {
return const Placeholder();
bool isSelected = widget.currentIndex == widget.index;
flixcoo marked this conversation as resolved Outdated
flixcoo commented 2025-11-08 17:13:05 +00:00
Outdated
Review
Copy Link

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter
gelbeinhalb commented 2025-11-08 22:59:40 +00:00
Outdated
Review
Copy Link

ja überleg dir ma was

ja überleg dir ma was
flixcoo commented 2025-11-09 16:52:29 +00:00
Outdated
Review
Copy Link

Du könntest z.B. einen Parameter isSelected übergeben der gesetzt wird wenn currentIndex == 0 // 1, 2, 3, also folgendermaßen:

NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped)
Du könntest z.B. einen Parameter `isSelected` übergeben der gesetzt wird wenn `currentIndex == 0 // 1, 2, 3`, also folgendermaßen: ```dart NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped) ```
gelbeinhalb commented 2025-11-09 19:38:43 +00:00
Outdated
Review
Copy Link

wäre das fine mit dir?

NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped )
wäre das fine mit dir? ```dart NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped ) ```
return Expanded(
child: GestureDetector(
onTap: () => widget.onTabTapped(widget.index),
behavior: HitTestBehavior.opaque,
child: Padding(
padding: const EdgeInsets.symmetric(vertical: 5.0),
child: Column(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.center,
children: [
Icon(
widget.icon,
color: isSelected ? Colors.white : Colors.black,
),
const SizedBox(height: 4),
Text(
widget.label,
style: TextStyle(
color: isSelected ? Colors.white : Colors.black,
fontSize: 12,
fontWeight: isSelected ? FontWeight.bold : FontWeight.normal,
),
),
],
),
),
),
);
}
}