Renamed variables to be consistent

test/db_tests/group_test.dart

@@ -8,14 +8,14 @@ import 'package:game_tracker/data/dto/player.dart';
 
 void main() {
   late AppDatabase database;
-  late Player player1;
-  late Player player2;
-  late Player player3;
-  late Player player4;
-  late Group testgroup;
-  late Group testgroup2;
-  late Group testgroup3;
-  late Group testgroup4;
+  late Player testPlayer1;
+  late Player testPlayer2;
+  late Player testPlayer3;
+  late Player testPlayer4;
+  late Group testGroup1;
+  late Group testGroup2;
+  late Group testGroup3;
+  late Group testGroup4;
   final fixedDate = DateTime(2025, 19, 11, 00, 11, 23);
   final fakeClock = Clock(() => fixedDate);
 
@@ -29,28 +29,28 @@ void main() {
     );
 
     withClock(fakeClock, () {
-      player1 = Player(name: 'Alice');
-      player2 = Player(name: 'Bob');
-      player3 = Player(name: 'Charlie');
-      player4 = Player(name: 'Diana');
-      testgroup = Group(
+      testPlayer1 = Player(name: 'Alice');
+      testPlayer2 = Player(name: 'Bob');
+      testPlayer3 = Player(name: 'Charlie');
+      testPlayer4 = Player(name: 'Diana');
+      testGroup1 = Group(
         name: 'Test Group',
-        members: [player1, player2, player3],
+        members: [testPlayer1, testPlayer2, testPlayer3],
       );
-      testgroup2 = Group(
+      testGroup2 = Group(
         id: 'gr2',
         name: 'Second Group',
-        members: [player2, player3, player4],
+        members: [testPlayer2, testPlayer3, testPlayer4],
       );
-      testgroup3 = Group(
+      testGroup3 = Group(
         id: 'gr2',
         name: 'Second Group',
-        members: [player2, player4],
+        members: [testPlayer2, testPlayer4],
       );
-      testgroup4 = Group(
+      testGroup4 = Group(
         id: 'gr2',
         name: 'Second Group',
-        members: [player1, player2, player3, player4],
+        members: [testPlayer1, testPlayer2, testPlayer3, testPlayer4],
       );
     });
   });
@@ -59,38 +59,38 @@ void main() {
   });
   group('Group Tests', () {
     test('Adding and fetching a single group works correctly', () async {
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
 
       final fetchedGroup = await database.groupDao.getGroupById(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
 
-      expect(fetchedGroup.id, testgroup.id);
-      expect(fetchedGroup.name, testgroup.name);
-      expect(fetchedGroup.createdAt, testgroup.createdAt);
+      expect(fetchedGroup.id, testGroup1.id);
+      expect(fetchedGroup.name, testGroup1.name);
+      expect(fetchedGroup.createdAt, testGroup1.createdAt);
 
-      expect(fetchedGroup.members.length, testgroup.members.length);
-      for (int i = 0; i < testgroup.members.length; i++) {
-        expect(fetchedGroup.members[i].id, testgroup.members[i].id);
-        expect(fetchedGroup.members[i].name, testgroup.members[i].name);
+      expect(fetchedGroup.members.length, testGroup1.members.length);
+      for (int i = 0; i < testGroup1.members.length; i++) {
+        expect(fetchedGroup.members[i].id, testGroup1.members[i].id);
+        expect(fetchedGroup.members[i].name, testGroup1.members[i].name);
         expect(
           fetchedGroup.members[i].createdAt,
-          testgroup.members[i].createdAt,
+          testGroup1.members[i].createdAt,
         );
       }
     });
 
     test('Adding and fetching multiple groups works correctly', () async {
       // TODO: Use upcoming addGroups() method
-      await database.groupDao.addGroup(group: testgroup);
-      await database.groupDao.addGroup(group: testgroup2);
-      await database.groupDao.addGroup(group: testgroup3);
-      await database.groupDao.addGroup(group: testgroup4);
+      await database.groupDao.addGroup(group: testGroup1);
+      await database.groupDao.addGroup(group: testGroup2);
+      await database.groupDao.addGroup(group: testGroup3);
+      await database.groupDao.addGroup(group: testGroup4);
 
       final allGroups = await database.groupDao.getAllGroups();
       expect(allGroups.length, 2);
 
-      final testGroups = {testgroup.id: testgroup, testgroup2.id: testgroup2};
+      final testGroups = {testGroup1.id: testGroup1, testGroup2.id: testGroup2};
 
       for (final group in allGroups) {
         final expectedGroup = testGroups[group.id]!;
@@ -112,8 +112,8 @@ void main() {
     });
 
     test('Adding the same group twice does not create duplicates', () async {
-      await database.groupDao.addGroup(group: testgroup);
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
+      await database.groupDao.addGroup(group: testGroup1);
 
       final allGroups = await database.groupDao.getAllGroups();
       expect(allGroups.length, 1);
@@ -121,42 +121,42 @@ void main() {
 
     test('Group existence check works correctly', () async {
       var groupExists = await database.groupDao.groupExists(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
       expect(groupExists, false);
 
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
 
-      groupExists = await database.groupDao.groupExists(groupId: testgroup.id);
+      groupExists = await database.groupDao.groupExists(groupId: testGroup1.id);
       expect(groupExists, true);
     });
 
     test('Deleting a group works correclty', () async {
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
 
       final groupDeleted = await database.groupDao.deleteGroup(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
       expect(groupDeleted, true);
 
       final groupExists = await database.groupDao.groupExists(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
       expect(groupExists, false);
     });
 
     test('Updating a group name works correcly', () async {
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
 
       const newGroupName = 'new group name';
 
       await database.groupDao.updateGroupname(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
         newName: newGroupName,
       );
 
       final result = await database.groupDao.getGroupById(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
       expect(result.name, newGroupName);
     });
@@ -165,13 +165,13 @@ void main() {
       final initialCount = await database.groupDao.getGroupCount();
       expect(initialCount, 0);
 
-      await database.groupDao.addGroup(group: testgroup);
+      await database.groupDao.addGroup(group: testGroup1);
 
       final groupAdded = await database.groupDao.getGroupCount();
       expect(groupAdded, 1);
 
       final groupRemoved = await database.groupDao.deleteGroup(
-        groupId: testgroup.id,
+        groupId: testGroup1.id,
       );
       expect(groupRemoved, true);