liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

getAllGames returnt nicht alle Attribute von der game Klasse #45

Merged
flixcoo merged 20 commits from bug/37-getallgames-returnt-nicht-alle-attribute-von-der-game-klasse into development 2025-11-22 15:22:11 +00:00
Conversation 2 Commits 20 Files Changed 11 +873 -267
flixcoo commented 2025-11-20 22:41:30 +00:00
Owner
Copy Link

getAllGames returnt nicht alle Attribute von der game Klasse

Zugehörige Issue(s):
Closes #37

Beschreibung

Der Fehler wurde behoben und betreffende Methoden wurden korrigiert. Desweiteren wurden die Tests vereinheitlicht und erweitert.

Änderungen

  • Methode getAllGames() korrigiert
  • null-Rückggabe für getGroupOfGame() und getPlayersOfGame() angepasst
  • Alle Tests erweitert und vereinheitlicht
  • Test für PlayerGroupTable,PlayerGameTable und GroupGameTable erstellt bzw. ausgelagert
  • Alle Testvariablen einheitlich benannt

Zusätzliche Anmerkungen

Die Test-TODOs werden in #33 erledigt, da dort diese Methoden implementiert sind

# getAllGames returnt nicht alle Attribute von der game Klasse **Zugehörige Issue(s):** Closes #37 ## Beschreibung Der Fehler wurde behoben und betreffende Methoden wurden korrigiert. Desweiteren wurden die Tests vereinheitlicht und erweitert. ## Änderungen - Methode `getAllGames()` korrigiert - `null`-Rückggabe für `getGroupOfGame()` und `getPlayersOfGame()` angepasst - Alle Tests erweitert und vereinheitlicht - Test für `PlayerGroupTable`,`PlayerGameTable` und `GroupGameTable` erstellt bzw. ausgelagert - Alle Testvariablen einheitlich benannt ## Zusätzliche Anmerkungen Die Test-TODOs werden in #33 erledigt, da dort diese Methoden implementiert sind
flixcoo added this to the Minimum Viable Product (MVP) milestone 2025-11-20 22:41:30 +00:00
flixcoo added the
Priority
High
2
PR
Ready for Review
2
 labels 2025-11-20 22:41:30 +00:00
flixcoo self-assigned this 2025-11-20 22:41:30 +00:00
flixcoo added 3 commits 2025-11-20 22:41:30 +00:00
Fixed error in getAllGames method a61818dd77
Updated insert modes 72067863c2
Overhauled tests
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m8s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m8s
Details
89b3f1ff69
flixcoo requested review from gelbeinhalb 2025-11-20 22:41:30 +00:00
flixcoo requested review from sneeex 2025-11-20 22:41:30 +00:00
flixcoo added 4 commits 2025-11-21 00:05:39 +00:00
Added methods of todos 31589855f2
Refactoring 6055eb63a8
Refactoring b21ca54672
Refactored tests in own files
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m5s
Details
961c6bb679
flixcoo added 3 commits 2025-11-21 11:46:24 +00:00
Added missing test fe9239ee02
Fixed test 229750ffcf
Annotation for missing test & method
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m1s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m4s
Details
32f3f68da9
flixcoo removed the
PR
Ready for Review
2
 label 2025-11-21 11:48:21 +00:00
flixcoo changed title from getAllGames returnt nicht alle Attribute von der game Klasse to WIP: getAllGames returnt nicht alle Attribute von der game Klasse 2025-11-21 11:48:22 +00:00
flixcoo added 1 commit 2025-11-21 12:12:39 +00:00
Added missing methods
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
e15f5d163d
flixcoo added the
PR
Ready for Review
2
 label 2025-11-21 12:20:46 +00:00
flixcoo changed title from WIP: getAllGames returnt nicht alle Attribute von der game Klasse to getAllGames returnt nicht alle Attribute von der game Klasse 2025-11-21 12:20:50 +00:00
flixcoo added 1 commit 2025-11-21 12:42:31 +00:00
Added iteration for multiple items test
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
d948f2f13d
flixcoo added 1 commit 2025-11-21 12:47:32 +00:00
Renamed variables to be consistent
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
8c05385203
flixcoo added 1 commit 2025-11-21 13:20:46 +00:00
Added missing awaits
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m6s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
dbb52cfc48
flixcoo added 1 commit 2025-11-21 13:25:02 +00:00
Typo
All checks were successful
Pull Request Pipeline / lint (pull_request) Successful in 2m25s
Details
Pull Request Pipeline / test (pull_request) Successful in 2m25s
Details
ab250e2df4
sneeex requested changes 2025-11-22 13:10:11 +00:00
Dismissed
lib/data/dao/game_dao.dart Outdated
@@ -23,0 +24,4 @@
id: row.id,
name: row.name,
group: group,
players: player,
sneeex commented 2025-11-22 12:20:33 +00:00
Owner
Copy Link

sollte die variable player nicht players heißen? sind ja zwingend mehrere

sollte die variable player nicht players heißen? sind ja zwingend mehrere
flixcoo marked this conversation as resolved
lib/data/dao/player_group_dao.dart Outdated
@@ -13,0 +25,4 @@
return false;
}
if (await db.playerDao.playerExists(playerId: player.id) == false) {
sneeex commented 2025-11-22 12:34:06 +00:00
Owner
Copy Link

warum == false und nicht if(!(....))

warum == false und nicht if(!(....))
flixcoo marked this conversation as resolved
test/db_tests/game_test.dart Outdated
@@ -88,0 +128,4 @@
expect(game.winner, expectedGame.winner);
// Group-Checks
if (expectedGame.group != null) {
sneeex commented 2025-11-22 12:53:09 +00:00
Owner
Copy Link

was ist wenn bspw. testGame1 die group null ist, obwohl sie ja eigentlich nicht null sein soll? darauf müsste doch auch überprüft werden

was ist wenn bspw. testGame1 die group null ist, obwohl sie ja eigentlich nicht null sein soll? darauf müsste doch auch überprüft werden
flixcoo marked this conversation as resolved
test/db_tests/group_test.dart
@@ -52,0 +81,4 @@
});
test('Adding and fetching multiple groups works correctly', () async {
// TODO: Use upcoming addGroups() method
sneeex commented 2025-11-22 13:06:49 +00:00
Owner
Copy Link

remove comment

remove comment
flixcoo marked this conversation as resolved
test/db_tests/player_test.dart
@@ -57,2 +58,2 @@
playerId: testPlayer.id,
);
test('Adding and fetching multiple players works correctly', () async {
// TODO: Use upcoming addPlayers() method
sneeex commented 2025-11-22 13:07:12 +00:00
Owner
Copy Link

remove comment

remove comment
flixcoo marked this conversation as resolved
flixcoo added 5 commits 2025-11-22 13:22:12 +00:00
Renamed variable 62eea08614
Removed false comparison 24f18f5c65
Renamed variable and added null checks bef812502c
Renamed variable 9346f61d14
Renamed variable
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m3s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m5s
Details
30645f06f8
sneeex approved these changes 2025-11-22 14:39:06 +00:00
flixcoo merged commit 78b511b207 into development 2025-11-22 15:22:11 +00:00
flixcoo deleted branch bug/37-getallgames-returnt-nicht-alle-attribute-von-der-game-klasse 2025-11-22 15:22:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
sneeex
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Priority
High
2
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#45
Delete Branch "bug/37-getallgames-returnt-nicht-alle-attribute-von-der-game-klasse"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?