liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 6 Actions Releases 1 Activity

Navbar Anpassen #9

Merged
gelbeinhalb merged 11 commits from enhancement/8-tabbar-angleichen into development 2025-11-09 19:59:56 +00:00
Conversation 2 Commits 11 Files Changed 2 +101 -46
gelbeinhalb commented 2025-11-08 14:58:27 +00:00
Owner
Copy Link

Navbar Angleichen

Felix nennt es Tabbar ich würde es Navbar nennen -> er meint Navbar ist für ihn oben -> dann halt Bottom Navbar.

Zugehörige Issue(s):
Closes #8

Description

  • Updated Navbar

Changes Made

  • Removed floating button
  • Changed icons
  • Added text below icons
  • Changed navbar to be rounded and float
  • Added bigger icon hitboxes

Comparison

before after
image.png image.png
# Navbar Angleichen Felix nennt es Tabbar ich würde es Navbar nennen -> er meint Navbar ist für ihn oben -> dann halt Bottom Navbar. **Zugehörige Issue(s):** Closes #8 ## Description - Updated Navbar ## Changes Made - [x] Removed floating button - [x] Changed icons - [x] Added text below icons - [x] Changed navbar to be rounded and float - [x] Added bigger icon hitboxes ## Comparison | before | after | | --- | --- | | ![image.png](/attachments/5a603edd-4a15-4151-bb1c-71dbc986f50a) | ![image.png](/attachments/3a8e456e-bb42-4aec-9f09-28eec5d85461) |
image.png
11 KiB
image.png
12 KiB
gelbeinhalb added this to the Minimum Viable Product (MVP) milestone 2025-11-08 14:58:27 +00:00
gelbeinhalb added the
Task
Enhancement
Priority
Low
4
PR
Ready for Review
2
 labels 2025-11-08 14:58:27 +00:00
gelbeinhalb added 4 commits 2025-11-08 14:58:27 +00:00
removed floating button 9db8c80d63
add text and change icons 0895f6df0a
change history text to games 5baeda8b32
change spacing of icons d5315a8f00
gelbeinhalb requested review from flixcoo 2025-11-08 14:58:27 +00:00
gelbeinhalb requested review from sneeex 2025-11-08 14:58:27 +00:00
gelbeinhalb added 1 commit 2025-11-08 15:50:21 +00:00
add floating and rounded navbar 5bbb5c1888
gelbeinhalb added 1 commit 2025-11-08 16:19:09 +00:00
add bigger hitboxes 17d304eb5d
gelbeinhalb changed title from 8-tabbar-angleichen to WIP: 8-tabbar-angleichen 2025-11-08 16:20:09 +00:00
gelbeinhalb changed title from WIP: 8-tabbar-angleichen to 8-tabbar-angleichen 2025-11-08 16:20:16 +00:00
gelbeinhalb was assigned by flixcoo 2025-11-08 16:22:49 +00:00
gelbeinhalb changed title from 8-tabbar-angleichen to Navbar Anpassen 2025-11-08 16:32:39 +00:00
flixcoo requested changes 2025-11-08 16:39:16 +00:00
lib/presentation/views/main_menu/custom_navigation_bar.dart Outdated
@@ -75,3 +55,1 @@
icon: Icon(
Icons.home,
color: currentIndex == 0 ? Colors.white : Colors.black,
extendBody: true, // Enables floating effect
flixcoo commented 2025-11-08 16:35:06 +00:00
Owner
Copy Link

Chat GPT Kommentar entfernen

Chat GPT Kommentar entfernen
gelbeinhalb commented 2025-11-08 16:42:32 +00:00
Author
Owner
Copy Link

Hab ich extra reingemacht weil ich das so unlogisch fand. Also der Code erklärt sich nicht selber finde ich

Hab ich extra reingemacht weil ich das so unlogisch fand. Also der Code erklärt sich nicht selber finde ich
flixcoo marked this conversation as resolved
lib/presentation/views/main_menu/custom_navigation_bar.dart Outdated
@@ -106,3 +79,4 @@
);
}
Widget _buildNavItem(IconData icon, String label, int index) {
flixcoo commented 2025-11-08 16:38:17 +00:00
Owner
Copy Link

Ich würde das Widget entweder Auslagern (als nav_item.dart im widgets Ordner) oder das Expanded Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.

Ich würde das Widget entweder Auslagern (als `nav_item.dart` im `widgets` Ordner) oder das `Expanded` Widget direkt in die Row setzen (nicht so geil). Wenn du das Auslagerst sparst du dir ganz viel Code hier und übergibst die Parameter einfach direkt in das Widget.
gelbeinhalb commented 2025-11-08 16:43:37 +00:00
Author
Owner
Copy Link

Ja stimmt.
Ich lager das dann aus.

Ja stimmt. Ich lager das dann aus.
flixcoo marked this conversation as resolved
lib/presentation/views/main_menu/custom_navigation_bar.dart Outdated
@@ -109,0 +82,4 @@
Widget _buildNavItem(IconData icon, String label, int index) {
final isSelected = currentIndex == index;
return Expanded( // makes each nav item occupy equal width = large horizontal hitbox
flixcoo commented 2025-11-08 16:39:04 +00:00
Owner
Copy Link

Chat GPT kommentare?

Chat GPT kommentare?
gelbeinhalb marked this conversation as resolved
gelbeinhalb added 1 commit 2025-11-08 16:45:13 +00:00
remove useless comments 1698f61c2b
gelbeinhalb added 2 commits 2025-11-08 17:06:28 +00:00
add navbar_item.dart 34df9f007b
move navbar widget to its own file 92817bc4db
gelbeinhalb requested review from flixcoo 2025-11-08 17:06:45 +00:00
flixcoo reviewed 2025-11-08 17:13:05 +00:00
lib/presentation/widgets/navbar_item.dart Outdated
@@ -0,0 +22,4 @@
@override
Widget build(BuildContext context) {
bool isSelected = widget.currentIndex == widget.index;
flixcoo commented 2025-11-08 17:13:05 +00:00
Owner
Copy Link

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter

Ggf. andere möglichkeit finden für isSelected, übergeben als Parameter
gelbeinhalb commented 2025-11-08 22:59:40 +00:00
Author
Owner
Copy Link

ja überleg dir ma was

ja überleg dir ma was
flixcoo commented 2025-11-09 16:52:29 +00:00
Owner
Copy Link

Du könntest z.B. einen Parameter isSelected übergeben der gesetzt wird wenn currentIndex == 0 // 1, 2, 3, also folgendermaßen:

NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped)
Du könntest z.B. einen Parameter `isSelected` übergeben der gesetzt wird wenn `currentIndex == 0 // 1, 2, 3`, also folgendermaßen: ```dart NavbarItem(isSelected: currentIndex == 0, icon: Icons.home_rounded, label: 'Home', onTap: onTabTapped) ```
gelbeinhalb commented 2025-11-09 19:38:43 +00:00
Author
Owner
Copy Link

wäre das fine mit dir?

NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped )
wäre das fine mit dir? ```dart NavbarItem(index: 1, isSelected: currentIndex == 1, icon: Icons.gamepad_rounded, label: 'Games', onTabTapped: onTabTapped ) ```
flixcoo marked this conversation as resolved
gelbeinhalb added 1 commit 2025-11-09 19:49:31 +00:00
a bit cleaner solution 1b090a43a0
gelbeinhalb added 1 commit 2025-11-09 19:59:40 +00:00
Merge pull request 'pull from development' (#11) from development into enhancement/8-tabbar-angleichen a811e0933e 
Reviewed-on: #11
gelbeinhalb merged commit f1974cf71a into development 2025-11-09 19:59:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sneeex
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Priority
Low
4
Task
Enhancement
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees gelbeinhalb
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#9
Delete Branch "enhancement/8-tabbar-angleichen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?