liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 5 Actions Releases 1 Activity

Konsistenzfehler im JSON Vermeiden #125

Merged
flixcoo merged 12 commits from enhancement/70-konsistenzfehler-im-json-vermeiden into development 2026-01-07 11:27:44 +00:00
Conversation 7 Commits 12 Files Changed 5 +192 -204
gelbeinhalb commented 2026-01-02 19:42:32 +00:00
Owner
Copy Link

Konsistenzfehler im JSON Vermeiden

Zugehörige Issue(s):
Closes #70

Beschreibung

Um Redundanzfehler zu vermeiden, wurde der JSON Im- und Export neu strukturiert. Statt die Daten zu exportieren, wie sie als Objekt im Memory leben, werden Spieler oben im JSON definiert und nur von den Gruppen und Matches über ihre ids erwähnt.

Änderungen

  • Spieler und Gruppen werden gesammelt exportiert
  • Matches und Gruppen nutzen nurnoch ids um auf Spieler zu referenzieren

Zusätzliche Anmerkungen

Die example Daten wurden noch nicht erstellt. Kommt heute Abend (Nacht) noch.

# Konsistenzfehler im JSON Vermeiden **Zugehörige Issue(s):** Closes #70 ## Beschreibung Um Redundanzfehler zu vermeiden, wurde der JSON Im- und Export neu strukturiert. Statt die Daten zu exportieren, wie sie als Objekt im Memory leben, werden Spieler oben im JSON definiert und nur von den Gruppen und Matches über ihre ids erwähnt. ## Änderungen - [x] Spieler und Gruppen werden gesammelt exportiert - [x] Matches und Gruppen nutzen nurnoch ids um auf Spieler zu referenzieren ## Zusätzliche Anmerkungen Die example Daten wurden noch nicht erstellt. Kommt heute Abend (Nacht) noch.
gelbeinhalb added the
Task
Enhancement
Workflow
In Progress
3
Priority
Medium
3
Layer
BE
 labels 2026-01-02 19:42:32 +00:00
gelbeinhalb added 1 commit 2026-01-02 19:42:32 +00:00
change import/export json logic to remove redundant data
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m5s
Details
4a67dae456
sneeex removed the
Layer
BE
Priority
Medium
3
Task
Enhancement
 labels 2026-01-02 20:45:34 +00:00
sneeex added 1 commit 2026-01-02 20:45:48 +00:00
Merge branch 'development' into enhancement/70-konsistenzfehler-im-json-vermeiden
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m8s
Details
2f65316a51
gelbeinhalb was assigned by flixcoo 2026-01-03 10:48:56 +00:00
gelbeinhalb added 3 commits 2026-01-03 12:21:04 +00:00
update schema.json to current data import version cecfd5da4e
remove ?? as members cant be null 4c084cae4a
Merge branch 'enhancement/70-konsistenzfehler-im-json-vermeiden' of git.yannick-weigert.de:liquid-development/game-tracker into enhancement/70-konsistenzfehler-im-json-vermeiden
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m7s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
d9980edf0e
gelbeinhalb commented 2026-01-03 12:21:42 +00:00
Author
Owner
Copy Link

Import sollte alles klappen

Import sollte alles klappen
gelbeinhalb commented 2026-01-03 12:21:59 +00:00
Author
Owner
Copy Link

Export auch 😅

Export auch 😅
sneeex added 1 commit 2026-01-03 14:39:43 +00:00
Merge branch 'development' into enhancement/70-konsistenzfehler-im-json-vermeiden
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m24s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m27s
Details
1a20d7b64c
gelbeinhalb added 3 commits 2026-01-05 10:46:39 +00:00
change InsertMode to insertOrIgnore not insertOrReplace 7f6c1cb9a6
fix null error for winnerId and groupId in match import 7b2314a25e
Merge branch 'enhancement/70-konsistenzfehler-im-json-vermeiden' of git.yannick-weigert.de:liquid-development/game-tracker into enhancement/70-konsistenzfehler-im-json-vermeiden
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m3s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
2fea3597fe
gelbeinhalb commented 2026-01-05 11:07:14 +00:00
Author
Owner
Copy Link

Example Data

## Example Data
example-data-v6.json
9.2 KiB
example-data-v6-randomized-names.json
9.3 KiB
gelbeinhalb requested review from flixcoo 2026-01-05 11:08:05 +00:00
gelbeinhalb requested review from sneeex 2026-01-05 11:08:05 +00:00
gelbeinhalb changed title from WIP: Konsistenzfehler im JSON Vermeiden to Konsistenzfehler im JSON Vermeiden 2026-01-05 11:08:11 +00:00
gelbeinhalb added this to the Minimum Viable Product (MVP) milestone 2026-01-05 11:08:40 +00:00
sneeex added 1 commit 2026-01-05 15:03:40 +00:00
Merge branch 'development' into enhancement/70-konsistenzfehler-im-json-vermeiden
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m14s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m17s
Details
feaa0709a7
sneeex declined to review 2026-01-05 15:06:19 +00:00
flixcoo removed the
Layer
DB
Task
Enhancement
Priority
Medium
3
 labels 2026-01-05 20:12:04 +00:00
gelbeinhalb commented 2026-01-06 15:57:39 +00:00
Author
Owner
Copy Link

@sneeex warum kein review?

@sneeex warum kein review?
sneeex commented 2026-01-06 17:14:40 +00:00
Owner
Copy Link

@sneeex warum kein review?

Keine Ahnung davon

> @sneeex warum kein review? > Keine Ahnung davon
flixcoo approved these changes 2026-01-06 20:19:59 +00:00
Dismissed
lib/services/data_transfer_service.dart
@@ -95,2 +107,2 @@
final List<dynamic>? playersJson =
jsonData['players'] as List<dynamic>?;
final dynamic decoded = json.decode(jsonString);
if (decoded is! Map<String, dynamic>) return ImportResult.invalidSchema;
flixcoo commented 2026-01-06 20:07:49 +00:00
Owner
Copy Link

Macht das sinn hier? Ist nicht durch die schema Validierung das schon sichergestellt?

Macht das sinn hier? Ist nicht durch die schema Validierung das schon sichergestellt?
gelbeinhalb commented 2026-01-07 10:59:51 +00:00
Author
Owner
Copy Link

Ja an sich schon, das würde nur greifen, wenn die schema Validierung einen fehler macht.

Ja an sich schon, das würde nur greifen, wenn die schema Validierung einen fehler macht.
gelbeinhalb marked this conversation as resolved
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2026-01-06 20:20:19 +00:00
gelbeinhalb added 2 commits 2026-01-07 11:00:40 +00:00
remove unnecessary check 99044c0ea0
Merge branch 'enhancement/70-konsistenzfehler-im-json-vermeiden' of git.yannick-weigert.de:liquid-development/game-tracker into enhancement/70-konsistenzfehler-im-json-vermeiden
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m16s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m22s
Details
f140ebae2e
gelbeinhalb dismissed flixcoo's review 2026-01-07 11:00:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo approved these changes 2026-01-07 11:27:36 +00:00
flixcoo merged commit 0893667e41 into development 2026-01-07 11:27:44 +00:00
flixcoo deleted branch enhancement/70-konsistenzfehler-im-json-vermeiden 2026-01-07 11:27:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Minimum Viable Product (MVP)
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees gelbeinhalb
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#125
Delete Branch "enhancement/70-konsistenzfehler-im-json-vermeiden"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?