liquid-development/game-tracker
3
0
Fork 0
Code Issues 13 Pull Requests 5 Actions Releases 1 Activity

PageRoutes adaptable machen #145

Merged
flixcoo merged 10 commits from enhancement/128-PageRoutes-adaptable-machen into development 2026-01-10 14:06:10 +00:00
Conversation 5 Commits 10 Files Changed 7 +40 -15
sneeex commented 2026-01-09 21:24:18 +00:00
Owner
Copy Link

PageRoutes adaptable machen

Zugehörige Issue(s):
Closes #128

Beschreibung

Die PageRoutes wurden adaptable gemacht, MaterialPageRoute wird auf Android und CupertinoPageRoute auf IOS benutzt. Falls andere Plattform als IOS & Android genutzt wird, it als Fallback MaterialPageRoute definiert. Eigentlich ist die App aber ja garnicht für andere Geräte zugelassen laut Config (oder??).

# PageRoutes adaptable machen **Zugehörige Issue(s):** Closes #128 ## Beschreibung Die PageRoutes wurden adaptable gemacht, MaterialPageRoute wird auf Android und CupertinoPageRoute auf IOS benutzt. Falls andere Plattform als IOS & Android genutzt wird, it als Fallback MaterialPageRoute definiert. Eigentlich ist die App aber ja garnicht für andere Geräte zugelassen laut Config (oder??).
sneeex added the
PR
Ready for Review
2
 label 2026-01-09 21:24:18 +00:00
sneeex added 1 commit 2026-01-09 21:24:18 +00:00
made PageRoutes adapt to os, default to MaterialPageRoute
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m7s
Details
a4ef9705f9
sneeex requested review from Owners 2026-01-09 21:24:18 +00:00
sneeex commented 2026-01-09 21:29:19 +00:00
Author
Owner
Copy Link

felix, willst du noch die back gesture für ios implementieren? kann das ja nicht mangels ios simulator

felix, willst du noch die back gesture für ios implementieren? kann das ja nicht mangels ios simulator
👍 1
gelbeinhalb approved these changes 2026-01-10 12:30:49 +00:00
Dismissed
gelbeinhalb left a comment
Owner
Copy Link

lgtm

lgtm
flixcoo changed title from PageRoutes adaptable machen to WIP: PageRoutes adaptable machen 2026-01-10 12:35:04 +00:00
flixcoo changed title from WIP: PageRoutes adaptable machen to PageRoutes adaptable machen 2026-01-10 12:35:09 +00:00
flixcoo requested review from flixcoo 2026-01-10 12:35:13 +00:00
flixcoo added
PR
In Review
1
 and removed
PR
Ready for Review
2
 labels 2026-01-10 12:35:17 +00:00
flixcoo requested changes 2026-01-10 12:41:16 +00:00
Dismissed
flixcoo left a comment
Owner
Copy Link

Generelle Frage: Kannst du nicht einfach ein CustomPageRoute widget schreiben, und das an den Stellen einfügen, damit man nicht immer diese Platform.isIOS abfrage machen muss und das vor allem auch nicht ausversehen mal vergessen wird

Generelle Frage: Kannst du nicht einfach ein `CustomPageRoute` widget schreiben, und das an den Stellen einfügen, damit man nicht immer diese `Platform.isIOS` abfrage machen muss und das vor allem auch nicht ausversehen mal vergessen wird
flixcoo added 1 commit 2026-01-10 12:42:16 +00:00
Added ios swipe back gesture
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m1s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m6s
Details
db3e8215fa
flixcoo dismissed gelbeinhalb's review 2026-01-10 12:42:16 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo added this to the Alpha milestone 2026-01-10 12:42:31 +00:00
sneeex was assigned by flixcoo 2026-01-10 12:42:36 +00:00
flixcoo added 1 commit 2026-01-10 13:10:11 +00:00
Fixed issue with android page transition
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m1s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m5s
Details
66b90aac25
flixcoo added 1 commit 2026-01-10 13:16:22 +00:00
Changed android page transition to Android U transition
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m5s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m8s
Details
6faafe9fab
sneeex added 2 commits 2026-01-10 13:45:23 +00:00
replaced ternary operator solution with custom adaptive_page_route.dart d67972624e
Merge remote-tracking branch 'origin/enhancement/128-PageRoutes-adaptable-machen' into enhancement/128-PageRoutes-adaptable-machen
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m4s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m10s
Details
32fb1550ff 
# Conflicts:
#	lib/main.dart
sneeex requested review from flixcoo 2026-01-10 13:45:32 +00:00
sneeex added 1 commit 2026-01-10 13:53:02 +00:00
refactor: rename AdaptivePageRoute to adaptivePageRoute for lowerCamelCase
All checks were successful
Pull Request Pipeline / lint (pull_request) Successful in 2m13s
Details
Pull Request Pipeline / test (pull_request) Successful in 2m18s
Details
97ca62b083
flixcoo approved these changes 2026-01-10 13:56:08 +00:00
Dismissed
sneeex added 2 commits 2026-01-10 14:00:37 +00:00
Merge remote-tracking branch 'origin/development' into enhancement/128-PageRoutes-adaptable-machen d5e7a17127 
# Conflicts:
#	lib/presentation/views/main_menu/match_view/create_match/create_match_view.dart
fix merge issues
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 2m14s
Details
Pull Request Pipeline / lint (pull_request) Failing after 2m23s
Details
54ec865f04
sneeex dismissed flixcoo's review 2026-01-10 14:00:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

sneeex added 1 commit 2026-01-10 14:02:04 +00:00
remove unneccessary import
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 2m18s
Details
Pull Request Pipeline / lint (pull_request) Successful in 2m18s
Details
9eb9c0eb7f
sneeex requested review from Owners 2026-01-10 14:02:21 +00:00
flixcoo approved these changes 2026-01-10 14:06:07 +00:00
flixcoo merged commit 14a043785e into development 2026-01-10 14:06:10 +00:00
flixcoo deleted branch enhancement/128-PageRoutes-adaptable-machen 2026-01-10 14:06:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Refactoring
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
flixcoo gelbeinhalb sneeex
No Assignees sneeex
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#145
Delete Branch "enhancement/128-PageRoutes-adaptable-machen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?