liquid-development/game-tracker
3
1
Fork 0
Code Issues 7 Pull Requests 4 Actions Releases 1 Activity

Verschiedene Regelsätze implementieren #194

Merged
flixcoo merged 46 commits from feature/132-verschiedene-regelsaetze-implementieren into development 2026-04-24 10:31:36 +00:00
Conversation 4 Commits 46 Files Changed 38 +1000 -489
flixcoo commented 2026-03-08 07:32:45 +00:00
Owner
Copy Link

Zugehörige Issue(s)

Closes #132

Beschreibung

Es wurden die vier Regelsätze implementiert, so dass Matches mit diesen gespielt werden können, Punkte und Angaben richtig verarbeitet und angezeigt werden.

Änderungen

  • Neue Ansicht zur MatchResultView hinzugefügt: Bei lowestScore und highestScore können jetzt Punkte mit Hilfe der ScoreListTile für jeden Spieler eingtragen werden.
  • winner-Attribut aus match-Klasse durch Getter-Methode mvp ersetzt, welche dynamisch den gewinner berechnet und nicht mehr selbst in der klasse speichert
  • Jede Usage von winner durch mvp ersetzt und nach Bedarf angepasst
  • In scores werden bis auf weiteres nur ein Score-Objekt pro Spieler gespeichert
  • Methoden getWinner() und getLooser() angepasst
  • JSON-Handling des scores-Attribut angepasst
  • Games-Auswahl zu Testzwecken implementiert, Erstellung der Games kommt dann in #119
  • Zu Testzwecken Anzeige von Game / Ruleset in MatchTiles implementiert
  • MVP Text/Icon wird je nach Ruleset variiert
  • JSON -Erstellung in getAppDataAsJson() vereinfacht
  • JSON-Schema angepasst & neue Testdaten erstellt

Zusätzliche Anmerkungen

Dieser PR ist relativ groß, das meiste sind aber nur fortlaufende Anpassungen zu Änderungen(z.B. bei der mvp-Variable, wo jedes Vorkommen von winner angepasst werden musste, weil mvp statt einem Player eine List<Player> zurückgibt

### Zugehörige Issue(s) Closes #132 ### Beschreibung Es wurden die vier Regelsätze implementiert, so dass Matches mit diesen gespielt werden können, Punkte und Angaben richtig verarbeitet und angezeigt werden. ### Änderungen - [x] Neue Ansicht zur `MatchResultView` hinzugefügt: Bei `lowestScore` und `highestScore` können jetzt Punkte mit Hilfe der `ScoreListTile` für jeden Spieler eingtragen werden. - [x] `winner`-Attribut aus `match`-Klasse durch Getter-Methode `mvp` ersetzt, welche dynamisch den gewinner berechnet und nicht mehr selbst in der klasse speichert - [x] Jede Usage von `winner` durch `mvp` ersetzt und nach Bedarf angepasst - [x] In `scores` werden bis auf weiteres nur ein Score-Objekt pro Spieler gespeichert - [x] Methoden `getWinner()` und `getLooser()` angepasst - [x] JSON-Handling des `scores`-Attribut angepasst - [x] Games-Auswahl zu Testzwecken implementiert, Erstellung der Games kommt dann in #119 - [x] Zu Testzwecken Anzeige von Game / Ruleset in `MatchTile`s implementiert - [x] MVP Text/Icon wird je nach Ruleset variiert - [x] JSON -Erstellung in `getAppDataAsJson()` vereinfacht - [x] JSON-Schema angepasst & neue Testdaten erstellt ### Zusätzliche Anmerkungen Dieser PR ist relativ groß, das meiste sind aber nur fortlaufende Anpassungen zu Änderungen(z.B. bei der `mvp`-Variable, wo jedes Vorkommen von `winner` angepasst werden musste, weil `mvp` statt einem `Player` eine `List<Player>` zurückgibt
flixcoo added this to the Alpha milestone 2026-03-08 07:32:45 +00:00
flixcoo self-assigned this 2026-03-08 07:32:45 +00:00
flixcoo added 3 commits 2026-03-08 07:32:45 +00:00
Updated dependencie 975679b048
Added localizations 494dec8c61
Implemented basic structure
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 39s
Details
Pull Request Pipeline / lint (pull_request) Failing after 44s
Details
c50ad288fa
flixcoo added 2 commits 2026-03-08 10:00:51 +00:00
Merge branch 'development' into feature/132-verschiedene-regelsaetze-implementieren 544e55c4fd 
# Conflicts:
#	lib/l10n/arb/app_de.arb
#	lib/l10n/arb/app_en.arb
#	lib/l10n/generated/app_localizations.dart
#	lib/l10n/generated/app_localizations_de.dart
#	lib/l10n/generated/app_localizations_en.dart
#	lib/presentation/views/main_menu/match_view/match_result_view.dart
Fixed match edit error with game
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 39s
Details
Pull Request Pipeline / lint (pull_request) Failing after 46s
Details
84b8541822
flixcoo added 2 commits 2026-03-08 21:26:08 +00:00
Implememented different result tiles in match detail view for different rulesets d5a7bb320f
Implemented different result view depending on ruleset
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 38s
Details
Pull Request Pipeline / lint (pull_request) Failing after 45s
Details
f0c575d2c9
flixcoo added the
Workflow
On Hold
3
 label 2026-03-08 21:26:16 +00:00
flixcoo commented 2026-03-08 21:26:32 +00:00
Author
Owner
Copy Link

Wartet auf #191

Wartet auf #191
flixcoo added a new dependency 2026-03-08 21:26:39 +00:00
#191 Score implementation ergänzen
flixcoo added 1 commit 2026-03-08 21:27:31 +00:00
Fix: Linter exclude
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 40s
Details
Pull Request Pipeline / lint (pull_request) Successful in 46s
Details
9b2fcf1860
gelbeinhalb started working 2026-03-11 19:07:14 +00:00
gelbeinhalb worked for 2 seconds 2026-03-11 19:07:16 +00:00
gelbeinhalb deleted spent time 2026-03-11 19:07:24 +00:00
- 2 seconds
flixcoo removed the
Workflow
On Hold
3
 label 2026-04-14 16:12:15 +00:00
flixcoo added 2 commits 2026-04-14 22:09:33 +00:00
Merge branch 'development' into feature/132-verschiedene-regelsaetze-implementieren df1bc4bf32 
# Conflicts:
#	lib/presentation/views/main_menu/match_view/match_result_view.dart
Implemented ruleset in match view
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 43s
Details
Pull Request Pipeline / lint (pull_request) Failing after 46s
Details
ddf32797aa
flixcoo added 23 commits 2026-04-21 20:22:45 +00:00
Added function for point label 1363c1fb06
Added point localizations 316a50dad0
Added tie localization 522441b0ca
Updated score and winner handling 9364f0d9d6
Updated getting winner & looser functions c6a9e53cff
Updated localization declaration 86f2ba01e5
Updated game + ruleset display 68141a3da2
Removed dead code 9230b0caba
Added empty check for score fields 5e6cf22a9f
Added null & empty handling 2c2bb582fd
Implemented basic game choosing functionality 4322e75811
Adjusted colors 0bad0862a7
Removed unnecessary declared attributes 2035e5b7d4
Fixed tests 31c6e03f4d
Added toString method + default values 571d32f07a
Implemented correct score handling 543b4d949e
Fixed bug f24aeff55a
Fixed json methods a3ae8ef5b8
Formatting b0a8529c1c
Added missing score import b1abbf6376
Fixed tests e910f1dcd3
Updated skeleton data dfc7788087
Fixed state bug
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 55s
Details
Pull Request Pipeline / lint (pull_request) Successful in 57s
Details
b4b598d1f5
flixcoo added 1 commit 2026-04-21 20:22:58 +00:00
Merge branch 'development' into feature/132-verschiedene-regelsaetze-implementieren
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 52s
Details
Pull Request Pipeline / lint (pull_request) Successful in 56s
Details
852b5f444c
flixcoo added 4 commits 2026-04-21 21:25:20 +00:00
Removed game in compact mode 5cbcf626e8
simplified json map d381036849
Updated json schmema bdb33f1ec8
Updated packages
Some checks failed
Pull Request Pipeline / lint (pull_request) Failing after 17s
Details
Pull Request Pipeline / test (pull_request) Failing after 18s
Details
0b991026c7
flixcoo added 1 commit 2026-04-21 21:26:35 +00:00
Downgraded flutter again
Some checks failed
Pull Request Pipeline / lint (pull_request) Failing after 17s
Details
Pull Request Pipeline / test (pull_request) Failing after 19s
Details
52518dc525
flixcoo added 1 commit 2026-04-21 21:27:41 +00:00
Downgraded flutter again
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 45s
Details
Pull Request Pipeline / lint (pull_request) Successful in 47s
Details
1a2ad547be
flixcoo added 1 commit 2026-04-21 21:36:12 +00:00
Fixed versioning
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 50s
Details
Pull Request Pipeline / lint (pull_request) Successful in 53s
Details
db554557fe
flixcoo added 1 commit 2026-04-21 21:39:49 +00:00
Removed unnecessary function
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 48s
Details
a7e234cf10
flixcoo added 1 commit 2026-04-21 21:40:58 +00:00
Removed unnecessary table association
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 48s
Details
2fe43a5ad1
flixcoo added 2 commits 2026-04-21 22:19:54 +00:00
Added fallback 6f0147420a
Added ruleset depending icons and adjusted mvp text
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 45s
Details
Pull Request Pipeline / lint (pull_request) Successful in 47s
Details
23b903e28a
flixcoo added the
PR
Ready for Review
2
 label 2026-04-21 22:24:21 +00:00
flixcoo requested review from Owners 2026-04-21 22:24:24 +00:00
flixcoo changed title from WIP: Verschiedene Regelsätze implementieren to Verschiedene Regelsätze implementieren 2026-04-21 22:24:30 +00:00
flixcoo commented 2026-04-21 23:45:15 +00:00
Author
Owner
Copy Link

Die neuen Testdaten:

Die neuen Testdaten:
example-data-v10.json
18 KiB
gelbeinhalb approved these changes 2026-04-23 12:26:04 +00:00
Dismissed
gelbeinhalb left a comment
Owner
Copy Link

sieht gut aus :)

sieht gut aus :)
flixcoo added 1 commit 2026-04-24 10:20:08 +00:00
Merge branch 'development' into feature/132-verschiedene-regelsaetze-implementieren
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 54s
Details
1d02c04b7a 
# Conflicts:
#	lib/core/common.dart
#	lib/presentation/views/main_menu/statistics_view.dart
#	lib/presentation/widgets/player_selection.dart
flixcoo dismissed gelbeinhalb's review 2026-04-24 10:20:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

flixcoo scheduled this pull request to auto merge when all checks succeed 2026-04-24 10:20:19 +00:00
flixcoo requested review from gelbeinhalb 2026-04-24 10:20:30 +00:00
gelbeinhalb approved these changes 2026-04-24 10:31:34 +00:00
flixcoo merged commit 7effa77f82 into development 2026-04-24 10:31:36 +00:00
flixcoo deleted branch feature/132-verschiedene-regelsaetze-implementieren 2026-04-24 10:31:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gelbeinhalb
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Proposal
This issue contains a proposal for a new feature, change, or improvement. It is open for discussion and feedback before any decision is made.
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Hotfix
Task
Refactoring
Tasks that only involve refactoring and do not add any new functionality
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Technical Debt
Issues related to code that needs to be refactored, cleaned up, or improved due to shortcuts or outdated implementations and to keep the codebase maintainable.
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
Ready for Review
2
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
actions flixcoo gelbeinhalb sneeex
No Assignees flixcoo
2 Participants
Notifications
Due Date
No due date set.
Depends on
#191 Score implementation ergänzen
liquid-development/game-tracker
Reference: liquid-development/game-tracker#194
Delete Branch "feature/132-verschiedene-regelsaetze-implementieren"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?