liquid-development/game-tracker
3
1
Fork 0
Code Issues 7 Pull Requests 4 Actions Releases 1 Activity

Spielerprofile implementieren #221

Open
sneeex wants to merge 0 commits from feature/180-Spielerprofile-implementieren into development
pull from: feature/180-Spielerprofile-implementieren
merge into: liquid-development:development
Conversation 2 Commits - Files Changed -
sneeex commented 2026-05-19 17:57:45 +00:00
Owner
Copy Link

Zugehörige Issue(s)

Closes #180

Beschreibung

Spielerprofile implementiert

Änderungen

  • beim Tappen auf die Spieler in Match und Group View kommt man nun zum PlayerDetailView
  • dort sieht man Infos zu jedem einzelnen Spieler
    • Gruppen
    • Matches
    • Anzahl Matches/Wins/Winquote
  • außerdem lässt sich der Name von Spielern ändern
### Zugehörige Issue(s) Closes #180 ### Beschreibung Spielerprofile implementiert ### Änderungen - beim Tappen auf die Spieler in Match und Group View kommt man nun zum PlayerDetailView - dort sieht man Infos zu jedem einzelnen Spieler - Gruppen - Matches - Anzahl Matches/Wins/Winquote - außerdem lässt sich der Name von Spielern ändern
sneeex added this to the Alpha milestone 2026-05-19 17:57:45 +00:00
sneeex self-assigned this 2026-05-19 17:57:45 +00:00
sneeex added 1 commit 2026-05-20 13:15:50 +00:00
implement basic player_detail_view.dart
Some checks failed
Pull Request Pipeline / test (pull_request) Successful in 45s
Details
Pull Request Pipeline / lint (pull_request) Failing after 51s
Details
b305145d34
sneeex added 1 commit 2026-05-20 17:50:39 +00:00
add player change callbacks and improve player detail view
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 47s
Details
Pull Request Pipeline / lint (pull_request) Failing after 53s
Details
869c70ff63
flixcoo added 1 commit 2026-05-20 17:59:06 +00:00
fix: player count calc error
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 44s
Details
Pull Request Pipeline / lint (pull_request) Failing after 52s
Details
679e869229
sneeex added 1 commit 2026-05-21 07:47:52 +00:00
made alertDialog Confirm Button deactivate based on input, fix app skeleton alignment issue, implement correct nameCount Display
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 42s
Details
Pull Request Pipeline / lint (pull_request) Failing after 51s
Details
b61a93328f
sneeex added 1 commit 2026-05-21 08:33:20 +00:00
implement missing localization
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 47s
Details
Pull Request Pipeline / lint (pull_request) Failing after 56s
Details
9909d959b0
sneeex added 1 commit 2026-05-21 08:34:05 +00:00
fix linter issues
Some checks failed
Pull Request Pipeline / test (pull_request) Failing after 44s
Details
Pull Request Pipeline / lint (pull_request) Successful in 56s
Details
2a38462c57
flixcoo added 2 commits 2026-05-21 13:45:35 +00:00
fix: name count 82095ab41a
fix: tests for name count
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 54s
Details
ccb0d32c54
sneeex added 1 commit 2026-05-21 14:09:03 +00:00
feat: add player creation callbacks to update member and match lists when group/match creation is canceled but player created
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 55s
Details
bf2cd2bf58
sneeex commented 2026-05-21 18:07:00 +00:00
Author
Owner
Copy Link

brauche hier deinen bugfix deger bruder

brauche hier deinen bugfix deger bruder
flixcoo added 1 commit 2026-05-21 21:58:05 +00:00
fix: updatePlayerName corrects the name count after renaming to different name
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 55s
Details
9adcc29cda
sneeex added 2 commits 2026-05-22 06:45:44 +00:00
feat: add localization for no matches played and not part of any group 78c59a9b52
Merge remote-tracking branch 'origin/feature/180-Spielerprofile-implementieren' into feature/180-Spielerprofile-implementieren
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 47s
Details
Pull Request Pipeline / lint (pull_request) Successful in 54s
Details
25bc213769
flixcoo added 2 commits 2026-05-22 18:06:32 +00:00
fix: name count 3 player issue 4dcd4f0f71
feat: updatePlayerName keeps created order in nameCount
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 54s
Details
5a652a5f2c
flixcoo changed title from WIP: Spielerprofile implementieren to Spielerprofile implementieren 2026-05-22 18:20:19 +00:00
flixcoo requested review from Owners 2026-05-22 18:20:22 +00:00
flixcoo added the
PR
In Review
1
 label 2026-05-22 18:20:25 +00:00
flixcoo requested changes 2026-05-22 18:38:35 +00:00
flixcoo left a comment
Owner
Copy Link

Folgende Features wären sinnvoll zu ergänzen:

  • In MatchDetailView / GroupDetailView ebenfalls Spielertiles klickbar machen.
  • In PlayerDetailView die Tiles für Matches und Gruppen ebenfalls klickbar machen. Man könnte dann sagen, dass man mit Navigator.pushReplacement dafür sorgt, das man nicht ewigkeiten wieder zurückggehen muss.
Folgende Features wären sinnvoll zu ergänzen: - In `MatchDetailView` / `GroupDetailView` ebenfalls Spielertiles klickbar machen. - In `PlayerDetailView` die Tiles für Matches und Gruppen ebenfalls klickbar machen. Man könnte dann sagen, dass man mit `Navigator.pushReplacement` dafür sorgt, das man nicht ewigkeiten wieder zurückggehen muss.
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +177,4 @@
textAlign: TextAlign.center,
),
const SizedBox(height: 20),
InfoTile(
flixcoo commented 2026-05-22 18:32:25 +00:00
Owner
Copy Link

Ich würd glaub ich hier die Reihenfolge tauschen, zu erst die Gruppen, dann die Matches

Ich würd glaub ich hier die Reihenfolge tauschen, zu erst die Gruppen, dann die Matches
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +178,4 @@
),
const SizedBox(height: 20),
InfoTile(
title: '${loc.matches_part_of} ($totalMatches)',
flixcoo commented 2026-05-22 18:31:57 +00:00
Owner
Copy Link

Ich würde hier liebe einfach "Matches" bzw "Spiele" schreiben, ich find "Spiele Teil von" klingt einfach irgendwie komisch. Außerdem könntest du die Zahl daneben entweder an den rechten Rand der Zeile oder unten in die Statistiken schieben

Ich würde hier liebe einfach "Matches" bzw "Spiele" schreiben, ich find "Spiele Teil von" klingt einfach irgendwie komisch. Außerdem könntest du die Zahl daneben entweder an den rechten Rand der Zeile oder unten in die Statistiken schieben
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +192,4 @@
spacing: 12,
runSpacing: 8,
children: playerMatches.map((match) {
return TextIconTile(
flixcoo commented 2026-05-22 18:33:15 +00:00
Owner
Copy Link

Ich würde irgendwie diese Match Einträge noch erweitern. Nur die Namen in gleicher Optik wie sonst Spieler find ich komisch. Vielleciht kannst du hier noch das Game ergänzen und die andere Tiles dafür designen?

Ich würde irgendwie diese Match Einträge noch erweitern. Nur die Namen in gleicher Optik wie sonst Spieler find ich komisch. Vielleciht kannst du hier noch das Game ergänzen und die andere Tiles dafür designen?
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +209,4 @@
),
const SizedBox(height: 15),
InfoTile(
title: '${loc.groups_part_of} ($totalGroups)',
flixcoo commented 2026-05-22 18:32:05 +00:00
Owner
Copy Link

hier ähnlich, siehe oben

hier ähnlich, siehe oben
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +223,4 @@
spacing: 12,
runSpacing: 8,
children: playerGroups.map((group) {
return TextIconTile(
flixcoo commented 2026-05-22 18:33:35 +00:00
Owner
Copy Link

Hier ebenefalls anderes Design, z.B. mit Anzahl Gruppenmitglieder dann

Hier ebenefalls anderes Design, z.B. mit Anzahl Gruppenmitglieder dann
lib/presentation/views/main_menu/player_detail_view.dart
@@ -0,0 +247,4 @@
fixLayoutBuilder: true,
child: Column(
children: [
_buildStatRow(
flixcoo commented 2026-05-22 18:34:28 +00:00
Owner
Copy Link

Hier könnte man das "Teil von X Matches"/"Teil von X Gruppen" dazunehmen

Hier könnte man das "Teil von X Matches"/"Teil von X Gruppen" dazunehmen
lib/presentation/widgets/app_skeleton.dart
@@ -52,3 +56,3 @@
},
),
child: widget.child,
child: widget.fixLayoutBuilder
flixcoo commented 2026-05-22 18:27:10 +00:00
Owner
Copy Link

Irgendwie scheint durch die Änderungen hier der Fix für das Problem nicht mehr zu gehen

Irgendwie scheint durch die Änderungen hier der Fix für das Problem nicht mehr zu gehen
Simulator Screen Recording - iPhone 17 - 2026-05-22 at 20.26.43.mov
2.3 MiB
flixcoo added 1 commit 2026-05-22 22:22:08 +00:00
Merge branch 'development' into feature/180-Spielerprofile-implementieren
All checks were successful
Pull Request Pipeline / test (pull_request) Successful in 46s
Details
Pull Request Pipeline / lint (pull_request) Successful in 53s
Details
Pull Request Pipeline / localizations (pull_request) Successful in 25s
Details
fad5a392cd 
# Conflicts:
#	lib/l10n/arb/app_de.arb
#	lib/l10n/arb/app_en.arb
#	lib/l10n/generated/app_localizations.dart
#	lib/l10n/generated/app_localizations_de.dart
#	lib/l10n/generated/app_localizations_en.dart
flixcoo added 1 commit 2026-05-22 22:43:05 +00:00
Merge branch 'development' into feature/180-Spielerprofile-implementieren
All checks were successful
Pull Request Pipeline / lint (pull_request) Successful in 51s
Details
Pull Request Pipeline / localizations (pull_request) Successful in 28s
Details
Pull Request Pipeline / test (pull_request) Successful in 49s
Details
1f17b80f64
All checks were successful
Pull Request Pipeline / lint (pull_request) Successful in 51s
Required
Details
Pull Request Pipeline / localizations (pull_request) Successful in 28s
Required
Details
Pull Request Pipeline / test (pull_request) Successful in 49s
Required
Details
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/180-Spielerprofile-implementieren:feature/180-Spielerprofile-implementieren
git checkout feature/180-Spielerprofile-implementieren
Sign in to join this conversation.
Reviewers
No Reviewers
flixcoo
Labels
Clear labels
Duplicate
This issue or pull request already exists
Layer
BE
Issues/PRs related to the backend
Layer
DB
Issues/PRs related to the database
Layer
FE
Issues/PRs related to the frontend
Layer
Full Stack
Issues/PRs spanning multiple layers (frontend, backend, database)
PR
In Review
1
Pull Request that is reviewed
PR
Ready for Review
2
Pull Requests which are ready to be reviewed
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Proposal
This issue contains a proposal for a new feature, change, or improvement. It is open for discussion and feedback before any decision is made.
Task
Bug
Reports of unexpected behavior or defects in existing functionality.
Task
Documentation
Tasks related to improving or adding documentation (READMEs, code comments, guides).
Task
Enhancement
Improvements or optimizations to existing features (non-breaking changes).
Task
Feature
Requests for new functionality or significant additions to the project.
Task
Hotfix
Task
Refactoring
Tasks that only involve refactoring and do not add any new functionality
Task
Setup
Tasks related to project configuration, tooling, or infrastructure.
Task
Testing
Issue or pull request related to testing
Technical Debt
Issues related to code that needs to be refactored, cleaned up, or improved due to shortcuts or outdated implementations and to keep the codebase maintainable.
Workflow
Abandoned
4
Somebody has started to work on this but abandoned work
Workflow
Backlog
4
Issues/PRs that are acknowledged but not being actively worked on yet.
Workflow
In Progress
3
Issues/PRs currently being actively worked on.
Workflow
On Hold
3
Issues/PRs temporarily being paused or blocked.
Workflow
Won't Fix
5
This issue won't be fixed
No Label
PR
In Review
1
Milestone
No items
No Milestone Alpha
Assignees
Clear assignees
actions flixcoo gelbeinhalb sneeex
No Assignees sneeex
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liquid-development/game-tracker#221
Delete Branch "feature/180-Spielerprofile-implementieren"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?